RFR: 8301584: Generational ZGC: Add barrier elision tests [v2]

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Wed Feb 8 12:26:18 UTC 2023


On Mon, 6 Feb 2023 10:58:21 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> Roberto Castañeda Lozano has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Add missing include
>>  - Fix include order
>
> src/hotspot/share/gc/shared/c2/barrierSetC2.hpp line 33:
> 
>> 31: #include "opto/matcher.hpp"
>> 32: #include "opto/memnode.hpp"
>> 33: #include "opto/machnode.hpp"
> 
> Include order

Done.

> src/hotspot/share/opto/machnode.cpp line 26:
> 
>> 24: 
>> 25: #include "precompiled.hpp"
>> 26: #include "gc/shared/barrierSet.hpp"
> 
> Seems to need `#include "gc/shared/c2/barrierSetC2.hpp"` on some platforms (just looking at your GHA)

Good catch, done!

-------------

PR: https://git.openjdk.org/zgc/pull/12


More information about the zgc-dev mailing list