[OpenJDK 2D-Dev] Code review request to integrate IcedTea Color.createContext fix into OpenJDK 6
Joe.Darcy at Sun.COM
Fri Aug 8 03:10:56 UTC 2008
I've made the requested edits, verified the JCK tests still pass, and
putback the change in OpenJDK 6 b12.
Dmitri Trembovetski wrote:
> Hi Joe,
> A couple of comments:
> One is that the ColorModel check is not really needed
> since ColorPaintContext doesn't use the passed color model
> and in fact ignores it if you look at the code so
> there's no need to create a new one for different CM.
> So the color model check should be removed.
> Another is a minor stylistic one: Java2D code in general
> uses braces for all if statements, and 4 spaces offset.
> Also, for cases like this one with multiline conditions
> we put the opening curly brace on the new line (against
> the java style guideline) so that the next statement is
> easier to distinguish from the condition:
> if (multi
> // stuff
> Please change it to follow.
> Joe Darcy wrote:
>> Please review my application of the Color.createContext fix Keith
>> previously sent to the list
>> to OpenJDK 6. I've done a build and the JCK tests in question now pass.
>> Webrev uploaded to:
More information about the 2d-dev