[OpenJDK 2D-Dev] [PATCH] 6636469: Java Fullscreen Exclusive Mode not working with Xorg server 1.3.0 and above
Dmitri.Trembovetski at Sun.COM
Thu Jan 17 18:40:00 UTC 2008
the patch looks fine.
The only thing is that we typically try to avoid
the use of goto if possible (like in this case since you
don't win much by using it), so I'd suggest to
+ return JNI_FALSE;
+ goto return_false;
Disabling fullscreen for multiscreen systems is ok with
I agree that it'll be hard to create a robust automated
test for this bug (and there's plenty of manual tests
already, adding a new one won't be of much benefit),
so I suggest we skip on regression test for this one.
Regarding testing configurations: I have requested
a sparc system with Nevada (so that it has the new X server),
and also an x86/64 machine for linux/solaris. Once
we have those set up we can proceed with the integration.
Dan Munckton wrote:
> Please disregard all of my previous patches. I've just fixed a logic
> error I made when checking the RANDR version. Now fixed, patch v3
> Dan Munckton
More information about the 2d-dev