[OpenJDK 2D-Dev] [PATCH] FontManager refactoring, rev6

Phil Race Phil.Race at Sun.COM
Wed Aug 5 23:17:37 UTC 2009


Roman Kennke wrote:
> Hi there,
> 6th round of the FontManager refactoring.

Can I assume you changed nothing except what you call out here ?

In which case I'm fine except for one thing :

>> WPathGraphics.java
>> I see you moved the definition of textLayoutIsCompatible in here.
>> Whilst its used only by this code, its also meaning that updating
>> that font internal code in the future will affect the printing code.
>> And the getDirectoryEntry() method isn't public so I'm not sure
>> how this will work! Ah, I just remembered you said you didn't test
>> on windows yet. Puzzlement over, this won't build. I'd prefer this
>> to go back to TrueTypeFont.

you've resolved this by making getDirectoryEntry() public whereas
I asked that you move textLayoutIsCompatible back to the font code
where I believe it belongs.


More information about the 2d-dev mailing list