[OpenJDK 2D-Dev] Various fixes to pisces stroke widening code

Denis Lila dlila at redhat.com
Mon Aug 2 14:40:50 UTC 2010

Hello Jim.

> I'm guessing the test for "y == boundsMaxY-1" at line 470 could
> probably also be deleted now (since it will be handled by the end 
> test when y reaches maxY)?

Indeed it can. I've done this, and also updated a few comments that
might have been misleading (they were written before certain changes
were made).

> It looks fine.  Hopefully we can eventually figure out why the sorting
> on the fly didn't pan out.

Wonderful! So, will it be committed?


----- "Jim Graham" <james.graham at oracle.com> wrote:

> Hi Denis,

> Denis Lila wrote:
> > Hi Jim. 
> > 
> >     Thanks for all your suggestions. I fixed the edge array
> indexing
> > issue, the moveTo bug (not assigning x0), and the double
> > initialization issue. I also improved the emission of the last row
> > to what you said. The link is the same as the last one I sent.

> But everything looks in order!
> 			...jim

More information about the 2d-dev mailing list