[OpenJDK 2D-Dev] X11 uniform scaled wide lines and dashed lines; STROKE_CONTROL in Pisces
dlila at redhat.com
Tue Aug 10 21:06:05 UTC 2010
So, I have the nicer webrevs.
Pisces flattening version:
I dealt with the issue of handling OFF by just not accepting it as an input.
After all, a normalizing iterator only needs to be created, and is only created
if the normalization mode is not OFF.
----- "Jim Graham" <james.graham at oracle.com> wrote:
> Hi Denis,
> I'll wait for some clean webrevs once you get the float stuff in for a
> final review. I did take a really quick look and thought that a
> way to handle "OFF" would be to set rval to -1 and then check "rval <
> as the (quicker) test for OFF in the currentSegment() method. Does
> make sense?
> In any case, let's wait for cleaner webrevs to go further on this
> (hopefully in a day or so?)...
> On 8/5/2010 8:06 AM, Denis Lila wrote:
> > Hi Jim.
> > I made all the suggested changes.
> > Links:
> > Thanks,
> > Denis.
> > ----- "Jim Graham"<james.graham at oracle.com> wrote:
> >> Hi Denis,
> >> First, comments on the high level normalizer (Normalizing
> >> - If there is no normalization going on, I would use the Shape's
> >> flattening (i.e. getPathIterator(at, flat)). The reason being
> >> some
> >> shapes may know how to flatten themselves better, or faster, than
> >> Flattening Iterator. In particular, rectangles and polygons would
> >> simply ignore the argument and save themselves the cost of
> >> with
> >> an extra iterator. This would probably only be a big issue for
> >> long Polygons.
> >> - Line 331 - the initializations to NaN aren't necessary as far as
> >> can
> >> tell...?
> >> - Rather than saving "mode" in the normalizing iterator, how about
> >> saving 2 constants: (0.0, 0.5) for AA and (0.25, 0.25) for non-AA
> >> then simply add those constants in rather than having to have the
> >> conditional with the 2 different equations?
> >> ...jim
More information about the 2d-dev