From Roman.Kennke at Sun.COM Mon Feb 1 20:02:16 2010 From: Roman.Kennke at Sun.COM (Roman Kennke) Date: Mon, 01 Feb 2010 21:02:16 +0100 Subject: [OpenJDK 2D-Dev] [PATCH] Request for review: 6888734, regression test fails when java.security.manager is enabled In-Reply-To: <4B1EA093.1040402@sun.com> References: <1255612943.10319.3.camel@moonlight> <1259591298.7241.446.camel@moonlight> <4B141ABB.9090209@sun.com> <1259613172.7241.1640.camel@moonlight> <4B143B08.8090109@sun.com> <1260216773.8439.7.camel@moonlight> <4B1EA093.1040402@sun.com> Message-ID: <1265054536.2698.10.camel@moonlight> Am Dienstag, den 08.12.2009, 10:53 -0800 schrieb Igor Nekrestyanov: > As Dmitri mentioned you need to move policy file too. Otherwise test > will not work in new location when run with jtreg. So I finally found some time to get back at this. I added the policy file too: http://cr.openjdk.java.net/~rkennke/6888734/webrev.03/ Is this ok now to push? Thanks, Roman > > Rest looks good to me. > > -igor > > On 12/7/09 12:12 PM, Roman Kennke wrote: > > Hi Phil, > > > > Am Montag, den 30.11.2009, 13:37 -0800 schrieb Phil Race: > > > >> Roman Kennke wrote: > >> > >>> I added the (previously closed) testcase, keeping it in the same > >>> relative directory location: > >>> > >>> http://cr.openjdk.java.net/~rkennke/6888734/webrev.01/ > >>> > >>> Is this ok? > >>> > >>> > >> Almost. Reg tests don't have the classpath exception. > >> > > Fixed. > > > > > >> And probably the copyright year should be a range, starting > >> with whatever the existing year is. > >> > > This file is added to the closed repository in 2007, with the initial > > commit, it doesn't say anything how old this file is. I put it in > > OpenJDK in 2009, this is why I say so in the header. What else can I do? > > > > Also, we need one more review, Igor, can you have a look? > > > > http://cr.openjdk.java.net/~rkennke/6888734/webrev.02/ > > > > Thanks, Roman > > > > > > > > > From Dmitri.Trembovetski at Sun.COM Mon Feb 1 20:07:15 2010 From: Dmitri.Trembovetski at Sun.COM (Dmitri Trembovetski) Date: Mon, 01 Feb 2010 12:07:15 -0800 Subject: [OpenJDK 2D-Dev] [PATCH] Request for review: 6888734, regression test fails when java.security.manager is enabled In-Reply-To: <1265054536.2698.10.camel@moonlight> References: <1255612943.10319.3.camel@moonlight> <1259591298.7241.446.camel@moonlight> <4B141ABB.9090209@sun.com> <1259613172.7241.1640.camel@moonlight> <4B143B08.8090109@sun.com> <1260216773.8439.7.camel@moonlight> <4B1EA093.1040402@sun.com> <1265054536.2698.10.camel@moonlight> Message-ID: <4B673473.7000002@Sun.COM> Looks ok to me except the copyright on the test should probably be 2010 now =) Dmitri Roman Kennke wrote: > Am Dienstag, den 08.12.2009, 10:53 -0800 schrieb Igor Nekrestyanov: >> As Dmitri mentioned you need to move policy file too. Otherwise test >> will not work in new location when run with jtreg. > > So I finally found some time to get back at this. I added the policy > file too: > > http://cr.openjdk.java.net/~rkennke/6888734/webrev.03/ > > Is this ok now to push? > > Thanks, Roman > > >> Rest looks good to me. >> >> -igor >> >> On 12/7/09 12:12 PM, Roman Kennke wrote: >>> Hi Phil, >>> >>> Am Montag, den 30.11.2009, 13:37 -0800 schrieb Phil Race: >>> >>>> Roman Kennke wrote: >>>> >>>>> I added the (previously closed) testcase, keeping it in the same >>>>> relative directory location: >>>>> >>>>> http://cr.openjdk.java.net/~rkennke/6888734/webrev.01/ >>>>> >>>>> Is this ok? >>>>> >>>>> >>>> Almost. Reg tests don't have the classpath exception. >>>> >>> Fixed. >>> >>> >>>> And probably the copyright year should be a range, starting >>>> with whatever the existing year is. >>>> >>> This file is added to the closed repository in 2007, with the initial >>> commit, it doesn't say anything how old this file is. I put it in >>> OpenJDK in 2009, this is why I say so in the header. What else can I do? >>> >>> Also, we need one more review, Igor, can you have a look? >>> >>> http://cr.openjdk.java.net/~rkennke/6888734/webrev.02/ >>> >>> Thanks, Roman >>> >>> >>> >>> > > From Roman.Kennke at Sun.COM Mon Feb 1 20:16:59 2010 From: Roman.Kennke at Sun.COM (Roman Kennke) Date: Mon, 01 Feb 2010 21:16:59 +0100 Subject: [OpenJDK 2D-Dev] [PATCH] Request for review: 6888734, regression test fails when java.security.manager is enabled In-Reply-To: <4B673473.7000002@Sun.COM> References: <1255612943.10319.3.camel@moonlight> <1259591298.7241.446.camel@moonlight> <4B141ABB.9090209@sun.com> <1259613172.7241.1640.camel@moonlight> <4B143B08.8090109@sun.com> <1260216773.8439.7.camel@moonlight> <4B1EA093.1040402@sun.com> <1265054536.2698.10.camel@moonlight> <4B673473.7000002@Sun.COM> Message-ID: <1265055419.2698.11.camel@moonlight> > Looks ok to me except the copyright on the test should probably be 2010 now =) Arg! I knew it! http://cr.openjdk.java.net/~rkennke/6888734/webrev.04/ Now don't tell me I have to put 'Oracle' in there! ;-) /Roman > > Dmitri > > Roman Kennke wrote: > > Am Dienstag, den 08.12.2009, 10:53 -0800 schrieb Igor Nekrestyanov: > >> As Dmitri mentioned you need to move policy file too. Otherwise test > >> will not work in new location when run with jtreg. > > > > So I finally found some time to get back at this. I added the policy > > file too: > > > > http://cr.openjdk.java.net/~rkennke/6888734/webrev.03/ > > > > Is this ok now to push? > > > > Thanks, Roman > > > > > >> Rest looks good to me. > >> > >> -igor > >> > >> On 12/7/09 12:12 PM, Roman Kennke wrote: > >>> Hi Phil, > >>> > >>> Am Montag, den 30.11.2009, 13:37 -0800 schrieb Phil Race: > >>> > >>>> Roman Kennke wrote: > >>>> > >>>>> I added the (previously closed) testcase, keeping it in the same > >>>>> relative directory location: > >>>>> > >>>>> http://cr.openjdk.java.net/~rkennke/6888734/webrev.01/ > >>>>> > >>>>> Is this ok? > >>>>> > >>>>> > >>>> Almost. Reg tests don't have the classpath exception. > >>>> > >>> Fixed. > >>> > >>> > >>>> And probably the copyright year should be a range, starting > >>>> with whatever the existing year is. > >>>> > >>> This file is added to the closed repository in 2007, with the initial > >>> commit, it doesn't say anything how old this file is. I put it in > >>> OpenJDK in 2009, this is why I say so in the header. What else can I do? > >>> > >>> Also, we need one more review, Igor, can you have a look? > >>> > >>> http://cr.openjdk.java.net/~rkennke/6888734/webrev.02/ > >>> > >>> Thanks, Roman > >>> > >>> > >>> > >>> > > > > From Igor.Nekrestyanov at Sun.COM Mon Feb 1 21:16:22 2010 From: Igor.Nekrestyanov at Sun.COM (Igor Nekrestyanov) Date: Mon, 01 Feb 2010 13:16:22 -0800 Subject: [OpenJDK 2D-Dev] [PATCH] Request for review: 6888734, regression test fails when java.security.manager is enabled In-Reply-To: <1265055419.2698.11.camel@moonlight> References: <1255612943.10319.3.camel@moonlight> <1259591298.7241.446.camel@moonlight> <4B141ABB.9090209@sun.com> <1259613172.7241.1640.camel@moonlight> <4B143B08.8090109@sun.com> <1260216773.8439.7.camel@moonlight> <4B1EA093.1040402@sun.com> <1265054536.2698.10.camel@moonlight> <4B673473.7000002@Sun.COM> <1265055419.2698.11.camel@moonlight> Message-ID: <4B6744A6.5000400@sun.com> ok with me. -igor On 2/1/10 12:16 PM, Roman Kennke wrote: >> Looks ok to me except the copyright on the test should probably be 2010 now =) >> > Arg! I knew it! > > http://cr.openjdk.java.net/~rkennke/6888734/webrev.04/ > > Now don't tell me I have to put 'Oracle' in there! ;-) > > /Roman > > >> Dmitri >> >> Roman Kennke wrote: >> >>> Am Dienstag, den 08.12.2009, 10:53 -0800 schrieb Igor Nekrestyanov: >>> >>>> As Dmitri mentioned you need to move policy file too. Otherwise test >>>> will not work in new location when run with jtreg. >>>> >>> So I finally found some time to get back at this. I added the policy >>> file too: >>> >>> http://cr.openjdk.java.net/~rkennke/6888734/webrev.03/ >>> >>> Is this ok now to push? >>> >>> Thanks, Roman >>> >>> >>> >>>> Rest looks good to me. >>>> >>>> -igor >>>> >>>> On 12/7/09 12:12 PM, Roman Kennke wrote: >>>> >>>>> Hi Phil, >>>>> >>>>> Am Montag, den 30.11.2009, 13:37 -0800 schrieb Phil Race: >>>>> >>>>> >>>>>> Roman Kennke wrote: >>>>>> >>>>>> >>>>>>> I added the (previously closed) testcase, keeping it in the same >>>>>>> relative directory location: >>>>>>> >>>>>>> http://cr.openjdk.java.net/~rkennke/6888734/webrev.01/ >>>>>>> >>>>>>> Is this ok? >>>>>>> >>>>>>> >>>>>>> >>>>>> Almost. Reg tests don't have the classpath exception. >>>>>> >>>>>> >>>>> Fixed. >>>>> >>>>> >>>>> >>>>>> And probably the copyright year should be a range, starting >>>>>> with whatever the existing year is. >>>>>> >>>>>> >>>>> This file is added to the closed repository in 2007, with the initial >>>>> commit, it doesn't say anything how old this file is. I put it in >>>>> OpenJDK in 2009, this is why I say so in the header. What else can I do? >>>>> >>>>> Also, we need one more review, Igor, can you have a look? >>>>> >>>>> http://cr.openjdk.java.net/~rkennke/6888734/webrev.02/ >>>>> >>>>> Thanks, Roman >>>>> >>>>> >>>>> >>>>> >>>>> >>> >>> > > From Dmitri.Trembovetski at Sun.COM Mon Feb 1 21:39:48 2010 From: Dmitri.Trembovetski at Sun.COM (Dmitri Trembovetski) Date: Mon, 01 Feb 2010 13:39:48 -0800 Subject: [OpenJDK 2D-Dev] [PATCH] Request for review: 6888734, regression test fails when java.security.manager is enabled In-Reply-To: <1265055419.2698.11.camel@moonlight> References: <1255612943.10319.3.camel@moonlight> <1259591298.7241.446.camel@moonlight> <4B141ABB.9090209@sun.com> <1259613172.7241.1640.camel@moonlight> <4B143B08.8090109@sun.com> <1260216773.8439.7.camel@moonlight> <4B1EA093.1040402@sun.com> <1265054536.2698.10.camel@moonlight> <4B673473.7000002@Sun.COM> <1265055419.2698.11.camel@moonlight> Message-ID: <4B674A24.4070601@Sun.COM> Roman Kennke wrote: >> Looks ok to me except the copyright on the test should probably be 2010 now =) > > Arg! I knew it! > > http://cr.openjdk.java.net/~rkennke/6888734/webrev.04/ > > Now don't tell me I have to put 'Oracle' in there! ;-) Ship it before we had to go through that exercise.. =) Dmitri > > /Roman > >> Dmitri >> >> Roman Kennke wrote: >>> Am Dienstag, den 08.12.2009, 10:53 -0800 schrieb Igor Nekrestyanov: >>>> As Dmitri mentioned you need to move policy file too. Otherwise test >>>> will not work in new location when run with jtreg. >>> So I finally found some time to get back at this. I added the policy >>> file too: >>> >>> http://cr.openjdk.java.net/~rkennke/6888734/webrev.03/ >>> >>> Is this ok now to push? >>> >>> Thanks, Roman >>> >>> >>>> Rest looks good to me. >>>> >>>> -igor >>>> >>>> On 12/7/09 12:12 PM, Roman Kennke wrote: >>>>> Hi Phil, >>>>> >>>>> Am Montag, den 30.11.2009, 13:37 -0800 schrieb Phil Race: >>>>> >>>>>> Roman Kennke wrote: >>>>>> >>>>>>> I added the (previously closed) testcase, keeping it in the same >>>>>>> relative directory location: >>>>>>> >>>>>>> http://cr.openjdk.java.net/~rkennke/6888734/webrev.01/ >>>>>>> >>>>>>> Is this ok? >>>>>>> >>>>>>> >>>>>> Almost. Reg tests don't have the classpath exception. >>>>>> >>>>> Fixed. >>>>> >>>>> >>>>>> And probably the copyright year should be a range, starting >>>>>> with whatever the existing year is. >>>>>> >>>>> This file is added to the closed repository in 2007, with the initial >>>>> commit, it doesn't say anything how old this file is. I put it in >>>>> OpenJDK in 2009, this is why I say so in the header. What else can I do? >>>>> >>>>> Also, we need one more review, Igor, can you have a look? >>>>> >>>>> http://cr.openjdk.java.net/~rkennke/6888734/webrev.02/ >>>>> >>>>> Thanks, Roman >>>>> >>>>> >>>>> >>>>> >>> > > From roman.kennke at sun.com Tue Feb 2 15:40:37 2010 From: roman.kennke at sun.com (roman.kennke at sun.com) Date: Tue, 02 Feb 2010 15:40:37 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6888734: PIT: regression test fails when java.security.manager is enabled Message-ID: <20100202154113.545BA41B06@hg.openjdk.java.net> Changeset: 7e8c77ae401a Author: rkennke Date: 2010-02-02 16:38 +0100 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/7e8c77ae401a 6888734: PIT: regression test fails when java.security.manager is enabled Summary: Load FontManager instance in privileged block to avoid AccessControlException Reviewed-by: igor, tdv ! src/share/classes/sun/font/FontManagerFactory.java + test/java/awt/PrintJob/Security/SecurityDialogTest.java + test/java/awt/PrintJob/Security/policy From Roman.Kennke at Sun.COM Tue Feb 2 21:40:48 2010 From: Roman.Kennke at Sun.COM (Roman Kennke) Date: Tue, 02 Feb 2010 22:40:48 +0100 Subject: [OpenJDK 2D-Dev] [PATCH] Request for review: 6896335: GraphicsEnvironment.getDefaultScreenDevice() throws UnsatisfiedLinkError in headless mode In-Reply-To: <4B14236F.2040101@sun.com> References: <1259610731.7241.1637.camel@moonlight> <4B14236F.2040101@sun.com> Message-ID: <1265146848.8347.6.camel@moonlight> Here's the updated fix with testcase (I took the testcase from the bugreport and transformed it into a proper jtreg test). http://cr.openjdk.java.net/~rkennke/6896335/webrev.01/ Is this ok to put back? We also need another reviewer, Igor, Dmitri? /Roman Am Montag, den 30.11.2009, 11:56 -0800 schrieb Phil Race: > sorry to sound like a broken record, fix looks fine, > regression test needed. In this case I don't think we > have one .. I suppose in this and the last case too it > could be that adding noreg-jck might be sufficient but > a regression test would be better for various reasons. > > -phil. > > Roman Kennke wrote: > > This is a relatively simple fix for 6896335. When I did the change to > > GraphicsEnvironment initialization, I missed this small line that's only > > executed in headless mode, leading to weird exceptions... > > > > http://cr.openjdk.java.net/~rkennke/6896335/webrev.00/ > > > > Ok to commit? > > > > /Roman > > > > From Igor.Nekrestyanov at Sun.COM Tue Feb 2 21:52:05 2010 From: Igor.Nekrestyanov at Sun.COM (Igor Nekrestyanov) Date: Tue, 02 Feb 2010 13:52:05 -0800 Subject: [OpenJDK 2D-Dev] [PATCH] Request for review: 6896335: GraphicsEnvironment.getDefaultScreenDevice() throws UnsatisfiedLinkError in headless mode In-Reply-To: <1265146848.8347.6.camel@moonlight> References: <1259610731.7241.1637.camel@moonlight> <4B14236F.2040101@sun.com> <1265146848.8347.6.camel@moonlight> Message-ID: <4B689E85.6060805@sun.com> ok with me. -igor On 2/2/10 1:40 PM, Roman Kennke wrote: > Here's the updated fix with testcase (I took the testcase from the > bugreport and transformed it into a proper jtreg test). > > http://cr.openjdk.java.net/~rkennke/6896335/webrev.01/ > > Is this ok to put back? > > We also need another reviewer, Igor, Dmitri? > > /Roman > > Am Montag, den 30.11.2009, 11:56 -0800 schrieb Phil Race: > >> sorry to sound like a broken record, fix looks fine, >> regression test needed. In this case I don't think we >> have one .. I suppose in this and the last case too it >> could be that adding noreg-jck might be sufficient but >> a regression test would be better for various reasons. >> >> -phil. >> >> Roman Kennke wrote: >> >>> This is a relatively simple fix for 6896335. When I did the change to >>> GraphicsEnvironment initialization, I missed this small line that's only >>> executed in headless mode, leading to weird exceptions... >>> >>> http://cr.openjdk.java.net/~rkennke/6896335/webrev.00/ >>> >>> Ok to commit? >>> >>> /Roman >>> >>> >>> > > From Phil.Race at Sun.COM Tue Feb 2 22:12:25 2010 From: Phil.Race at Sun.COM (Phil Race) Date: Tue, 02 Feb 2010 14:12:25 -0800 Subject: [OpenJDK 2D-Dev] [PATCH] Request for review: 6896335: GraphicsEnvironment.getDefaultScreenDevice() throws UnsatisfiedLinkError in headless mode In-Reply-To: <1265146848.8347.6.camel@moonlight> References: <1259610731.7241.1637.camel@moonlight> <4B14236F.2040101@sun.com> <1265146848.8347.6.camel@moonlight> Message-ID: <4B68A349.5010609@sun.com> looks fine. -phil. On 2/2/2010 1:40 PM, Roman Kennke wrote: > Here's the updated fix with testcase (I took the testcase from the > bugreport and transformed it into a proper jtreg test). > > http://cr.openjdk.java.net/~rkennke/6896335/webrev.01/ > > Is this ok to put back? > > We also need another reviewer, Igor, Dmitri? > > /Roman > > Am Montag, den 30.11.2009, 11:56 -0800 schrieb Phil Race: >> sorry to sound like a broken record, fix looks fine, >> regression test needed. In this case I don't think we >> have one .. I suppose in this and the last case too it >> could be that adding noreg-jck might be sufficient but >> a regression test would be better for various reasons. >> >> -phil. >> >> Roman Kennke wrote: >>> This is a relatively simple fix for 6896335. When I did the change to >>> GraphicsEnvironment initialization, I missed this small line that's only >>> executed in headless mode, leading to weird exceptions... >>> >>> http://cr.openjdk.java.net/~rkennke/6896335/webrev.00/ >>> >>> Ok to commit? >>> >>> /Roman >>> >>> > > From roman.kennke at sun.com Wed Feb 3 09:02:51 2010 From: roman.kennke at sun.com (roman.kennke at sun.com) Date: Wed, 03 Feb 2010 09:02:51 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6896335: GraphicsEnvironment.getDefaultScreenDevice() throws UnsatisfiedLinkError in headless mode Message-ID: <20100203090310.5ED7C41C0B@hg.openjdk.java.net> Changeset: cedd0cdd5b9a Author: rkennke Date: 2010-02-03 10:02 +0100 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/cedd0cdd5b9a 6896335: GraphicsEnvironment.getDefaultScreenDevice() throws UnsatisfiedLinkError in headless mode Summary: Use local ge variable instead of localEnv field in GE. Reviewed-by: igor, prr ! src/share/classes/java/awt/GraphicsEnvironment.java + test/java/awt/GraphicsEnvironment/TestGetDefScreenDevice.java From Roman.Kennke at Sun.COM Wed Feb 3 19:35:57 2010 From: Roman.Kennke at Sun.COM (Roman Kennke) Date: Wed, 03 Feb 2010 20:35:57 +0100 Subject: [OpenJDK 2D-Dev] [PATCH] Request for review: 6904882: java.awt.Font.createFont() causes AccessControlException if executed with "-Djava.security.manager" In-Reply-To: <4B1421C7.1050204@sun.com> References: <1259608703.7241.1631.camel@moonlight> <4B1421C7.1050204@sun.com> Message-ID: <1265225757.4466.21.camel@moonlight> I moved the FontPrivilege test into open. I did one small change to it, instead of calling setSecurityManager() in the beginning of the test, I added the tag /security=java.lang.SecurityManager which should have about the same effect. http://cr.openjdk.java.net/~rkennke/6904882/webrev.02/ Is this ok to push? Also needs one more review, Igor, Dmitri, anyone else left in 2d? /Roman Am Montag, den 30.11.2009, 11:49 -0800 schrieb Phil Race: > Like the last one, this could use a regression test - even though > there's a JCK failure. FWIW a trivial one like this :- > > import java.awt.*; > import java.io.File; > > public class CreateFontSMTest { > public static void main(String[] args) throws Exception { > System.setSecurityManager(new SecurityManager()); > Font font = new Font("Dialog", Font.PLAIN, 12); > System.out.println(font.getFontName()); > } > } > > will work, but I also found we already have a test .. which I > guess never got run :-(, called FontPrivilege.java that does > something very similar. Its also in closed and I leave it > up to you whether to open that or add a new one but opening > it would be best. > > -phil. > > > > Roman Kennke wrote: > > This patches fixes bug #6904882. As suggested by Phil it puts the whole > > static initializer in a privileged block, grouping the existing 4 > > smaller blocks into one, and importantly including the offending > > File.exists() call. This requires to make the static fields non-final. > > > > http://cr.openjdk.java.net/~rkennke/6904882/webrev.00/ > > > > Ok to commit? > > > > /Roman > > > > From Phil.Race at Sun.COM Wed Feb 3 19:55:38 2010 From: Phil.Race at Sun.COM (Phil Race) Date: Wed, 03 Feb 2010 11:55:38 -0800 Subject: [OpenJDK 2D-Dev] [PATCH] Request for review: 6904882: java.awt.Font.createFont() causes AccessControlException if executed with "-Djava.security.manager" In-Reply-To: <1265225757.4466.21.camel@moonlight> References: <1259608703.7241.1631.camel@moonlight> <4B1421C7.1050204@sun.com> <1265225757.4466.21.camel@moonlight> Message-ID: <4B69D4BA.3030705@sun.com> looks fine. -phil On 2/3/2010 11:35 AM, Roman Kennke wrote: > I moved the FontPrivilege test into open. I did one small change to it, > instead of calling setSecurityManager() in the beginning of the test, I > added the tag /security=java.lang.SecurityManager which should have > about the same effect. > > http://cr.openjdk.java.net/~rkennke/6904882/webrev.02/ > > Is this ok to push? > > Also needs one more review, Igor, Dmitri, anyone else left in 2d? > > /Roman > > Am Montag, den 30.11.2009, 11:49 -0800 schrieb Phil Race: >> Like the last one, this could use a regression test - even though >> there's a JCK failure. FWIW a trivial one like this :- >> >> import java.awt.*; >> import java.io.File; >> >> public class CreateFontSMTest { >> public static void main(String[] args) throws Exception { >> System.setSecurityManager(new SecurityManager()); >> Font font = new Font("Dialog", Font.PLAIN, 12); >> System.out.println(font.getFontName()); >> } >> } >> >> will work, but I also found we already have a test .. which I >> guess never got run :-(, called FontPrivilege.java that does >> something very similar. Its also in closed and I leave it >> up to you whether to open that or add a new one but opening >> it would be best. >> >> -phil. >> >> >> >> Roman Kennke wrote: >>> This patches fixes bug #6904882. As suggested by Phil it puts the whole >>> static initializer in a privileged block, grouping the existing 4 >>> smaller blocks into one, and importantly including the offending >>> File.exists() call. This requires to make the static fields non-final. >>> >>> http://cr.openjdk.java.net/~rkennke/6904882/webrev.00/ >>> >>> Ok to commit? >>> >>> /Roman >>> >>> > > From Roman.Kennke at Sun.COM Fri Feb 5 22:34:06 2010 From: Roman.Kennke at Sun.COM (Roman Kennke) Date: Fri, 05 Feb 2010 23:34:06 +0100 Subject: [OpenJDK 2D-Dev] [PATCH] Request for review: 6904882: java.awt.Font.createFont() causes AccessControlException if executed with "-Djava.security.manager" In-Reply-To: <4B69D4BA.3030705@sun.com> References: <1259608703.7241.1631.camel@moonlight> <4B1421C7.1050204@sun.com> <1265225757.4466.21.camel@moonlight> <4B69D4BA.3030705@sun.com> Message-ID: <1265409246.2645.56.camel@moonlight> Am Mittwoch, den 03.02.2010, 11:55 -0800 schrieb Phil Race: > looks fine. Good! Needs another reviewer? Igor maybe, or Dmitri? Thanks, Roman > > -phil > > On 2/3/2010 11:35 AM, Roman Kennke wrote: > > I moved the FontPrivilege test into open. I did one small change to it, > > instead of calling setSecurityManager() in the beginning of the test, I > > added the tag /security=java.lang.SecurityManager which should have > > about the same effect. > > > > http://cr.openjdk.java.net/~rkennke/6904882/webrev.02/ > > > > Is this ok to push? > > > > Also needs one more review, Igor, Dmitri, anyone else left in 2d? > > > > /Roman > > > > Am Montag, den 30.11.2009, 11:49 -0800 schrieb Phil Race: > >> Like the last one, this could use a regression test - even though > >> there's a JCK failure. FWIW a trivial one like this :- > >> > >> import java.awt.*; > >> import java.io.File; > >> > >> public class CreateFontSMTest { > >> public static void main(String[] args) throws Exception { > >> System.setSecurityManager(new SecurityManager()); > >> Font font = new Font("Dialog", Font.PLAIN, 12); > >> System.out.println(font.getFontName()); > >> } > >> } > >> > >> will work, but I also found we already have a test .. which I > >> guess never got run :-(, called FontPrivilege.java that does > >> something very similar. Its also in closed and I leave it > >> up to you whether to open that or add a new one but opening > >> it would be best. > >> > >> -phil. > >> > >> > >> > >> Roman Kennke wrote: > >>> This patches fixes bug #6904882. As suggested by Phil it puts the whole > >>> static initializer in a privileged block, grouping the existing 4 > >>> smaller blocks into one, and importantly including the offending > >>> File.exists() call. This requires to make the static fields non-final. > >>> > >>> http://cr.openjdk.java.net/~rkennke/6904882/webrev.00/ > >>> > >>> Ok to commit? > >>> > >>> /Roman > >>> > >>> > > > > From Igor.Nekrestyanov at Sun.COM Fri Feb 5 22:42:28 2010 From: Igor.Nekrestyanov at Sun.COM (Igor Nekrestyanov) Date: Fri, 05 Feb 2010 14:42:28 -0800 Subject: [OpenJDK 2D-Dev] [PATCH] Request for review: 6904882: java.awt.Font.createFont() causes AccessControlException if executed with "-Djava.security.manager" In-Reply-To: <1265409246.2645.56.camel@moonlight> References: <1259608703.7241.1631.camel@moonlight> <4B1421C7.1050204@sun.com> <1265225757.4466.21.camel@moonlight> <4B69D4BA.3030705@sun.com> <1265409246.2645.56.camel@moonlight> Message-ID: <4B6C9ED4.7070004@sun.com> Sorry for delay, i thought this one was reviewed. ok with me. -igor On 2/5/10 2:34 PM, Roman Kennke wrote: > Am Mittwoch, den 03.02.2010, 11:55 -0800 schrieb Phil Race: > >> looks fine. >> > Good! Needs another reviewer? Igor maybe, or Dmitri? > > Thanks, Roman > > > >> -phil >> >> On 2/3/2010 11:35 AM, Roman Kennke wrote: >> >>> I moved the FontPrivilege test into open. I did one small change to it, >>> instead of calling setSecurityManager() in the beginning of the test, I >>> added the tag /security=java.lang.SecurityManager which should have >>> about the same effect. >>> >>> http://cr.openjdk.java.net/~rkennke/6904882/webrev.02/ >>> >>> Is this ok to push? >>> >>> Also needs one more review, Igor, Dmitri, anyone else left in 2d? >>> >>> /Roman >>> >>> Am Montag, den 30.11.2009, 11:49 -0800 schrieb Phil Race: >>> >>>> Like the last one, this could use a regression test - even though >>>> there's a JCK failure. FWIW a trivial one like this :- >>>> >>>> import java.awt.*; >>>> import java.io.File; >>>> >>>> public class CreateFontSMTest { >>>> public static void main(String[] args) throws Exception { >>>> System.setSecurityManager(new SecurityManager()); >>>> Font font = new Font("Dialog", Font.PLAIN, 12); >>>> System.out.println(font.getFontName()); >>>> } >>>> } >>>> >>>> will work, but I also found we already have a test .. which I >>>> guess never got run :-(, called FontPrivilege.java that does >>>> something very similar. Its also in closed and I leave it >>>> up to you whether to open that or add a new one but opening >>>> it would be best. >>>> >>>> -phil. >>>> >>>> >>>> >>>> Roman Kennke wrote: >>>> >>>>> This patches fixes bug #6904882. As suggested by Phil it puts the whole >>>>> static initializer in a privileged block, grouping the existing 4 >>>>> smaller blocks into one, and importantly including the offending >>>>> File.exists() call. This requires to make the static fields non-final. >>>>> >>>>> http://cr.openjdk.java.net/~rkennke/6904882/webrev.00/ >>>>> >>>>> Ok to commit? >>>>> >>>>> /Roman >>>>> >>>>> >>>>> >>> >>> > > From roman.kennke at sun.com Sun Feb 7 10:08:35 2010 From: roman.kennke at sun.com (roman.kennke at sun.com) Date: Sun, 07 Feb 2010 10:08:35 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 6904882: java.awt.Font.createFont() causes AccessControlException if executed with "-Djava.security.manager" Message-ID: <20100207100925.5FD7A4155A@hg.openjdk.java.net> Changeset: 58d014485a29 Author: rkennke Date: 2010-02-07 11:07 +0100 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/58d014485a29 6904882: java.awt.Font.createFont() causes AccessControlException if executed with "-Djava.security.manager" Summary: Perform FontUtilities initialization in privileged block Reviewed-by: igor, prr ! src/share/classes/sun/font/FontUtilities.java + test/java/awt/FontClass/FontPrivilege.java From Phil.Race at Sun.COM Mon Feb 8 17:43:55 2010 From: Phil.Race at Sun.COM (Phil Race) Date: Mon, 08 Feb 2010 09:43:55 -0800 Subject: [OpenJDK 2D-Dev] Fwd: [Lcms-user] [ANNOUNCE] LittleCMS 2.0 goes beta Message-ID: <4B704D5B.90505@sun.com> We should try plugging this into OpenJDK 7 to test it out before it goes final. -phil. -------- Original Message -------- Subject: [Lcms-user] [ANNOUNCE] LittleCMS 2.0 goes beta Date: Sat, 06 Feb 2010 10:23:12 +0100 From: marti.maria at littlecms.com To: lcms-user at lists.sourceforge.net Dear Little CMS community: After years of development, lcms 2.0 is now completed and ready to be beta tested. This means the tarball does contain all code and documentation that will be in the final lcms 2.0 release. But of course, since there are significant changes in the code, and despite it has been carefully tested, bugs may arise. So, now your feedback is important. If you find bugs, glitches, inconsistencies, etc: Please let me know. For the 2.x series I will try to maintain a list of contributors and give credits to helpful people. Unfortunately that's all I can do in this non-profit project! Here is the beta 1 tarball: http://www.littlecms.com/lcms2-2.0beta1.tar.gz I have been forced to drop some features to meet schedule, for example Delphi, python and Mat Lab wrappers. Hopefully, these will be recovered in 2.1 Another missing feature is pthreads. lcms 2.0 does support multi threading but I would like to better this part a little bit. Remaining features are working. lcms 2 can coexist with lcms 1 without problems. The utilities have been renamed to avoid clashes and the whole package name has been changed to lcms2 (hence the tarball name) There will be 3 or 4 beta releases on depending on the severity of issues found. My initial intention is to release betas monthly. I would like to thank you again for all your support. Without it, lcms 2.0 would have never been possible! Best regards Marti Maria The LittleCMS Project http://www.littlecms.com ------------------------------------------------------------------------------ The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com _______________________________________________ Lcms-user mailing list Lcms-user at lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lcms-user From lana.steuck at sun.com Sat Feb 20 05:51:48 2010 From: lana.steuck at sun.com (lana.steuck at sun.com) Date: Sat, 20 Feb 2010 05:51:48 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d: 3 new changesets Message-ID: <20100220055149.059A742917@hg.openjdk.java.net> Changeset: 6880a3af9add Author: mikejwre Date: 2010-02-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/rev/6880a3af9add Added tag jdk7-b82 for changeset e1176f86805f ! .hgtags Changeset: 2f3ea057d1ad Author: mikejwre Date: 2010-02-12 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/rev/2f3ea057d1ad Added tag jdk7-b83 for changeset 6880a3af9add ! .hgtags Changeset: cf26288a114b Author: mikejwre Date: 2010-02-18 13:31 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/rev/cf26288a114b Added tag jdk7-b84 for changeset 2f3ea057d1ad ! .hgtags From lana.steuck at sun.com Sat Feb 20 05:51:58 2010 From: lana.steuck at sun.com (lana.steuck at sun.com) Date: Sat, 20 Feb 2010 05:51:58 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/corba: 3 new changesets Message-ID: <20100220055204.44BB042918@hg.openjdk.java.net> Changeset: fde0df7a2384 Author: mikejwre Date: 2010-02-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/corba/rev/fde0df7a2384 Added tag jdk7-b82 for changeset 1e8c1bfad1ab ! .hgtags Changeset: 68c8961a82e4 Author: mikejwre Date: 2010-02-12 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/corba/rev/68c8961a82e4 Added tag jdk7-b83 for changeset fde0df7a2384 ! .hgtags Changeset: c67a9df7bc0c Author: mikejwre Date: 2010-02-18 13:31 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/corba/rev/c67a9df7bc0c Added tag jdk7-b84 for changeset 68c8961a82e4 ! .hgtags From lana.steuck at sun.com Sat Feb 20 05:54:53 2010 From: lana.steuck at sun.com (lana.steuck at sun.com) Date: Sat, 20 Feb 2010 05:54:53 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/hotspot: 61 new changesets Message-ID: <20100220055806.C89BA4291A@hg.openjdk.java.net> Changeset: 26ecc6fa29e6 Author: mikejwre Date: 2010-02-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/26ecc6fa29e6 Added tag jdk7-b82 for changeset 1999f5b12482 ! .hgtags Changeset: 7fbf850d87b7 Author: dcubed Date: 2010-01-13 09:39 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/7fbf850d87b7 6580131: 3/4 CompiledMethodLoad events don't produce the expected extra notifications to describe inlining Summary: Add support for additional implementation specific info to the JVM/TI CompiledMethodLoad event via the compile_info parameter. Reviewed-by: never, ohair, tbell, tdeneau Contributed-by: Vasanth Venkatachalam ! make/Makefile ! make/defs.make + src/share/vm/code/jvmticmlr.h ! src/share/vm/includeDB_core ! src/share/vm/prims/jvmtiExport.cpp Changeset: 3908ad124838 Author: dcubed Date: 2010-01-20 11:32 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/3908ad124838 Merge ! make/Makefile ! make/defs.make ! src/share/vm/includeDB_core ! src/share/vm/prims/jvmtiExport.cpp Changeset: 2718ec34c699 Author: coleenp Date: 2010-01-22 15:06 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/2718ec34c699 Merge - src/share/vm/gc_implementation/g1/ptrQueue.inline.hpp Changeset: cf0685d550f1 Author: never Date: 2010-01-20 22:10 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/cf0685d550f1 6911204: generated adapters with large signatures can fill up the code cache Reviewed-by: kvn, jrose ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/share/vm/includeDB_core ! src/share/vm/oops/methodOop.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp Changeset: 99af867dfa05 Author: kvn Date: 2010-01-26 08:53 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/99af867dfa05 6919886: Sweep CodeCache more aggressively to reduce its usage for CompileTheWorld Summary: Add safepoint after CompileTheWorldSafepointInterval (100) compilations and do full sweep of CodeCache each time. Reviewed-by: never Contributed-by: eric.caspole at amd.com ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 89ca5ab4fa60 Author: iveresov Date: 2010-01-27 14:06 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/89ca5ab4fa60 Merge ! src/share/vm/includeDB_core Changeset: 4788266644c1 Author: jmasa Date: 2010-01-21 11:33 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/4788266644c1 6895236: CMS: cmsOopClosures.inline.hpp:43 assert(..., "Should remember klasses in this context") Summary: Adjust assertion checking for ExplicitGCInvokesConcurrentAndUnloadsClasses as a reason for class unloading Reviewed-by: ysr ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/memory/iterator.hpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/referenceProcessor.hpp Changeset: fed17682aea5 Author: ysr Date: 2010-01-21 14:47 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/fed17682aea5 Merge Changeset: 776fb94f33cc Author: apetrusenko Date: 2010-01-21 18:51 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/776fb94f33cc 6918006: G1: spill space must be reserved on the stack for barrier calls on Windows x64 Summary: Stub code generated to call G1 barriers does not allocate spill space on the stack as required by Windows x64 ABI. The fix is to use more ABI-friendly call_VM_leaf(). Reviewed-by: iveresov, never, kvn ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: c81fa70144aa Author: tonyp Date: 2010-01-25 18:03 -0500 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/c81fa70144aa 6919980: G1: remove +UseG1GC from under experimental options (second attempt) Summary: Trying this again, as the original change was lost. Reviewed-by: ysr, jmasa ! src/share/vm/runtime/globals.hpp Changeset: 34fb2662f6c2 Author: ysr Date: 2010-01-26 16:52 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/34fb2662f6c2 6920090: G1: Disable ReduceInitialCardMarks at least until 6920109 is fixed Summary: G1 now answers "no" to the query can_elide_initializing_store_barrier() in the product build. A debug flag allows alternate behaviour in debug builds. Reviewed-by: iveresov, tonyp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp ! src/share/vm/gc_interface/collectedHeap.cpp Changeset: 291c9b3b64fc Author: ysr Date: 2010-01-26 23:36 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/291c9b3b64fc Merge Changeset: f3345b7b01b4 Author: ysr Date: 2010-01-27 22:38 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/f3345b7b01b4 Merge ! src/share/vm/runtime/globals.hpp Changeset: 9e1637a04678 Author: twisti Date: 2010-01-28 08:36 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/9e1637a04678 6920970: Zero build fixes after 6849984 and 6911204 Summary: Two recent commits broke the build on Zero. Reviewed-by: twisti Contributed-by: Gary Benson ! src/cpu/zero/vm/interpreter_zero.cpp ! src/cpu/zero/vm/sharedRuntime_zero.cpp Changeset: 8d9bfe6a446b Author: never Date: 2010-01-28 16:28 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/8d9bfe6a446b 6920346: G1: "must avoid base_memory and AliasIdxTop" Reviewed-by: kvn ! src/share/vm/opto/memnode.hpp Changeset: 0e14bd797dad Author: never Date: 2010-01-28 20:41 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/0e14bd797dad 6792161: assert("No dead instructions after post-alloc") Reviewed-by: kvn ! src/share/vm/opto/ifg.cpp + test/compiler/6792161/Test6792161.java Changeset: ba263cfb7611 Author: twisti Date: 2010-01-29 12:13 +0100 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/ba263cfb7611 6917766: JSR 292 needs its own deopt handler Summary: We need to introduce a new MH deopt handler so we can easily determine if the deopt happened at a MH call site or not. Reviewed-by: never, jrose ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 24128c2ffa87 Author: twisti Date: 2010-01-29 08:33 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/24128c2ffa87 6921339: backout 6917766 Reviewed-by: mr ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 5f24d0319e54 Author: kvn Date: 2010-01-29 09:27 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/5f24d0319e54 4360113: Evict nmethods when code cache gets full Summary: Speculatively unload the oldest nmethods when code cache gets full. Reviewed-by: never, kvn Contributed-by: eric.caspole at amd.com ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/compiler/compileBroker.hpp ! src/share/vm/includeDB_compiler2 ! src/share/vm/includeDB_core ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/sweeper.hpp ! src/share/vm/runtime/vm_operations.cpp ! src/share/vm/runtime/vm_operations.hpp Changeset: 844a9d73ec22 Author: never Date: 2010-01-29 22:51 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/844a9d73ec22 6916644: C2 compiler crash on x86 Reviewed-by: kvn, twisti ! src/share/vm/adlc/output_c.cpp ! src/share/vm/adlc/output_h.cpp ! src/share/vm/opto/machnode.hpp ! src/share/vm/opto/matcher.cpp + test/compiler/6916644/Test6916644.java Changeset: 18a389214829 Author: twisti Date: 2010-02-01 19:29 +0100 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/18a389214829 6921352: JSR 292 needs its own deopt handler Summary: We need to introduce a new MH deopt handler so we can easily determine if the deopt happened at a MH call site or not. Reviewed-by: never, jrose ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/frame_x86.cpp ! src/cpu/x86/vm/frame_x86.hpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/share/vm/asm/codeBuffer.hpp ! src/share/vm/c1/c1_Compilation.cpp ! src/share/vm/c1/c1_LIRAssembler.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 5fcfaa1ad96f Author: twisti Date: 2010-02-01 23:18 +0100 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/5fcfaa1ad96f 6921799: JSR 292 call sites should not be fixed-up Summary: MethodHandle invoke call sites should not be fixed-up by SharedRuntime::fixup_callers_callsite as c2i/i2c adapters are used to implement MethodHandle actions. Reviewed-by: kvn, never ! src/share/vm/runtime/sharedRuntime.cpp Changeset: 87684f1a88b5 Author: kvn Date: 2010-02-01 16:49 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/87684f1a88b5 6614597: Performance variability in jvm2008 xml.validation Summary: Fix incorrect marking of methods as not compilable. Reviewed-by: never ! src/cpu/sparc/vm/interp_masm_sparc.cpp ! src/cpu/sparc/vm/interp_masm_sparc.hpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_32.hpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/interp_masm_x86_64.hpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/parseHelper.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/deoptimization.hpp ! src/share/vm/runtime/globals.hpp Changeset: 74c848d437ab Author: never Date: 2010-02-03 12:28 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/74c848d437ab 6921922: fix for 6911204 breaks tagged stack interpreter Reviewed-by: kvn ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp Changeset: cef333a48af6 Author: kvn Date: 2010-02-03 15:03 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/cef333a48af6 6923043: failed nightly tests which use -XX:+PrintCompilation -Xcomp -XX:CompileOnly Summary: Print "made not compilable" line only for deoptimizations. Reviewed-by: never ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp Changeset: e8443c7be117 Author: never Date: 2010-02-03 15:56 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/e8443c7be117 6921969: optimize 64 long multiply for case with high bits zero Reviewed-by: never, twisti, kvn, rasbold Contributed-by: Hiroshi Yamauchi ! src/cpu/x86/vm/x86_32.ad + test/compiler/6921969/TestMultiplyLongHiZero.java Changeset: 0fce83e8dc0e Author: never Date: 2010-02-03 18:33 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/0fce83e8dc0e Merge Changeset: c1f1137b3575 Author: twisti Date: 2010-02-04 03:34 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/c1f1137b3575 Merge ! src/share/vm/runtime/globals.hpp Changeset: c028504fdaa6 Author: never Date: 2010-02-04 11:16 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/c028504fdaa6 6921992: failure in verify scheduling after 6792161 Reviewed-by: kvn ! src/share/vm/opto/ifg.cpp Changeset: 6deeaebad47a Author: dcubed Date: 2010-02-01 17:35 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/6deeaebad47a 6902182: 4/4 Starting with jdwp agent should not incur performance penalty Summary: Rename can_post_exceptions support to can_post_on_exceptions. Add support for should_post_on_exceptions flag to permit per JavaThread optimizations. Reviewed-by: never, kvn, dcubed Contributed-by: tom.deneau at amd.com ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/prims/jvmtiEventController.cpp ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/prims/jvmtiManageCapabilities.cpp ! src/share/vm/prims/jvmtiThreadState.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: 0fc941df6fb7 Author: dcubed Date: 2010-02-02 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/0fc941df6fb7 6918421: 1/1 in-process JVM now ignores preset Windows unhandled exception filter Summary: Add support for chaining Windows UnhandledExceptionFilter handlers Reviewed-by: kamg, dholmes, never, acorn, ikrylov ! src/os/windows/vm/os_windows.cpp Changeset: f19bf22685cc Author: dcubed Date: 2010-02-02 11:08 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/f19bf22685cc Merge ! src/os/windows/vm/os_windows.cpp Changeset: 7f8790caccb0 Author: apangin Date: 2010-02-04 15:50 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/7f8790caccb0 Merge ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/runtime/sharedRuntime.cpp Changeset: dba18cabafec Author: trims Date: 2010-02-05 12:26 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/dba18cabafec Merge Changeset: ff3232b68fbb Author: trims Date: 2010-02-05 12:27 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/ff3232b68fbb 6921473: Bump the HS17 build number to 09 Summary: Update the HS17 build number to 09 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 1e3c5d0474d4 Author: trims Date: 2010-02-05 16:21 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/1e3c5d0474d4 Merge Changeset: 39e0a32bc49b Author: trims Date: 2010-02-11 19:52 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/39e0a32bc49b Added tag hs17-b01 for changeset a94714c55065 ! .hgtags Changeset: bd1260aafd87 Author: trims Date: 2010-02-11 19:52 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/bd1260aafd87 Added tag hs17-b02 for changeset faf94d94786b ! .hgtags Changeset: d9c445aa7bb1 Author: trims Date: 2010-02-11 19:52 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/d9c445aa7bb1 Added tag hs17-b03 for changeset f4b900403d6e ! .hgtags Changeset: 3940517a1f13 Author: trims Date: 2010-02-11 19:52 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/3940517a1f13 Added tag hs17-b04 for changeset d8dd291a362a ! .hgtags Changeset: 4458e32d9125 Author: trims Date: 2010-02-11 19:52 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/4458e32d9125 Added tag hs17-b05 for changeset 9174bb32e934 ! .hgtags Changeset: 36a78dac746f Author: trims Date: 2010-02-11 19:52 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/36a78dac746f Added tag hs17-b06 for changeset a5a6adfca6ec ! .hgtags Changeset: bfa6d67a7a29 Author: trims Date: 2010-02-11 19:53 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/bfa6d67a7a29 Added tag hs17-b07 for changeset 3003ddd1d433 ! .hgtags Changeset: 73047d0b13cf Author: trims Date: 2010-02-11 19:53 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/73047d0b13cf Added tag hs17-b08 for changeset 1f9b07674480 ! .hgtags Changeset: 12076a98a540 Author: trims Date: 2010-02-11 19:53 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/12076a98a540 Added tag hs17-b09 for changeset ff3232b68fbb ! .hgtags Changeset: 704a172a0918 Author: trims Date: 2010-02-11 20:11 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/704a172a0918 Added tag hs16-b01 for changeset 981375ca07b7 ! .hgtags Changeset: e114a6374471 Author: trims Date: 2010-02-11 20:11 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/e114a6374471 Added tag hs16-b02 for changeset f4cbf78110c7 ! .hgtags Changeset: 3469eafe9bf4 Author: trims Date: 2010-02-11 20:11 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/3469eafe9bf4 Added tag hs16-b03 for changeset 07c1c01e0315 ! .hgtags Changeset: 26dba59fc9ec Author: trims Date: 2010-02-11 20:11 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/26dba59fc9ec Added tag hs16-b04 for changeset 08f86fa55a31 ! .hgtags Changeset: 8b0989046c93 Author: trims Date: 2010-02-11 20:11 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/8b0989046c93 Added tag hs16-b05 for changeset 32c83fb84370 ! .hgtags Changeset: 5fe06b3f6753 Author: trims Date: 2010-02-11 20:11 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/5fe06b3f6753 Added tag hs16-b06 for changeset ba313800759b ! .hgtags Changeset: 36ae83035b8e Author: trims Date: 2010-02-11 20:11 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/36ae83035b8e Added tag hs16-b07 for changeset 3c0f72981560 ! .hgtags Changeset: 89ef87b378cd Author: trims Date: 2010-02-11 20:11 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/89ef87b378cd Added tag hs16-b08 for changeset ac59d4e6dae5 ! .hgtags Changeset: cd89ef31a9c8 Author: trims Date: 2010-02-11 20:36 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/cd89ef31a9c8 Added tag hs15-b01 for changeset 3f844a28c5f4 ! .hgtags Changeset: 2099657b92a1 Author: trims Date: 2010-02-11 20:36 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/2099657b92a1 Added tag hs15-b02 for changeset 1605bb4eb5a7 ! .hgtags Changeset: 9dcad51c5c70 Author: trims Date: 2010-02-11 20:37 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/9dcad51c5c70 Added tag hs15-b03 for changeset 2581d90c6c9b ! .hgtags Changeset: 07118aaebf50 Author: trims Date: 2010-02-11 20:37 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/07118aaebf50 Added tag hs15-b04 for changeset 9ab385cb0c42 ! .hgtags Changeset: 3f370a32906e Author: trims Date: 2010-02-11 20:37 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/3f370a32906e Added tag hs15-b05 for changeset fafab5d5349c ! .hgtags Changeset: ffc8d176b84b Author: mikejwre Date: 2010-02-12 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/ffc8d176b84b Added tag jdk7-b83 for changeset 3f370a32906e ! .hgtags Changeset: 125eb6a9fccf Author: mikejwre Date: 2010-02-18 13:31 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/hotspot/rev/125eb6a9fccf Added tag jdk7-b84 for changeset ffc8d176b84b ! .hgtags From lana.steuck at sun.com Sat Feb 20 06:07:11 2010 From: lana.steuck at sun.com (lana.steuck at sun.com) Date: Sat, 20 Feb 2010 06:07:11 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jaxp: 6 new changesets Message-ID: <20100220060712.1D9C04291F@hg.openjdk.java.net> Changeset: 309a0a7fc6ce Author: mikejwre Date: 2010-02-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/309a0a7fc6ce Added tag jdk7-b82 for changeset c876ad22e4bf ! .hgtags Changeset: c664aff74b41 Author: mikejwre Date: 2010-02-12 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/c664aff74b41 Added tag jdk7-b83 for changeset 309a0a7fc6ce ! .hgtags Changeset: df2e196a5f01 Author: ohair Date: 2010-02-03 16:44 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/df2e196a5f01 6923146: Upgrade to JAXP 1.4.3 Reviewed-by: darcy ! jaxp.properties Changeset: bf7c7f2825ef Author: lana Date: 2010-02-08 23:58 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/bf7c7f2825ef Merge Changeset: 32c0cf01d555 Author: lana Date: 2010-02-14 23:35 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/32c0cf01d555 Merge Changeset: 6c0ccabb430d Author: mikejwre Date: 2010-02-18 13:31 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxp/rev/6c0ccabb430d Added tag jdk7-b84 for changeset 32c0cf01d555 ! .hgtags From lana.steuck at sun.com Sat Feb 20 06:07:18 2010 From: lana.steuck at sun.com (lana.steuck at sun.com) Date: Sat, 20 Feb 2010 06:07:18 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jaxws: 3 new changesets Message-ID: <20100220060718.BEDBB42920@hg.openjdk.java.net> Changeset: 371e3ded591d Author: mikejwre Date: 2010-02-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxws/rev/371e3ded591d Added tag jdk7-b82 for changeset 31573ae8eed1 ! .hgtags Changeset: 8bc02839eee4 Author: mikejwre Date: 2010-02-12 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxws/rev/8bc02839eee4 Added tag jdk7-b83 for changeset 371e3ded591d ! .hgtags Changeset: 8424512588ff Author: mikejwre Date: 2010-02-18 13:31 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jaxws/rev/8424512588ff Added tag jdk7-b84 for changeset 8bc02839eee4 ! .hgtags From lana.steuck at sun.com Sat Feb 20 06:09:37 2010 From: lana.steuck at sun.com (lana.steuck at sun.com) Date: Sat, 20 Feb 2010 06:09:37 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/jdk: 50 new changesets Message-ID: <20100220062546.71F9342925@hg.openjdk.java.net> Changeset: b250e6c5a9e5 Author: andrew Date: 2010-01-28 21:01 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b250e6c5a9e5 6921068: Remove javadoc builds warnings from specdefault tag Summary: Ignore specdefault tag to avoid javadoc warnings Reviewed-by: darcy, ohair ! make/docs/Makefile Changeset: b3b10d45778a Author: andrew Date: 2010-01-29 02:38 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b3b10d45778a 6917466: Should set bootclasspath for javadoc in jdk build Summary: javadoc needs to reference the newly built classes so as not to hit APIs which differ between the boot JDK and the source files of the JDK being built. Reviewed-by: ohair ! make/common/shared/Defs-java.gmk ! make/javax/swing/beaninfo/SwingBeans.gmk Changeset: 69ef657320ad Author: ohair Date: 2010-01-29 09:05 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/69ef657320ad Merge Changeset: 9027c6b9d7e2 Author: mikejwre Date: 2010-02-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/9027c6b9d7e2 Added tag jdk7-b82 for changeset 69ef657320ad ! .hgtags Changeset: 9b82fa0505bc Author: mikejwre Date: 2010-02-12 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/9b82fa0505bc Added tag jdk7-b83 for changeset 9027c6b9d7e2 ! .hgtags Changeset: dca3a251a001 Author: xuelei Date: 2010-01-20 21:38 +0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/dca3a251a001 6862064: incorrect implementation of PKIXParameters.clone() Reviewed-by: weijun, mullan ! src/share/classes/java/security/cert/PKIXParameters.java Changeset: b19cd193245e Author: dcubed Date: 2010-01-20 12:09 -0700 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b19cd193245e 6580131: 3/4 CompiledMethodLoad events don't produce the expected extra notifications to describe inlining Summary: Add support for additional implementation specific info to the JVM/TI CompiledMethodLoad event via the compile_info parameter. Reviewed-by: never, ohair, tbell, tdeneau Contributed-by: Vasanth Venkatachalam ! make/common/shared/Sanity.gmk ! make/java/jvm/Makefile ! make/mkdemo/jvmti/Makefile ! make/mkdemo/jvmti/README.txt + make/mkdemo/jvmti/compiledMethodLoad/Makefile + src/share/demo/jvmti/compiledMethodLoad/README.txt + src/share/demo/jvmti/compiledMethodLoad/compiledMethodLoad.c + src/share/demo/jvmti/compiledMethodLoad/sample.makefile.txt ! src/share/demo/jvmti/index.html + src/share/javavm/export/jvmticmlr.h + test/demo/jvmti/compiledMethodLoad/CompiledMethodLoadTest.java ! test/demo/jvmti/heapTracker/HeapTrackerTest.java ! test/demo/jvmti/hprof/CpuTimesDefineClassTest.java ! test/demo/jvmti/hprof/CpuTimesTest.java ! test/demo/jvmti/minst/MinstTest.java ! test/demo/jvmti/mtrace/TraceJFrame.java Changeset: 117b245b5bb9 Author: vinnie Date: 2010-01-21 23:59 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/117b245b5bb9 6763530: Cannot decode PublicKey (Proider SunPKCS11, curve prime256v1) Reviewed-by: andrew ! src/share/classes/sun/security/pkcs11/P11ECKeyFactory.java ! src/share/classes/sun/security/pkcs11/P11Key.java Changeset: c94ac5522d01 Author: vinnie Date: 2010-01-22 00:02 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/c94ac5522d01 Merge Changeset: e67bf9abc6a5 Author: chegar Date: 2010-01-25 15:41 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e67bf9abc6a5 6707289: InterfaceAddress.getNetworkPrefixLength() does not conform to Javadoc Reviewed-by: michaelm ! src/windows/native/java/net/NetworkInterface_winXP.c + test/java/net/InterfaceAddress/NetworkPrefixLength.java Changeset: 558f2a424bfa Author: weijun Date: 2010-01-26 17:03 +0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/558f2a424bfa 6919610: KeyTabInputStream uses static field for per-instance value Reviewed-by: mullan ! src/share/classes/sun/security/krb5/internal/ktab/KeyTabInputStream.java + test/sun/security/krb5/ktab/KeyTabIndex.java Changeset: f544825d0976 Author: jccollet Date: 2010-01-26 11:39 +0100 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/f544825d0976 6919185: test/closed/sun/net/ftp/FtpTests fails to compile Summary: Fixed a couple of regressions in FtpClient and updated the test. Reviewed-by: chegar ! src/share/classes/sun/net/ftp/impl/FtpClient.java Changeset: 8df0ffac7f4d Author: chegar Date: 2010-01-27 16:11 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/8df0ffac7f4d 6905552: libnet/nio portability issues Reviewed-by: alanb ! src/share/native/java/net/net_util.c ! src/solaris/native/java/net/Inet4AddressImpl.c ! src/solaris/native/java/net/Inet6AddressImpl.c ! src/solaris/native/java/net/NetworkInterface.c ! src/solaris/native/java/net/PlainDatagramSocketImpl.c ! src/solaris/native/java/net/net_util_md.c ! src/solaris/native/java/net/net_util_md.h ! src/solaris/native/sun/net/spi/SdpProvider.c ! src/solaris/native/sun/nio/ch/Net.c ! src/solaris/native/sun/nio/ch/SctpNet.c Changeset: 4192f6edbbf4 Author: ptisnovs Date: 2010-01-27 17:47 +0100 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/4192f6edbbf4 6920143: test/java/awt/TestArea/UsingWithMouse.java needs realSync() Summary: Added small delay to make sure that TextArea animation have finished Reviewed-by: anthony ! test/java/awt/TextArea/UsingWithMouse/SelectionAutoscrollTest.java Changeset: 0126effcc249 Author: lana Date: 2010-01-27 14:46 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/0126effcc249 Merge Changeset: 946b30073247 Author: sherman Date: 2010-01-27 19:39 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/946b30073247 6920732: opensource test/java/nio/charset Summary: move the test cases to openjdk Reviewed-by: martin + test/java/nio/charset/Charset/AvailableCharsetNames.java + test/java/nio/charset/Charset/CharsetContainmentTest.java + test/java/nio/charset/Charset/Contains.java + test/java/nio/charset/Charset/Default.java + test/java/nio/charset/Charset/EmptyCharsetName.java + test/java/nio/charset/Charset/EncDec.java + test/java/nio/charset/Charset/IllegalCharsetName.java + test/java/nio/charset/Charset/NIOCharsetAvailabilityTest.java + test/java/nio/charset/Charset/NullCharsetName.java + test/java/nio/charset/Charset/RegisteredCharsets.java + test/java/nio/charset/Charset/default.sh + test/java/nio/charset/CharsetDecoder/AverageMax.java + test/java/nio/charset/CharsetDecoder/EmptyInput.java + test/java/nio/charset/CharsetEncoder/CanEncode.java + test/java/nio/charset/CharsetEncoder/Flush.java + test/java/nio/charset/RemovingSunIO/SunioAlias.java + test/java/nio/charset/RemovingSunIO/TestCOMP.java + test/java/nio/charset/RemovingSunIO/TestUnmappableForLength.java + test/java/nio/charset/coders/BashCache.java + test/java/nio/charset/coders/BashStreams.java + test/java/nio/charset/coders/Check.java + test/java/nio/charset/coders/CheckSJISMappingProp.sh + test/java/nio/charset/coders/Errors.java + test/java/nio/charset/coders/FullRead.java + test/java/nio/charset/coders/IOCoders.java + test/java/nio/charset/coders/IsLegalReplacement.java + test/java/nio/charset/coders/ResetISO2022JP.java + test/java/nio/charset/coders/SJISPropTest.java + test/java/nio/charset/coders/StreamTimeout.java + test/java/nio/charset/coders/Surrogate.java + test/java/nio/charset/coders/Surrogates.java + test/java/nio/charset/coders/Util.java + test/java/nio/charset/coders/ref.shift_jis + test/java/nio/charset/coders/ref.windows-31j + test/java/nio/charset/spi/FooCharset.java + test/java/nio/charset/spi/FooProvider.java + test/java/nio/charset/spi/Test.java + test/java/nio/charset/spi/basic.sh + test/java/nio/charset/spi/charsetProvider.sp + test/java/nio/charset/spi/default-pol Changeset: 7dadd2951a8b Author: andrew Date: 2010-02-02 10:55 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/7dadd2951a8b 6921740: Eliminate warnings from sun.io converters and allow compiling with JAVAC_MAX_WARNINGS=true Summary: Fix sun.io converters unchecked and cast warnings produced by -Xlint:all Reviewed-by: alanb, sherman ! make/java/sun_nio/Makefile ! src/share/classes/sun/io/ByteToCharUTF8.java ! src/share/classes/sun/io/CharToByteUnicode.java ! src/share/classes/sun/io/CharacterEncoding.java ! src/share/classes/sun/io/Converters.java ! src/share/classes/sun/nio/cs/AbstractCharsetProvider.java Changeset: e6ab5fabaf7e Author: weijun Date: 2010-02-03 17:04 +0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e6ab5fabaf7e 6922482: keytool's help on -file always shows 'output file' Reviewed-by: wetmore ! src/share/classes/sun/security/tools/KeyTool.java + test/sun/security/tools/keytool/file-in-help.sh Changeset: a39e899aa5dc Author: sherman Date: 2010-02-05 00:10 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/a39e899aa5dc 6919132: Regex \P{Lu} selects half of a surrogate pari Summary: To use StartS for complement category/block class Reviewed-by: martin, okutsu ! src/share/classes/java/util/regex/Pattern.java ! test/java/util/regex/RegExTest.java Changeset: 7136683a33d2 Author: wetmore Date: 2010-02-05 17:05 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/7136683a33d2 6923976: TestProviderLeak.java is using too small of an initial heap under newer Hotspot (b79+) Reviewed-by: ohair ! test/com/sun/crypto/provider/KeyFactory/TestProviderLeak.java Changeset: 445b9928fb70 Author: sherman Date: 2010-02-06 09:26 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/445b9928fb70 6923692: java/classes_util TEST_BUG:ReadZip.java fails when Summary: to create the test file at test.dir Reviewed-by: alanb ! test/java/util/zip/ZipFile/ReadZip.java Changeset: e79d95ea2e81 Author: lana Date: 2010-02-08 23:59 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e79d95ea2e81 Merge Changeset: 89b0235188b5 Author: lana Date: 2010-02-09 00:00 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/89b0235188b5 Merge Changeset: 31a3f28f3326 Author: dcherepanov Date: 2009-12-23 01:22 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/31a3f28f3326 6908299: Missed changes for 6664512 during the merge with 6879044 Reviewed-by: mchung, art ! src/share/classes/sun/util/logging/PlatformLogger.java Changeset: 7b65af04d43c Author: dav Date: 2009-12-22 17:28 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/7b65af04d43c 6893325: JComboBox and dragging to an item outside the bounds of the containing JFrame is not selecting that Reviewed-by: art, dcherepanov ! src/solaris/classes/sun/awt/X11/XWindowPeer.java Changeset: 26280d1705b2 Author: dcherepanov Date: 2009-12-28 20:35 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/26280d1705b2 6857363: deadlock caused by sun.awt.X11.XTrayIconPeer$Tooltip.display Reviewed-by: ant, art ! src/solaris/classes/sun/awt/X11/InfoWindow.java Changeset: fd5bf5955e37 Author: uta Date: 2009-12-24 17:19 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/fd5bf5955e37 4874070: invoking DragSource's startDrag with an Image renders no image on drag Reviewed-by: art, denis, alexp ! make/sun/awt/FILES_c_windows.gmk ! make/sun/awt/Makefile ! make/sun/awt/make.depend ! src/share/classes/javax/swing/TransferHandler.java ! src/share/classes/sun/awt/dnd/SunDragSourceContextPeer.java ! src/windows/classes/sun/awt/windows/WDataTransferer.java ! src/windows/classes/sun/awt/windows/WDragSourceContextPeer.java ! src/windows/classes/sun/awt/windows/WToolkit.java ! src/windows/lib/flavormap.properties ! src/windows/native/sun/windows/awt.h + src/windows/native/sun/windows/awt_DCHolder.cpp + src/windows/native/sun/windows/awt_DCHolder.h ! src/windows/native/sun/windows/awt_DnDDS.cpp ! src/windows/native/sun/windows/awt_DnDDS.h ! src/windows/native/sun/windows/awt_DnDDT.cpp ! src/windows/native/sun/windows/awt_DnDDT.h ! src/windows/native/sun/windows/awt_Toolkit.cpp ! src/windows/native/sun/windows/awt_Toolkit.h + src/windows/native/sun/windows/awt_ole.cpp + src/windows/native/sun/windows/awt_ole.h + test/java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.html + test/java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.java + test/java/awt/dnd/DnDFileGroupDescriptor/DnDTarget.java + test/java/awt/dnd/ImageDecoratedDnD/DnDSource.java + test/java/awt/dnd/ImageDecoratedDnD/DnDTarget.java + test/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.html + test/java/awt/dnd/ImageDecoratedDnD/ImageDecoratedDnD.java + test/java/awt/dnd/ImageDecoratedDnD/ImageGenerator.java + test/java/awt/dnd/ImageDecoratedDnD/MyCursor.java + test/java/awt/dnd/ImageDecoratedDnDInOut/DnDSource.java + test/java/awt/dnd/ImageDecoratedDnDInOut/DnDTarget.java + test/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html + test/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.java + test/java/awt/dnd/ImageDecoratedDnDInOut/ImageGenerator.java + test/java/awt/dnd/ImageDecoratedDnDInOut/MyCursor.java + test/java/awt/dnd/ImageDecoratedDnDNegative/DnDSource.java + test/java/awt/dnd/ImageDecoratedDnDNegative/DnDTarget.java + test/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html + test/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.java + test/java/awt/dnd/ImageDecoratedDnDNegative/ImageGenerator.java + test/java/awt/dnd/ImageDecoratedDnDNegative/MyCursor.java Changeset: 4799006d0171 Author: uta Date: 2010-01-13 17:10 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/4799006d0171 Merge Changeset: f154d4943a1a Author: uta Date: 2010-01-14 17:56 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/f154d4943a1a 6916867: Fastdebug build failed after CR 4874070 fix putback. Reviewed-by: art, dcherepanov ! src/windows/native/sun/windows/awt_DnDDS.cpp Changeset: 3cc5eff94552 Author: dcherepanov Date: 2010-01-20 01:33 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/3cc5eff94552 6660258: Java application stops Windows logout/shutdown (regression in 1.5.0_14) Reviewed-by: anthony, art, uta ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awtmsg.h Changeset: 0f92194cd798 Author: dcherepanov Date: 2010-01-22 19:47 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/0f92194cd798 6756774: fstdebug jvm fails with assertion (result != deleted_handle(),"Used a deleted global handle.") Reviewed-by: art, anthony ! src/windows/native/sun/windows/awt_MenuItem.cpp Changeset: d7c4baff3f96 Author: lana Date: 2010-01-28 18:24 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/d7c4baff3f96 Merge - make/java/redist/FILES.gmk ! make/sun/awt/Makefile - make/sun/nio/FILES_java.gmk - src/share/classes/sun/dyn/util/BytecodeSignature.java - src/solaris/classes/sun/nio/ch/SctpSocketDispatcher.java Changeset: 66c193082586 Author: yan Date: 2010-02-08 17:02 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/66c193082586 6882912: Strange behaviours when typing @ or ' Summary: Eliminate stray lines without a proper unicode->regularKeyID pair (e.g. as there is no "arrow left" unicode, should be no pair) Reviewed-by: rupashka ! src/share/classes/sun/awt/ExtendedKeyCodes.java Changeset: b51982678191 Author: lana Date: 2010-02-09 00:02 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b51982678191 Merge Changeset: de7807599a9b Author: peytoia Date: 2009-12-15 14:50 +0900 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/de7807599a9b 5047314: [Col] Collator.compare() runs indefinitely for a certain set of Thai strings Reviewed-by: okutsu ! src/share/classes/java/text/CollationElementIterator.java + test/java/text/Collator/Bug5047314.java Changeset: 3efbbc00ac5f Author: lana Date: 2009-12-16 16:25 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/3efbbc00ac5f Merge - make/tools/CharsetMapping/DoubleByte-X.java - make/tools/CharsetMapping/SingleByte-X.java - src/share/classes/sun/awt/ComponentAccessor.java - src/share/classes/sun/awt/WindowAccessor.java - src/share/classes/sun/security/provider/IdentityDatabase.java - src/share/classes/sun/security/provider/SystemIdentity.java - src/share/classes/sun/security/provider/SystemSigner.java - src/share/classes/sun/security/x509/X500Signer.java - src/share/classes/sun/security/x509/X509Cert.java - src/share/classes/sun/tools/jar/JarVerifierStream.java - src/share/classes/sun/util/CoreResourceBundleControl-XLocales.java - src/share/classes/sun/util/LocaleDataMetaInfo-XLocales.java - test/java/util/Formatter/Basic-X.java - test/sun/tools/native2ascii/test2 - test/tools/launcher/SolarisDataModel.sh - test/tools/launcher/SolarisRunpath.sh - test/tools/launcher/libraryCaller.c - test/tools/launcher/libraryCaller.h - test/tools/launcher/libraryCaller.java Changeset: e2f7e92c30f1 Author: peterz Date: 2009-12-21 19:26 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e2f7e92c30f1 6860433: [Nimbus] Code to set a single slider's thumb background doesn't work as specified Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/nimbus/Defaults.template ! src/share/classes/javax/swing/plaf/nimbus/NimbusLookAndFeel.java + test/javax/swing/plaf/nimbus/ColorCustomizationTest.java Changeset: fffd21bc5657 Author: peterz Date: 2009-12-25 17:47 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/fffd21bc5657 6860438: [Nimbus] Code to globally set slider's thumb background doesn't work as specified Reviewed-by: rupashka ! src/share/classes/javax/swing/MultiUIDefaults.java + test/javax/swing/MultiUIDefaults/4300666/bug4300666.html + test/javax/swing/MultiUIDefaults/4300666/bug4300666.java + test/javax/swing/MultiUIDefaults/4331767/bug4331767.java + test/javax/swing/MultiUIDefaults/Test6860438.java Changeset: e9ccd1dd6923 Author: andrew Date: 2010-01-08 12:51 +0000 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e9ccd1dd6923 6584033: (tz) wrong buffer length in TimeZone_md.c Summary: Add testcase for this bug Reviewed-by: darcy, okutsu + test/java/util/TimeZone/TimeZoneDatePermissionCheck.java + test/java/util/TimeZone/TimeZoneDatePermissionCheck.sh Changeset: b129d0f7be40 Author: peytoia Date: 2010-01-13 15:40 +0900 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/b129d0f7be40 6868503: RuleBasedBreakIterator is inefficient Reviewed-by: okutsu ! src/share/classes/java/text/RuleBasedBreakIterator.java Changeset: 9c5a24050392 Author: malenkov Date: 2010-01-21 21:45 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/9c5a24050392 4922835: DOC: Statement javadoc should indicate that target and methodName cannot be null Reviewed-by: peterz ! src/share/classes/java/beans/Expression.java ! src/share/classes/java/beans/Statement.java Changeset: eba0ff97a252 Author: malenkov Date: 2010-01-21 21:53 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/eba0ff97a252 4968536: DOC: Javadoc for java.beans.Encoder.getPersistenceDelegate is incomplete Reviewed-by: peterz ! src/share/classes/java/beans/Encoder.java Changeset: 3c61edecf44f Author: okutsu Date: 2010-01-26 15:42 +0900 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/3c61edecf44f 6912866: (date) java.util.Date.before / after may be expensive Reviewed-by: peytoia ! src/share/classes/java/util/Date.java Changeset: e7127f3fa2f4 Author: peterz Date: 2010-01-28 17:06 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/e7127f3fa2f4 6912118: Incosistency in several SynthUI classes between inherited specs ofupdate() and paint() methods Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/synth/SynthButtonUI.java ! src/share/classes/javax/swing/plaf/synth/SynthColorChooserUI.java ! src/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java ! src/share/classes/javax/swing/plaf/synth/SynthDesktopIconUI.java ! src/share/classes/javax/swing/plaf/synth/SynthDesktopPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthEditorPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthInternalFrameUI.java ! src/share/classes/javax/swing/plaf/synth/SynthLabelUI.java ! src/share/classes/javax/swing/plaf/synth/SynthListUI.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuItemUI.java ! src/share/classes/javax/swing/plaf/synth/SynthMenuUI.java ! src/share/classes/javax/swing/plaf/synth/SynthOptionPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthPanelUI.java ! src/share/classes/javax/swing/plaf/synth/SynthPopupMenuUI.java ! src/share/classes/javax/swing/plaf/synth/SynthProgressBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthRootPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthScrollBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthScrollPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSeparatorUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSliderUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSpinnerUI.java ! src/share/classes/javax/swing/plaf/synth/SynthSplitPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTableHeaderUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTableUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTextAreaUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTextFieldUI.java ! src/share/classes/javax/swing/plaf/synth/SynthToolBarUI.java ! src/share/classes/javax/swing/plaf/synth/SynthToolTipUI.java ! src/share/classes/javax/swing/plaf/synth/SynthTreeUI.java ! src/share/classes/javax/swing/plaf/synth/SynthViewportUI.java Changeset: 4eb3a8c95c24 Author: malenkov Date: 2010-01-28 20:49 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/4eb3a8c95c24 6412286: DOC: LTP: Unspecified NPE in java.beans.DefaultPersistenceDelegate.instantiate method Reviewed-by: peterz ! src/share/classes/java/beans/DefaultPersistenceDelegate.java ! src/share/classes/java/beans/PersistenceDelegate.java Changeset: 3283bb8c1bcb Author: lana Date: 2010-01-28 16:12 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/3283bb8c1bcb Merge - make/java/redist/FILES.gmk - make/sun/nio/FILES_java.gmk - src/share/classes/sun/dyn/util/BytecodeSignature.java - src/solaris/classes/sun/nio/ch/SctpSocketDispatcher.java Changeset: 3913691b3021 Author: malenkov Date: 2010-02-05 10:36 +0300 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/3913691b3021 6921057: REGRESSION: persistence delegate issue on Windows and Linux against 5.u23b03/6u17b11 Reviewed-by: peterz, art ! src/share/classes/java/beans/Introspector.java ! test/java/beans/Introspector/6380849/TestBeanInfo.java ! test/java/beans/Introspector/Test5102804.java ! test/java/beans/XMLEncoder/Test4646747.java Changeset: 5c0c2882eed2 Author: lana Date: 2010-02-09 00:05 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/5c0c2882eed2 Merge Changeset: 7cb9388bb1a1 Author: lana Date: 2010-02-14 23:38 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/7cb9388bb1a1 Merge Changeset: a9b4fde406d4 Author: mikejwre Date: 2010-02-18 13:31 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/jdk/rev/a9b4fde406d4 Added tag jdk7-b84 for changeset 7cb9388bb1a1 ! .hgtags From lana.steuck at sun.com Sat Feb 20 06:38:40 2010 From: lana.steuck at sun.com (lana.steuck at sun.com) Date: Sat, 20 Feb 2010 06:38:40 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk7/2d/langtools: 18 new changesets Message-ID: <20100220063933.432F24292A@hg.openjdk.java.net> Changeset: c9f4ae1f1480 Author: mikejwre Date: 2010-02-04 11:19 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/c9f4ae1f1480 Added tag jdk7-b82 for changeset 47003a3622f6 ! .hgtags Changeset: 2edcb5dc642d Author: mikejwre Date: 2010-02-12 13:25 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/2edcb5dc642d Added tag jdk7-b83 for changeset c9f4ae1f1480 ! .hgtags Changeset: f23b985beb78 Author: jjg Date: 2010-01-19 14:28 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/f23b985beb78 6917067: refactor type annotations code from TransTypes into new TypeAnnotations class Reviewed-by: jjg, darcy Contributed-by: mali at csail.mit.edu, mernst at cs.washington.edu + src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/TransTypes.java Changeset: 0eaf89e08564 Author: jjg Date: 2010-01-20 16:12 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/0eaf89e08564 6918127: improve handling of TypeAnnotationPosition fields Reviewed-by: jjg, darcy Contributed-by: mali at csail.mit.edu, mernst at cs.washington.edu ! src/share/classes/com/sun/tools/classfile/ExtendedAnnotation.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java ! src/share/classes/com/sun/tools/javac/jvm/Code.java ! src/share/classes/com/sun/tools/javac/jvm/Gen.java Changeset: da0e3e2dd3ef Author: jjg Date: 2010-01-26 11:15 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/da0e3e2dd3ef 6919944: incorrect position given for duplicate annotation value error Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/comp/Check.java ! test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/parambounds/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/parambounds/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/receiver/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/receiver/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/typeArgs/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/typeArgs/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/typeparams/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/typeparams/DuplicateAnnotationValue.out ! test/tools/javac/typeAnnotations/failures/common/wildcards/DuplicateAnnotationValue.java ! test/tools/javac/typeAnnotations/failures/common/wildcards/DuplicateAnnotationValue.out Changeset: 59167312ed4e Author: jjg Date: 2010-01-26 11:23 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/59167312ed4e 6917130: should test that annotations that have been optimized away are not emitted to classfile Reviewed-by: jjg, darcy Contributed-by: mali at csail.mit.edu, mernst at cs.washington.edu + test/tools/javac/typeAnnotations/classfile/DeadCode.java Changeset: ff7a01f9eff3 Author: lana Date: 2010-01-27 14:46 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/ff7a01f9eff3 Merge Changeset: 699ecefbdd4e Author: jjg Date: 2010-01-29 16:06 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/699ecefbdd4e 6919889: assorted position errors in compiler syntax trees Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java + test/tools/javac/T6654037.java ! test/tools/javac/generics/diamond/neg/Neg01.out ! test/tools/javac/generics/diamond/neg/Neg02.out ! test/tools/javac/generics/diamond/neg/Neg03.out ! test/tools/javac/generics/diamond/neg/Neg04.out + test/tools/javac/treepostests/TreePosTest.java Changeset: 8e638442522a Author: jjg Date: 2010-01-29 16:54 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/8e638442522a 6499119: Created package-info class file modeled improperly 6920317: package-info.java file has to be specified on the javac cmdline, else it will not be avail. Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + test/tools/javac/processing/6499119/ClassProcessor.java + test/tools/javac/processing/6499119/package-info.java + test/tools/javac/processing/T6920317.java Changeset: 732510cc3538 Author: jjg Date: 2010-02-01 17:05 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/732510cc3538 6919986: [308] change size of type_index (of CLASS_EXTENDS and THROWS) from byte to short Reviewed-by: darcy, jjg Contributed-by: mali at csail.mit.edu, mernst at cs.washington.edu ! src/share/classes/com/sun/tools/classfile/ExtendedAnnotation.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java Changeset: b0a68258360a Author: jjg Date: 2010-02-02 10:56 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/b0a68258360a 6918625: handle annotations on array class literals Reviewed-by: jjg, darcy Contributed-by: mali at csail.mit.edu, mernst at cs.washington.edu ! src/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java ! src/share/classes/com/sun/tools/javap/AnnotationWriter.java + test/tools/javap/typeAnnotations/ArrayClassLiterals2.java Changeset: 41ed86f86585 Author: jjg Date: 2010-02-03 11:28 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/41ed86f86585 6922429: extend tree position test waiver Reviewed-by: darcy ! test/tools/javac/treepostests/TreePosTest.java Changeset: f65d652cb6af Author: jjg Date: 2010-02-03 11:33 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/f65d652cb6af 6922300: [308] populate the reference_info for type annotations targeting primitive class literals Reviewed-by: darcy, jjg Contributed-by: mali at csail.mit.edu, mernst at cs.washington.edu ! src/share/classes/com/sun/tools/javac/jvm/Gen.java Changeset: 4c844e609d81 Author: jjg Date: 2010-02-03 16:58 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/4c844e609d81 6921979: add test program to verify annotations are attached to nodes as expected Reviewed-by: darcy + test/tools/javac/treeannotests/AnnoTreeTests.java + test/tools/javac/treeannotests/DA.java + test/tools/javac/treeannotests/TA.java + test/tools/javac/treeannotests/Test.java + test/tools/javac/treeannotests/TestProcessor.java Changeset: 4b4e282a3146 Author: jjg Date: 2010-02-04 10:14 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/4b4e282a3146 6923080: TreeScanner.visitNewClass should scan tree.typeargs Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/TypeAnnotations.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java + test/tools/javac/tree/T6923080.java + test/tools/javac/tree/TreeScannerTest.java Changeset: 56a46d079264 Author: lana Date: 2010-02-08 23:59 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/56a46d079264 Merge Changeset: d9cd5b8286e4 Author: lana Date: 2010-02-14 23:39 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/d9cd5b8286e4 Merge Changeset: 75d5bd12eb86 Author: mikejwre Date: 2010-02-18 13:31 -0800 URL: http://hg.openjdk.java.net/jdk7/2d/langtools/rev/75d5bd12eb86 Added tag jdk7-b84 for changeset d9cd5b8286e4 ! .hgtags From Roman.Kennke at Sun.COM Thu Feb 25 15:19:05 2010 From: Roman.Kennke at Sun.COM (Roman Kennke) Date: Thu, 25 Feb 2010 16:19:05 +0100 Subject: [OpenJDK 2D-Dev] Request for review: 6892485: Deadlock in SunGraphicsEnvironment / FontManager Message-ID: <1267111145.6657.12.camel@moonlight> Hi there, this patch fixes the deadlock in FontManager for OpenJDK7 that has been reported repeatedly on this list. I have a testcase here (attached), which I could prepare for jtreg, but it is not totally reliable and depends on the system configuration (which and how many fonts installed), not sure if we want this. The problem is that two threads run into font code, locking on two different locks in wrong order. (Better analysis is in the bug). The fix is to synchronize only on one lock object (the FontManager instance). http://cr.openjdk.java.net/~rkennke/6892485/webrev.00/ Ok to commit? -------------- next part -------------- A non-text attachment was scrubbed... Name: FontDeadlock.java Type: text/x-java Size: 9419 bytes Desc: not available URL: -------------- next part -------------- A non-text attachment was scrubbed... Name: runfontdeadlock.sh Type: application/x-shellscript Size: 61 bytes Desc: not available URL: From Igor.Nekrestyanov at Sun.COM Thu Feb 25 19:21:08 2010 From: Igor.Nekrestyanov at Sun.COM (Igor Nekrestyanov) Date: Thu, 25 Feb 2010 11:21:08 -0800 Subject: [OpenJDK 2D-Dev] Request for review: 6892485: Deadlock in SunGraphicsEnvironment / FontManager In-Reply-To: <1267111145.6657.12.camel@moonlight> References: <1267111145.6657.12.camel@moonlight> Message-ID: <4B86CDA4.3060801@sun.com> i am ok with this fix. -igor On 2/25/10 7:19 AM, Roman Kennke wrote: > Hi there, > > this patch fixes the deadlock in FontManager for OpenJDK7 that has been > reported repeatedly on this list. I have a testcase here (attached), > which I could prepare for jtreg, but it is not totally reliable and > depends on the system configuration (which and how many fonts > installed), not sure if we want this. > > The problem is that two threads run into font code, locking on two > different locks in wrong order. (Better analysis is in the bug). The fix > is to synchronize only on one lock object (the FontManager instance). > > http://cr.openjdk.java.net/~rkennke/6892485/webrev.00/ > > Ok to commit? > > From Roman.Kennke at Sun.COM Thu Feb 25 19:42:36 2010 From: Roman.Kennke at Sun.COM (Roman Kennke) Date: Thu, 25 Feb 2010 20:42:36 +0100 Subject: [OpenJDK 2D-Dev] Request for review: 6892485: Deadlock in SunGraphicsEnvironment / FontManager In-Reply-To: <4B86CDA4.3060801@sun.com> References: <1267111145.6657.12.camel@moonlight> <4B86CDA4.3060801@sun.com> Message-ID: <1267126956.6657.40.camel@moonlight> I just realized that there was another use of this field as sync lock, which I changed to use 'this' too. The lucidaFontName field is used in one other location (not for syncing) and it surely could use some cleanup, but I left it alone for now. http://cr.openjdk.java.net/~rkennke/6892485/webrev.01/ I need at least another review (not sure if Igor needs to say 'go' again?). Thanks, Roman Am Donnerstag, den 25.02.2010, 11:21 -0800 schrieb Igor Nekrestyanov: > i am ok with this fix. > > -igor > > On 2/25/10 7:19 AM, Roman Kennke wrote: > > Hi there, > > > > this patch fixes the deadlock in FontManager for OpenJDK7 that has been > > reported repeatedly on this list. I have a testcase here (attached), > > which I could prepare for jtreg, but it is not totally reliable and > > depends on the system configuration (which and how many fonts > > installed), not sure if we want this. > > > > The problem is that two threads run into font code, locking on two > > different locks in wrong order. (Better analysis is in the bug). The fix > > is to synchronize only on one lock object (the FontManager instance). > > > > http://cr.openjdk.java.net/~rkennke/6892485/webrev.00/ > > > > Ok to commit? > > > > > From Igor.Nekrestyanov at Sun.COM Thu Feb 25 19:58:15 2010 From: Igor.Nekrestyanov at Sun.COM (Igor Nekrestyanov) Date: Thu, 25 Feb 2010 11:58:15 -0800 Subject: [OpenJDK 2D-Dev] Request for review: 6892485: Deadlock in SunGraphicsEnvironment / FontManager In-Reply-To: <1267126956.6657.40.camel@moonlight> References: <1267111145.6657.12.camel@moonlight> <4B86CDA4.3060801@sun.com> <1267126956.6657.40.camel@moonlight> Message-ID: <4B86D657.3070808@sun.com> good catch. Lets wait for Phil to review. He knows this part of code better. -igor On 2/25/10 11:42 AM, Roman Kennke wrote: > I just realized that there was another use of this field as sync lock, > which I changed to use 'this' too. The lucidaFontName field is used in > one other location (not for syncing) and it surely could use some > cleanup, but I left it alone for now. > > http://cr.openjdk.java.net/~rkennke/6892485/webrev.01/ > > I need at least another review (not sure if Igor needs to say 'go' > again?). > > Thanks, Roman > > Am Donnerstag, den 25.02.2010, 11:21 -0800 schrieb Igor Nekrestyanov: > >> i am ok with this fix. >> >> -igor >> >> On 2/25/10 7:19 AM, Roman Kennke wrote: >> >>> Hi there, >>> >>> this patch fixes the deadlock in FontManager for OpenJDK7 that has been >>> reported repeatedly on this list. I have a testcase here (attached), >>> which I could prepare for jtreg, but it is not totally reliable and >>> depends on the system configuration (which and how many fonts >>> installed), not sure if we want this. >>> >>> The problem is that two threads run into font code, locking on two >>> different locks in wrong order. (Better analysis is in the bug). The fix >>> is to synchronize only on one lock object (the FontManager instance). >>> >>> http://cr.openjdk.java.net/~rkennke/6892485/webrev.00/ >>> >>> Ok to commit? >>> >>> >>> >> > >