[OpenJDK 2D-Dev] [PATCH] Request for review: 6896335: GraphicsEnvironment.getDefaultScreenDevice() throws UnsatisfiedLinkError in headless mode

Roman Kennke Roman.Kennke at Sun.COM
Tue Feb 2 21:40:48 UTC 2010


Here's the updated fix with testcase (I took the testcase from the
bugreport and transformed it into a proper jtreg test).

http://cr.openjdk.java.net/~rkennke/6896335/webrev.01/

Is this ok to put back?

We also need another reviewer, Igor, Dmitri?

/Roman

Am Montag, den 30.11.2009, 11:56 -0800 schrieb Phil Race:
> sorry to sound like a broken record, fix looks fine,
> regression test needed.  In this case I don't think we
> have one .. I suppose in this and the last case too it
> could be that adding noreg-jck might be sufficient but
> a regression test would be better for various reasons.
> 
> -phil.
> 
> Roman Kennke wrote:
> > This is a relatively simple fix for 6896335. When I did the change to
> > GraphicsEnvironment initialization, I missed this small line that's only
> > executed in headless mode, leading to weird exceptions...
> > 
> > http://cr.openjdk.java.net/~rkennke/6896335/webrev.00/
> > 
> > Ok to commit?
> > 
> > /Roman
> > 
> > 





More information about the 2d-dev mailing list