[OpenJDK 2D-Dev] Request for review: 6892485: Deadlock in SunGraphicsEnvironment / FontManager

Igor Nekrestyanov Igor.Nekrestyanov at Sun.COM
Thu Feb 25 19:21:08 UTC 2010


i am ok with this fix.

-igor

On 2/25/10 7:19 AM, Roman Kennke wrote:
> Hi there,
>
> this patch fixes the deadlock in FontManager for OpenJDK7 that has been
> reported repeatedly on this list. I have a testcase here (attached),
> which I could prepare for jtreg, but it is not totally reliable and
> depends on the system configuration (which and how many fonts
> installed), not sure if we want this.
>
> The problem is that two threads run into font code, locking on two
> different locks in wrong order. (Better analysis is in the bug). The fix
> is to synchronize only on one lock object (the FontManager instance).
>
> http://cr.openjdk.java.net/~rkennke/6892485/webrev.00/
>
> Ok to commit?
>
>    




More information about the 2d-dev mailing list