[OpenJDK 2D-Dev] Font rendering issue

[Jim Graham]

The thing that bothers me about this "fix" is that the value being 
returned here is the raw computed value.  All of the values in this 
routine are being returned in floating point "sub-pixel" maximum 
accuracy.  I don't see why *this* code needs to round this value.  If 
something that uses the data returned from this method needs an integer 
then it should be up to that code to do whatever rounding is 
appropriate, but rounding at the most primitive level to fix a bug at a 
higher level is premature (IMHO)...

			...jim

Mario Torre wrote:
> Il giorno dom, 09/05/2010 alle 14.17 +0200, Mario Torre ha scritto:
>> Il giorno dom, 09/05/2010 alle 12.14 +0200, Mario Torre ha scritto:
>>
>>> ly = (jfloat) ROUND(FT26Dot6ToFloat(
>>>               scalerInfo->face->size->metrics.height +
>>>               bmodifier) + ay - dy);
>>>
>> And here is the proposed webrev:
>>
>> http://cr.openjdk.java.net/~neugens/100134/webrev.02/
>>
>> As noted, this doesn't really fix all the bugs, it just fixes the
>> rounding for leading, which, by chance, workarounds the other issues and
>> appear to fix the rendering as well.
>>
>> Cheers,
>> Mario
> 
> Any comment on that?
> 
> Cheers,
> Mario