From james.graham at oracle.com Sat Aug 6 00:30:37 2011 From: james.graham at oracle.com (Jim Graham) Date: Fri, 05 Aug 2011 17:30:37 -0700 Subject: [OpenJDK 2D-Dev] Pisces AA renderer performance improvement. In-Reply-To: <276956464.725405.1311109313614.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> References: <276956464.725405.1311109313614.JavaMail.root@zmail04.collab.prod.int.phx2.redhat.com> Message-ID: <4E3C8B2D.5010207@oracle.com> Hi Denis, I've finally started wrapping my head around this. It's a nice new take on reorganizing the work and I'm intrigued by the fact that you said that this is getting close to beating Ductus. Some comments: - Side note - I could repurpose the previous incarnation of the file for FX rendering with just a few minor modifications - it looks like those days are over now, though, and I'll have to massage it quite a bit more to share the code... (Frowny face for me) - I'd like to see the Renderer cache implemented in the RenderingEngine code since it is outside the scope of the work that Renderer does. Also, your table could fill up with partially used renderers if there are ever any bugs that cause it to throw an exception before it calls giveBack(). I'd like to see some code that tries to make sure they are always given back even if errors happen (or, at least, they are removed from the data structures if we feel that they aren't appropriate to reuse after the error). - Renderer, line 158 - "while (--toadd >= 0)" allows the compiler to use the condition codes from the decrement to satisfy the test. - Why not just have 1 tracker that manages TILE_SIZE<0 then you could just copy the value "ptrs[i] = ptrs[--count]" and let the insertion sort at the start of the next pixel row deal with it. - Another way to manage the merge sort would be to have a temp array of SUB_PIX_Y values, quickly store all of the crossings into it either forwards or backwards in a pair of tight loops (one for slope >0 and one for slope <0) and then do a regular merge sort in a second tight loop. If you use the values at [ci,ci+toadd) as the temp array then one test could skip the merge sort step entirely because the values would already be sorted (and this is likely to happen). My thoughts were that 2 tighter loops might be faster than one more complicated loop. I'm going to send this now before I get too bogged down in figuring out the new design of the TileGenerator... ...jim On 7/19/2011 2:01 PM, Denis Lila wrote: > Hi Jim. > > We spoke about this a while ago and I started working > on it. This is what I have so far: > http://icedtea.classpath.org/~dlila/webrevs/RendererPerf/ > > My main intention was to remove some stages > from the renderer (like you suggested) because what > we were doing was: > 1. Transform curves to lines and put the lines in a buffer. > 2. Iterate through scanlines, get crossings with the lines, > compute alphas, and store them into an array. > 3. Compress the alpha array using RLE. > 4. When asked, use the RLE encoding to generate alpha tiles. > > and I was hoping to be able to go directly from curves to > crossings, and then generate the tiles from the crossing > data. This would reduce the intermediate storage and would > move around much less data. > > At first, I implemented this with an int[][] where each inner > array represented the crossings in one pixel row, and the > crossings themselves packed 3 chunks of data into one int: > the x coordinate of the crossing, the orientation, the scanline > within the pixel row where the crossing was located (this was > a number in [0:1< The crossings needed to be sorted, and I did this with Arrays.sort. > This was fast in small tests, but for any shape with more than 4 edges > per pixel row it started having huge scalability problems > (for larger shapes we were spending 90+% of the time in > quicksort). > > The version in the webrev is the fastest yet, and it uses > a class similar to the ScanlineIterator for the sorting > (but now it iterates through pixel rows, not scanlines). > Unfortunately this means that there still are two levels > of intermediate storage (edges and crossings, analogous > to edges and RLE elements in the old version), but the > only way I can think of how to get rid of one of them > and still take use an average linear time sort is if we > start outputting alphas pixelrow by pixelrow, rather than > in 32x32 tiles. > > Anyway, it's much faster than it used to be, so we should > probably push it (after I implement a cache eviction > policy). > > Any suggestions/criticisms are always welcome. > > Thank you, > Denis. From lana.steuck at oracle.com Mon Aug 8 03:47:44 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 08 Aug 2011 03:47:44 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/hotspot: 82 new changesets Message-ID: <20110808035017.E7197479FA@hg.openjdk.java.net> Changeset: 2b27ef5c2173 Author: kvn Date: 2011-05-20 12:46 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/2b27ef5c2173 7046096: SEGV IN C2 WITH 6U25 Summary: Missing fail flag set in strings concatenation code. Reviewed-by: never ! src/share/vm/opto/stringopts.cpp Changeset: cfbca4d74a61 Author: jcoomes Date: 2011-05-20 22:27 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/cfbca4d74a61 Merge Changeset: 789d04408ca3 Author: kvn Date: 2011-05-21 11:44 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/789d04408ca3 7045693: java/util/EnumSet/EnumSetBash.java still failing intermittently Summary: New limit for unrolled loop should be set only for zero trip guard and loop iteration test. Reviewed-by: never ! src/share/vm/opto/loopTransform.cpp Changeset: b55f5bd7ec66 Author: kvn Date: 2011-05-21 13:59 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/b55f5bd7ec66 7045506: assert(!can_reshape || !new_phi) failed: for igvn new phi should be hooked Summary: Replace the assert in PhiNode::Ideal with check to avoid transformation of new phi. Reviewed-by: never ! src/share/vm/opto/cfgnode.cpp Changeset: 7523488edce5 Author: kvn Date: 2011-05-24 12:54 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/7523488edce5 7047300: VM crashes with assert(_base == InstPtr) failed: Not an object pointer Summary: The code incorrectly used is_instptr() instead of is_oopptr() to get const_oop. Reviewed-by: never ! src/share/vm/opto/output.cpp Changeset: ccf072cdba91 Author: iveresov Date: 2011-05-24 15:30 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ccf072cdba91 7046893: LP64 problem with double_quadword in c1_LIRAssembler_x86.cpp Summary: Fixed invalid casts in address computation Reviewed-by: kvn, never Contributed-by: thomas.salter at unisys.com ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp Changeset: 28a9fe9534ea Author: kvn Date: 2011-05-24 20:24 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/28a9fe9534ea 7048030: is_scavengable changes causing compiler to embed more constants Summary: ciObject::can_be_constant() and should_be_constant() should use is_perm() instead of !is_scavengable() Reviewed-by: never, jrose ! src/share/vm/ci/ciObject.cpp ! src/share/vm/ci/ciObject.hpp Changeset: 7db2b9499c36 Author: never Date: 2011-05-25 16:04 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/7db2b9499c36 7046732: JSR 292 assert(result == cpce->f1()) failed: expected result for assembly code Reviewed-by: kvn, iveresov, jrose ! src/share/vm/interpreter/interpreterRuntime.cpp Changeset: c7c81f18c834 Author: kvn Date: 2011-05-25 21:17 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/c7c81f18c834 7048332: Cadd_cmpLTMask doesn't handle 64-bit tmp register properly Summary: Use ins_encode %{ %} form to encode cadd_cmpLTMask() instruction and remove unused code. Reviewed-by: never ! src/cpu/x86/vm/x86_64.ad + test/compiler/7048332/Test7048332.java Changeset: 28263a73ebfb Author: iveresov Date: 2011-05-26 13:15 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/28263a73ebfb 7047491: C1: registers saved incorrectly when calling checkcast_arraycopy stub Summary: Save and restore the argument registers around the call to checkcast_arraycopy Reviewed-by: never, roland ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp Changeset: 5ac411b3b8fc Author: never Date: 2011-05-26 14:44 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/5ac411b3b8fc 7047961: JSR 292 MethodHandleWalk swap args doesn't handle T_LONG and T_DOUBLE properly Reviewed-by: kvn, jrose ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandleWalk.hpp ! src/share/vm/prims/methodHandles.cpp Changeset: c76c13577460 Author: never Date: 2011-05-26 16:39 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/c76c13577460 Merge Changeset: b2cb497dec28 Author: kvn Date: 2011-05-27 12:47 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/b2cb497dec28 7047069: Array can dynamically change size when assigned to an object field Summary: Fix initialization of a newly-allocated array with arraycopy Reviewed-by: never ! src/share/vm/opto/library_call.cpp + test/compiler/7047069/Test7047069.java Changeset: 33e2b8f1d466 Author: kvn Date: 2011-05-31 10:05 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/33e2b8f1d466 6956668: misbehavior of XOR operator (^) with int Summary: optimize cmp_ne(xor(X,1),0) to cmp_eq(X,0) only for boolean values X. Reviewed-by: never ! src/share/vm/opto/subnode.cpp + test/compiler/6956668/Test6956668.java Changeset: 60b8287df30e Author: jrose Date: 2011-06-01 23:25 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/60b8287df30e 7049415: Failure of resolution of sym.reference to the c.s.s. should be wrapped in BootstrapMethodError Summary: Delegate invokedynamic linkage errors to MethodHandleNatives.raiseException. Reviewed-by: never ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp Changeset: a93146d0e4be Author: jrose Date: 2011-06-01 23:25 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/a93146d0e4be 7049410: JSR 292 old method name MethodHandle.invokeGeneric should not be accepted by the JVM Summary: change the default setting of the flag AllowInvokeGeneric to false Reviewed-by: never ! src/share/vm/runtime/globals.hpp Changeset: 537a4053b0f9 Author: ysr Date: 2011-05-23 16:42 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/537a4053b0f9 7042740: CMS: assert(n> q) failed: Looping at: ... blockOffsetTable.cpp:557 Summary: Do a one-step look-ahead, when sweeping free or garbage blocks, to avoid overstepping sweep limit, which may become a non-block-boundary because of a heap expansion delta coalescing with a previously co-terminal free block. Reviewed-by: brutisso, tonyp ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/memory/blockOffsetTable.cpp Changeset: f153114134c8 Author: jcoomes Date: 2011-06-07 13:17 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/f153114134c8 Merge Changeset: d3b9f2be46ab Author: coleenp Date: 2011-05-21 15:39 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/d3b9f2be46ab 7033141: assert(has_cp_cache(i)) failed: oob Summary: Unrewrite bytecodes for OOM error allocating the constant pool cache. Reviewed-by: dcubed, acorn, never ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/rewriter.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/methodHandleWalk.cpp Changeset: 9dd6c4ba364f Author: coleenp Date: 2011-06-02 14:17 -0400 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/9dd6c4ba364f 7049928: VM crashes with "assert(_adapter != NULL) failed: must have" at methodOop.cpp:63 Summary: Removed extra change from another bug fix that caused this regression Reviewed-by: phh, dcubed, kvn, kamg, never ! src/share/vm/oops/methodOop.cpp Changeset: 96c891ebe56a Author: coleenp Date: 2011-06-02 21:01 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/96c891ebe56a Merge ! src/share/vm/prims/methodHandleWalk.cpp Changeset: ae1d716e395c Author: dsamersoff Date: 2011-06-09 01:33 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ae1d716e395c Merge Changeset: f918d6096e23 Author: never Date: 2011-06-02 13:36 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/f918d6096e23 7050554: JSR 292 - need optimization for selectAlternative Reviewed-by: kvn, jrose ! src/share/vm/ci/ciCallProfile.hpp ! src/share/vm/ci/ciMethodHandle.cpp ! src/share/vm/ci/ciMethodHandle.hpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/callGenerator.hpp ! src/share/vm/opto/doCall.cpp Changeset: cba7b5c2d53f Author: never Date: 2011-06-03 22:31 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/cba7b5c2d53f 7045514: SPARC assembly code for JSR 292 ricochet frames Reviewed-by: kvn, jrose ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/frame_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp + src/cpu/sparc/vm/methodHandles_sparc.hpp ! src/cpu/sparc/vm/registerMap_sparc.hpp ! src/cpu/sparc/vm/runtime_sparc.cpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/sparc/vm/stubRoutines_sparc.hpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.hpp ! src/cpu/x86/vm/runtime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_32.cpp ! src/cpu/x86/vm/sharedRuntime_x86_64.cpp ! src/cpu/x86/vm/stubRoutines_x86_32.hpp ! src/cpu/x86/vm/stubRoutines_x86_64.hpp ! src/share/vm/compiler/oopMap.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandleWalk.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp Changeset: 642c68c75db9 Author: kvn Date: 2011-06-04 10:36 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/642c68c75db9 7050280: assert(u->as_Unlock()->is_eliminated()) failed: sanity Summary: Mark all associated (same box and obj) lock and unlock nodes for elimination if some of them marked already. Reviewed-by: iveresov, never ! src/share/vm/opto/escape.cpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/macro.hpp Changeset: 5cf771a79037 Author: jrose Date: 2011-06-08 17:04 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/5cf771a79037 7047697: MethodHandle.invokeExact call for wrong method causes VM failure if run with -Xcomp Reviewed-by: never, twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/frame_x86.inline.hpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/share/vm/code/pcDesc.cpp Changeset: c8f2186acf6d Author: twisti Date: 2011-06-14 12:25 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/c8f2186acf6d 7053520: JSR292: crash in invokedynamic with C1 using tiered and compressed oops Reviewed-by: iveresov, never ! src/share/vm/c1/c1_LIRGenerator.cpp Changeset: f8c9417e3571 Author: never Date: 2011-06-14 14:41 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/f8c9417e3571 7052219: JSR 292: Crash in ~BufferBlob::MethodHandles adapters Reviewed-by: twisti, kvn, jrose ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/stubCodeGenerator.cpp ! src/share/vm/runtime/stubCodeGenerator.hpp Changeset: e2ce15aa3daf Author: never Date: 2011-06-14 15:20 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/e2ce15aa3daf Merge Changeset: cfcf2ba8f3eb Author: never Date: 2011-06-15 10:20 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/cfcf2ba8f3eb Merge ! src/share/vm/prims/methodHandleWalk.cpp Changeset: e2af886d540b Author: trims Date: 2011-07-01 13:07 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/e2af886d540b 7061691: Fork HS21 to HS22 - renumber Minor and build numbers of JVM Summary: Update the Minor and Build numbers for HS22 fork Reviewed-by: jcoomes ! make/hotspot_version Changeset: 1e3493ac2d11 Author: ysr Date: 2011-05-27 10:23 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/1e3493ac2d11 7048342: CMS: eob == _limit || fc->isFree() failed: Only a free chunk should allow us to cross over the limit Summary: The freeness bit was being cleared in debug code when it shouldn't have been. Also removed unused FreeChunk methods linkAfterNonNull and clearPrev. Reviewed-by: brutisso ! src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeChunk.hpp Changeset: 5c0a3c1858b1 Author: ysr Date: 2011-06-02 10:23 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/5c0a3c1858b1 7048782: CMS: assert(last_chunk_index_to_check<= last_chunk_index) failed: parCardTableModRefBS.cpp:359 Summary: The LNC array is sized before the start of a scavenge, while the heap may expand during a scavenge. With CMS, the last block of an arbitrary suffice of the LNC array may expand due to coalition with the expansion delta. We now take care not to attempt access past the end of the LNC array. LNC array code will be cleaned up and suitably encapsulated as part of the forthcoming performance RFE 7043675. Reviewed-by: brutisso ! src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp Changeset: e66f38dd58a9 Author: ysr Date: 2011-06-08 08:39 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/e66f38dd58a9 Merge Changeset: 053d84a76d3d Author: tonyp Date: 2011-06-08 15:31 -0400 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/053d84a76d3d 7032531: G1: enhance GC logging to include more accurate eden / survivor size transitions Summary: This changeset extends the logging information generated by +PrintGCDetails to also print out separate size transitions for the eden, survivors, and old regions. Reviewed-by: ysr, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp Changeset: ae5b2f1dcf12 Author: tonyp Date: 2011-06-08 21:48 -0400 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ae5b2f1dcf12 7045662: G1: OopsInHeapRegionClosure::set_region() should not be virtual Summary: make the method non-virtual, remove five unused closures, and fix a couple of copyright typos. Reviewed-by: stefank, johnc, poonam ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1_specialized_oop_closures.hpp ! src/share/vm/gc_implementation/g1/heapRegionSet.hpp ! src/share/vm/gc_implementation/g1/heapRegionSets.hpp Changeset: c3f1170908be Author: tonyp Date: 2011-06-10 13:16 -0400 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/c3f1170908be 7045330: G1: Simplify/fix the HeapRegionSeq class 7042285: G1: native memory leak during humongous object allocation 6804436: G1: heap region indices should be size_t Summary: A series of fixes and improvements to the HeapRegionSeq class: a) replace the _regions growable array with a standard C array, b) avoid de-allocating / re-allocating HeapRegion instances when the heap shrinks / grows (fix for 7042285), c) introduce fast method to map address to HeapRegion via a "biased" array pointer, d) embed the _hrs object in G1CollectedHeap, instead of pointing to it via an indirection, e) assume that all the regions added to the HeapRegionSeq instance are contiguous, f) replace int's with size_t's for indexes (and expand that to HeapRegion as part of 6804436), g) remove unnecessary / unused methods, h) rename a couple of fields (_alloc_search_start and _seq_bottom), i) fix iterate_from() not to always start from index 0 irrespective of the region passed to it, j) add a verification method to check the HeapRegionSeq assumptions, k) always call the wrappers for _hrs.iterate(), _hrs_length(), and _hrs.at() from G1CollectedHeap, not those methods di rectly, and l) unify the code that expands the sequence (by either re-using or creating a new HeapRegion) and make it robust wrt to a HeapRegion allocation failing. Reviewed-by: stefank, johnc, brutisso ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.inline.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.hpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.inline.hpp ! src/share/vm/gc_implementation/g1/sparsePRT.cpp Changeset: 2a241e764894 Author: minqi Date: 2011-06-10 15:08 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/2a241e764894 6941923: RFE: Handling large log files produced by long running Java Applications Summary: supply optinal flags to realize gc log rotation Reviewed-by: ysr, jwilhelm ! src/share/vm/gc_implementation/shared/concurrentGCThread.cpp ! src/share/vm/gc_implementation/shared/concurrentGCThread.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/atomic.cpp ! src/share/vm/runtime/atomic.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/safepoint.cpp ! src/share/vm/utilities/ostream.cpp ! src/share/vm/utilities/ostream.hpp + test/gc/6941923/test6941923.sh Changeset: 42df21744b50 Author: minqi Date: 2011-06-10 15:44 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/42df21744b50 Merge Changeset: ef2d1b8f2dd4 Author: ysr Date: 2011-06-13 09:58 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ef2d1b8f2dd4 7051430: CMS: ongoing CMS cycle should terminate abruptly to allow prompt JVM termination at exit Summary: It turns out that there is no need to explicitly stop CMS since the JVM is taken down at a terminal safepoint during which CMS threads are (terminally) inactive. This will need to be revised if and when we evolve in the future to a point where we allow JVM reincarnation in the same process, but those changes will be much more sweeping than just terminating CMS threads. The unused ::stop() methods will be removed in a separate CR. Also include in this CR is the fix for a small typo in the spelling of UseGCLogFileRotation in a message in arguments.cpp, brought to our attention by Rainer Jung and reviewed by minqi. Reviewed-by: johnc, jwilhelm ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/thread.cpp Changeset: 74cd10898bea Author: brutisso Date: 2011-06-13 13:48 +0200 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/74cd10898bea 6918185: Remove unused code for lost card-marking optimization in BacktraceBuilder Summary: Removed dead code Reviewed-by: ysr, coleenp, dholmes ! src/share/vm/classfile/javaClasses.cpp Changeset: 842b840e67db Author: tonyp Date: 2011-06-14 10:33 -0400 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/842b840e67db 7046558: G1: concurrent marking optimizations Summary: Some optimizations to improve the concurrent marking phase: specialize the main oop closure, make sure a few methods in the fast path are properly inlined, a few more bits and pieces, and some cosmetic fixes. Reviewed-by: stefank, johnc ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp + src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.hpp ! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp ! src/share/vm/gc_implementation/g1/g1_specialized_oop_closures.hpp ! src/share/vm/utilities/bitMap.hpp Changeset: 6747fd0512e0 Author: johnc Date: 2011-06-14 11:01 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/6747fd0512e0 7004681: G1: Extend marking verification to Full GCs Summary: Perform a heap verification after the first phase of G1's full GC using objects' mark words to determine liveness. The third parameter of the heap verification routines, which was used in G1 to determine which marking bitmap to use in liveness calculations, has been changed from a boolean to an enum with values defined for using the mark word, and the 'prev' and 'next' bitmaps. Reviewed-by: tonyp, ysr ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp Changeset: 5130fa1b24f1 Author: johnc Date: 2011-06-15 10:18 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/5130fa1b24f1 7045751: G1: +ExplicitGCInvokesConcurrent causes excessive single region evacuation pauses Summary: When ExplicitGCInvokesConcurrent is enabled, do not perform an evacuation pause if a marking cycle is already in progress and block the requesting thread until the marking cycle completes. Reviewed-by: tonyp, ysr ! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp Changeset: c9ca3f51cf41 Author: tonyp Date: 2011-06-16 15:51 -0400 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/c9ca3f51cf41 6994322: Remove the is_tlab and is_noref / is_large_noref parameters from the CollectedHeap Summary: Remove two unused parameters from the mem_allocate() method and update its uses accordingly. Reviewed-by: stefank, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/psOldGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/psOldGen.hpp ! src/share/vm/gc_implementation/parallelScavenge/psPermGen.cpp ! src/share/vm/gc_implementation/parallelScavenge/psYoungGen.hpp ! src/share/vm/gc_implementation/parallelScavenge/vmPSOperations.cpp ! src/share/vm/gc_implementation/parallelScavenge/vmPSOperations.hpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/gc_interface/collectedHeap.inline.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/memory/collectorPolicy.hpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/oops/typeArrayKlass.cpp Changeset: f75137faa7fe Author: ysr Date: 2011-06-20 09:42 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/f75137faa7fe 6916968: CMS: freeList.cpp:304 assert(_allocation_stats.prevSweep() + ..., "Conservation Principle") Summary: Fix assert and adjust demand volume computation by adding missing factor. Reviewed-by: jmasa, tonyp ! src/share/vm/gc_implementation/concurrentMarkSweep/freeList.cpp ! src/share/vm/gc_implementation/shared/allocationStats.hpp Changeset: 23d434c6290d Author: tonyp Date: 2011-06-20 22:03 -0400 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/23d434c6290d 7055073: G1: code cleanup in the concurrentMark.* files Summary: Only cosmetic changes to make the concurrentMark.* more consistent, code-style-wise, with the rest of the codebase. Reviewed-by: johnc, ysr ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.inline.hpp Changeset: e8b0b0392037 Author: tonyp Date: 2011-06-21 15:23 -0400 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/e8b0b0392037 7046182: G1: remove unnecessary iterations over the collection set Summary: Remove two unnecessary iterations over the collection set which are supposed to prepare the RSet's of the CSet regions for parallel iterations (we'll make sure this is done incrementally). I'll piggyback on this CR the removal of the G1_REM_SET_LOGGING code. Reviewed-by: brutisso, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.hpp ! src/share/vm/gc_implementation/g1/g1RemSet.inline.hpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp ! src/share/vm/gc_implementation/g1/heapRegionSets.cpp ! src/share/vm/gc_implementation/g1/heapRegionSets.hpp Changeset: 5f6f2615433a Author: tonyp Date: 2011-06-24 12:38 -0400 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/5f6f2615433a 7049999: G1: Make the G1PrintHeapRegions output consistent and complete Summary: Extend and make more consistent the output from the G1PrintHeapRegions flag. Reviewed-by: johnc, jmasa ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp + src/share/vm/gc_implementation/g1/g1HRPrinter.cpp + src/share/vm/gc_implementation/g1/g1HRPrinter.hpp Changeset: 04760e41b01e Author: brutisso Date: 2011-06-28 14:23 +0200 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/04760e41b01e 7016112: CMS: crash during promotion testing Summary: Also reviewed by mikael.gerdin at oracle.com; stdlib:qsort() does byte-by-byte swapping on Windows. This leads to pointer shearing. Fix is to implement a quicksort that does full pointer updates. Reviewed-by: never, coleenp, ysr ! src/share/vm/oops/methodOop.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/globals.hpp + src/share/vm/utilities/quickSort.cpp + src/share/vm/utilities/quickSort.hpp Changeset: 4bf3cbef0b3e Author: jcoomes Date: 2011-07-06 08:43 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/4bf3cbef0b3e Merge ! src/share/vm/oops/methodOop.cpp ! src/share/vm/runtime/globals.hpp Changeset: d83ac25d0304 Author: never Date: 2011-06-16 13:46 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/d83ac25d0304 7055355: JSR 292: crash while throwing WrongMethodTypeException Reviewed-by: jrose, twisti, bdelsart ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/sparc/vm/templateInterpreter_sparc.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/cpu/x86/vm/templateInterpreter_x86_64.cpp ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/interpreter/templateInterpreter.cpp ! src/share/vm/interpreter/templateInterpreterGenerator.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/runtime/sharedRuntime.hpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp Changeset: aacaff365100 Author: kvn Date: 2011-06-20 16:45 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/aacaff365100 7052494: Eclipse test fails on JDK 7 b142 Summary: Keep 'ne' test in Counted loop when we can't guarantee during compilation that init < limit. Reviewed-by: never ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.cpp + test/compiler/7052494/Test7052494.java Changeset: de6a837d75cf Author: never Date: 2011-06-21 09:04 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/de6a837d75cf 7056380: VM crashes with SIGSEGV in compiled code Summary: code was using andq reg, imm instead of addq addr, imm Reviewed-by: kvn, jrose, twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/x86_64.ad Changeset: aabf25fa3f05 Author: never Date: 2011-06-22 14:45 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/aabf25fa3f05 7057587: JSR 292 - crash with jruby in test/test_respond_to.rb Summary: don't skip receiver when GC'ing compiled invokedynamic callsites Reviewed-by: twisti, kvn, jrose ! src/share/vm/code/nmethod.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/doCall.cpp ! src/share/vm/opto/parse.hpp Changeset: ddd894528dbc Author: jrose Date: 2011-06-23 17:14 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/ddd894528dbc 7056328: JSR 292 invocation sometimes fails in adapters for types not on boot class path Reviewed-by: never ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciField.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethodHandle.cpp ! src/share/vm/ci/ciObjArrayKlass.cpp ! src/share/vm/ci/ciSignature.cpp ! src/share/vm/ci/ciSignature.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/oops/constantPoolOop.cpp ! src/share/vm/oops/constantPoolOop.hpp ! src/share/vm/oops/cpCacheOop.cpp ! src/share/vm/oops/cpCacheOop.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandleWalk.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp Changeset: 498c6cf70f7e Author: kvn Date: 2011-06-28 14:30 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/498c6cf70f7e 7058036: FieldsAllocationStyle=2 does not work in 32-bit VM Summary: parseClassFile() incorrectly uses nonstatic_oop_map_size() method instead of nonstatic_oop_map_count(). Reviewed-by: never Contributed-by: Krystal Mok ! src/share/vm/classfile/classFileParser.cpp Changeset: 6ae7a1561b53 Author: kvn Date: 2011-06-28 15:04 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/6ae7a1561b53 6990015: Incorrect Icache line size is used for 64 bit x86 Summary: correct Icache::line_size for x64 and add verification code into vm_version_x86. Reviewed-by: never, phh ! src/cpu/x86/vm/icache_x86.hpp ! src/cpu/x86/vm/vm_version_x86.cpp ! src/cpu/x86/vm/vm_version_x86.hpp Changeset: e3cbc9ddd434 Author: kvn Date: 2011-06-28 15:24 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/e3cbc9ddd434 7044738: Loop unroll optimization causes incorrect result Summary: take into account memory dependencies when clonning nodes in clone_up_backedge_goo(). Reviewed-by: never ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/macro.cpp ! src/share/vm/opto/node.cpp ! src/share/vm/opto/node.hpp + test/compiler/7044738/Test7044738.java + test/compiler/7046096/Test7046096.java Changeset: 7889bbcc7f88 Author: kvn Date: 2011-06-28 15:50 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/7889bbcc7f88 7047954: VM crashes with assert(is_Mem()) failed Summary: cast constant array ptrs to bottom Reviewed-by: never ! src/share/vm/opto/compile.cpp Changeset: 6f6e91603a45 Author: iveresov Date: 2011-07-01 10:35 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/6f6e91603a45 7058689: Tiered: Reprofiling doesn't happen in presence of level 4 OSR methods Summary: Take into account current state of profiling before believing that existing higher level versions are valid Reviewed-by: kvn, never ! src/share/vm/runtime/advancedThresholdPolicy.cpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp Changeset: 2c359f27615c Author: iveresov Date: 2011-07-01 10:37 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/2c359f27615c 7057120: Tiered: Allow C1 to inline methods with loops Summary: Recompile the enclosing methods without inlining of the method that has OSRed to level 4 or recompile the enclosing method at level 4. Reviewed-by: kvn, never ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/runtime/advancedThresholdPolicy.cpp ! src/share/vm/runtime/advancedThresholdPolicy.hpp ! src/share/vm/runtime/compilationPolicy.cpp ! src/share/vm/runtime/compilationPolicy.hpp ! src/share/vm/runtime/simpleThresholdPolicy.cpp ! src/share/vm/runtime/simpleThresholdPolicy.hpp Changeset: 15559220ce79 Author: never Date: 2011-07-05 16:07 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/15559220ce79 6478991: C1 NullCheckEliminator yields incorrect exceptions Reviewed-by: twisti, iveresov ! src/share/vm/c1/c1_Optimizer.cpp + test/compiler/6478991/NullCheckTest.java Changeset: fe240d87c6ec Author: never Date: 2011-07-06 09:27 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/fe240d87c6ec 7061101: adlc should complain about mixing block and expression forms of ins_encode Reviewed-by: kvn ! src/share/vm/adlc/adlparse.cpp Changeset: 3e23978ea0c3 Author: never Date: 2011-07-06 18:15 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/3e23978ea0c3 7062856: Disassembler needs to be smarter about finding hsdis after 1.7 launcher changes Summary: do explicit lookup emulating old LD_LIBRARY_PATH search Reviewed-by: kvn, jrose ! src/share/tools/hsdis/README ! src/share/vm/compiler/disassembler.cpp Changeset: b16582d6c7db Author: kvn Date: 2011-07-07 10:51 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/b16582d6c7db Merge ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/oops/methodOop.cpp Changeset: 7d9e451f5416 Author: jcoomes Date: 2011-07-06 12:03 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/7d9e451f5416 7061187: need some includes for arm/ppc Reviewed-by: dholmes, never, jwilhelm, kvn ! src/share/vm/opto/lcm.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/runtime/atomic.cpp Changeset: eb94b7226b7a Author: jcoomes Date: 2011-07-06 12:17 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/eb94b7226b7a 7061192: option handling adjustments for oracle and embedded builds Reviewed-by: dholmes, never, jwilhelm, kvn ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: 65dba8692db7 Author: jcoomes Date: 2011-07-06 12:22 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/65dba8692db7 7061197: ThreadLocalStorage sp map table should be optional Reviewed-by: dholmes, never, jwilhelm, kvn ! src/os_cpu/linux_x86/vm/assembler_linux_x86.cpp ! src/os_cpu/linux_x86/vm/threadLS_linux_x86.cpp ! src/os_cpu/linux_x86/vm/threadLS_linux_x86.hpp Changeset: 48048b59a551 Author: jcoomes Date: 2011-07-06 12:28 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/48048b59a551 7061204: clean the chunk table synchronously in embedded builds Reviewed-by: dholmes, never, jwilhelm, kvn ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/thread.cpp Changeset: bf6481e5f96d Author: jcoomes Date: 2011-07-06 13:02 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/bf6481e5f96d 7061225: os::print_cpu_info() should support os-specific data Reviewed-by: dholmes, never, jwilhelm, kvn ! src/os/linux/vm/os_linux.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/os.cpp ! src/share/vm/runtime/os.hpp Changeset: 8a4fc2990229 Author: jcoomes Date: 2011-07-07 15:44 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/8a4fc2990229 7053189: remove some unnecessary platform-dependent includes Reviewed-by: dholmes, never, jwilhelm, kvn ! src/share/vm/prims/jni.cpp ! src/share/vm/runtime/arguments.cpp Changeset: b0b8491925fe Author: jcoomes Date: 2011-07-11 14:15 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/b0b8491925fe 7061212: use o/s low memory notification in embedded builds Reviewed-by: dholmes, never, jwilhelm, kvn ! src/os/linux/vm/os_linux.cpp Changeset: 0defeba52583 Author: jcoomes Date: 2011-07-12 16:32 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/0defeba52583 Merge Changeset: faa472957b38 Author: kvn Date: 2011-07-08 09:38 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/faa472957b38 7059034: Use movxtod/movdtox on T4 Summary: Use new VIS3 mov instructions on T4 for move data between general and float registers. Reviewed-by: never, twisti ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/sparc/vm/vm_version_sparc.cpp ! src/share/vm/runtime/globals.hpp Changeset: 263247c478c5 Author: iveresov Date: 2011-07-08 15:33 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/263247c478c5 7058510: multinewarray with 6 dimensions uncommon traps in server compiler Summary: Pass arguments to runtime via java array for arrays with > 5 dimensions Reviewed-by: never, kvn, jrose, pbk ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp Changeset: 1f4f4ae84625 Author: kvn Date: 2011-07-13 10:48 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/1f4f4ae84625 Merge ! src/share/vm/runtime/globals.hpp Changeset: 3fbb609d9e96 Author: kvn Date: 2011-07-14 15:39 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/3fbb609d9e96 7067288: compiler regression test Test7052494 timeouts with client VM Summary: Test is modified to reduce number of iterations in test5() and test6(). Reviewed-by: never, iveresov ! test/compiler/7052494/Test7052494.java Changeset: 341a57af9b0a Author: never Date: 2011-07-15 15:35 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/341a57af9b0a 6990212: JSR 292 JVMTI MethodEnter hook is not called for JSR 292 bootstrap and target methods Summary: check for single stepping when dispatching invokes from method handles Reviewed-by: coleenp, twisti, kvn, dsamersoff ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.hpp ! src/cpu/x86/vm/interp_masm_x86_32.cpp ! src/cpu/x86/vm/interp_masm_x86_64.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.hpp + test/compiler/6990212/Test6990212.java Changeset: 968305b802ee Author: trims Date: 2011-07-23 01:56 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/968305b802ee Merge Changeset: 8e5d4aa73a8c Author: trims Date: 2011-07-22 23:47 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/8e5d4aa73a8c 7069176: Update the JDK version numbers in Hotspot for JDK 8 Summary: Change JDK_MINOR_VER and JDK_PREVIOUS_VERSION to reflect JDK8 values Reviewed-by: jcoomes ! make/hotspot_version Changeset: 0cc8a70952c3 Author: trims Date: 2011-07-22 23:42 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/hotspot/rev/0cc8a70952c3 7070061: Adjust Hotspot make/jprt.properties for new JDK8 settings Summary: Fix so the JPRT can build with -release jdk8 now Reviewed-by: ohair ! make/jprt.properties From lana.steuck at oracle.com Mon Aug 8 03:48:03 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Mon, 08 Aug 2011 03:48:03 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 20 new changesets Message-ID: <20110808035131.E8E39479FB@hg.openjdk.java.net> Changeset: 6444b0a364d7 Author: jrose Date: 2011-06-14 22:47 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/6444b0a364d7 7054590: (JSR-292) MethodHandleProxies.asInterfaceInstance() accepts private/protected nested interfaces Summary: fix non-compliant logic in MethodHandleProxies, fix invalid private classes in MethodHandlesTest Reviewed-by: twisti, never ! src/share/classes/java/lang/invoke/MethodHandleProxies.java ! test/java/lang/invoke/MethodHandlesTest.java Changeset: 5f3cd0cbad56 Author: jrose Date: 2011-07-13 01:40 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/5f3cd0cbad56 Merge - src/share/classes/sun/misc/JavaxSecurityAuthKerberosAccess.java - test/sun/security/ssl/com/sun/net/ssl/internal/ssl/InputRecord/InterruptedIO.java Changeset: bfc5ec581c48 Author: jrose Date: 2011-07-16 15:40 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/bfc5ec581c48 7058630: JSR 292 method handle proxy violates contract for Object methods Reviewed-by: never, twisti ! src/share/classes/java/lang/invoke/MethodHandleProxies.java ! test/java/lang/invoke/MethodHandlesTest.java Changeset: 668edf27e9c7 Author: jrose Date: 2011-07-16 15:44 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/668edf27e9c7 7058651: JSR 292 unit tests need a refresh Summary: Enhancements to unit tests. Reviewed-by: never, twisti ! test/java/lang/invoke/JavaDocExamplesTest.java ! test/java/lang/invoke/MethodHandlesTest.java ! test/java/lang/invoke/RicochetTest.java + test/java/lang/invoke/ThrowExceptionsTest.java Changeset: b42029cd1744 Author: jrose Date: 2011-07-16 15:47 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/b42029cd1744 6983728: JSR 292 remove argument count limitations Summary: Remove workarounds and limitations from before 6939861. Reviewed-by: never ! src/share/classes/java/lang/invoke/AdapterMethodHandle.java - src/share/classes/java/lang/invoke/FilterGeneric.java - src/share/classes/java/lang/invoke/FilterOneArgument.java - src/share/classes/java/lang/invoke/FromGeneric.java ! src/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/share/classes/java/lang/invoke/MethodHandleNatives.java ! src/share/classes/java/lang/invoke/MethodHandles.java ! src/share/classes/java/lang/invoke/MethodTypeForm.java - src/share/classes/java/lang/invoke/SpreadGeneric.java - src/share/classes/java/lang/invoke/ToGeneric.java Changeset: 0795f0dacfec Author: bagiras Date: 2011-07-11 15:59 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0795f0dacfec 7050935: closed/java/awt/Choice/WheelEventsConsumed/WheelEventsConsumed.html fails on win32 Reviewed-by: art, dcherepanov ! src/windows/native/sun/windows/awt_Choice.cpp ! src/windows/native/sun/windows/awt_Component.cpp ! src/windows/native/sun/windows/awt_Toolkit.cpp + test/java/awt/Choice/ChoiceMouseWheelTest/ChoiceMouseWheelTest.java Changeset: acea32663757 Author: peytoia Date: 2011-07-12 08:00 +0900 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/acea32663757 7042148: closed/java/awt/font/TextLayout/CheckLayoutLTR.java failed Reviewed-by: okutsu ! src/share/classes/sun/text/bidi/BidiBase.java + test/java/text/Bidi/Bug7042148.java Changeset: 75ee78eb7322 Author: peytoia Date: 2011-07-12 08:46 +0900 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/75ee78eb7322 7051769: java.text.Bidi.toString() output is wrong Reviewed-by: okutsu ! src/share/classes/sun/text/bidi/BidiBase.java + test/java/text/Bidi/Bug7051769.java Changeset: 6bc0e1709d97 Author: lana Date: 2011-07-11 16:54 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/6bc0e1709d97 Merge Changeset: cce5659427bb Author: rupashka Date: 2011-07-12 11:41 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/cce5659427bb 7019963: The goto parent directory button doesn't operate in JFileChooser Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java Changeset: 5c22624d193e Author: rupashka Date: 2011-07-15 14:43 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/5c22624d193e 4909150: WindowsTreeUI can cause NullPointerException occasionally Reviewed-by: alexp ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsTreeUI.java Changeset: 6ee24f03760d Author: serb Date: 2011-07-15 19:18 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/6ee24f03760d 7043679: Wrong class name is used in Java_sun_awt_windows_WPrinterJob_initIDs Reviewed-by: dav, art ! src/windows/native/sun/windows/awt_PrintJob.cpp Changeset: c90a43ebf8fd Author: serb Date: 2011-07-15 19:19 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c90a43ebf8fd 7043815: AWT-XAWT - AWT-EventQueue-0 deadlock. Reviewed-by: art, dcherepanov ! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java Changeset: 252f71b26b23 Author: serb Date: 2011-07-15 19:23 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/252f71b26b23 6596915: JCK-runtime-6a/tests/api/java_awt/Component/index.html tesPaintAll fails Reviewed-by: art, dcherepanov, anthony ! src/solaris/classes/sun/awt/X11/XButtonPeer.java ! src/solaris/classes/sun/awt/X11/XCheckboxPeer.java ! src/solaris/classes/sun/awt/X11/XChoicePeer.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XLabelPeer.java ! src/solaris/classes/sun/awt/X11/XListPeer.java ! src/solaris/classes/sun/awt/X11/XMenuBarPeer.java ! src/solaris/classes/sun/awt/X11/XMenuWindow.java ! src/solaris/classes/sun/awt/X11/XPanelPeer.java ! src/solaris/classes/sun/awt/X11/XRepaintArea.java ! src/solaris/classes/sun/awt/X11/XScrollPanePeer.java ! src/solaris/classes/sun/awt/X11/XScrollbarPeer.java ! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java ! src/solaris/classes/sun/awt/X11/XTextFieldPeer.java ! src/solaris/classes/sun/awt/X11/XWarningWindow.java ! src/solaris/classes/sun/awt/X11/XWindow.java + test/java/awt/Component/PaintAll/PaintAll.java Changeset: 3ed58dbad819 Author: serb Date: 2011-07-15 19:24 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/3ed58dbad819 6642728: Use reflection to access ScrollPane's private method from within sun.awt package Reviewed-by: art, anthony ! src/share/classes/java/awt/ScrollPaneAdjustable.java ! src/share/classes/sun/awt/AWTAccessor.java ! src/solaris/classes/sun/awt/X11/XScrollPanePeer.java ! src/windows/classes/sun/awt/windows/WScrollPanePeer.java ! src/windows/native/sun/windows/awt_ScrollPane.cpp Changeset: 9c642ae9a543 Author: serb Date: 2011-07-15 19:25 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/9c642ae9a543 4717864: setFont() does not update Fonts of Menus already on screen Reviewed-by: art, bagiras ! src/windows/classes/sun/awt/windows/WMenuItemPeer.java ! src/windows/native/sun/windows/awt_Menu.cpp ! src/windows/native/sun/windows/awt_Menu.h ! src/windows/native/sun/windows/awt_MenuBar.cpp ! src/windows/native/sun/windows/awt_MenuBar.h ! src/windows/native/sun/windows/awt_MenuItem.cpp ! src/windows/native/sun/windows/awt_MenuItem.h Changeset: 3ac81907aa7d Author: rupashka Date: 2011-07-18 17:40 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/3ac81907aa7d 6509273: Password in JPasswordField gets Printed in clear text Reviewed-by: alexp ! src/share/classes/sun/swing/text/TextComponentPrintable.java Changeset: c05b36e4749e Author: rupashka Date: 2011-07-18 18:21 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c05b36e4749e 7031941: Use generificated JComboBox and JList in core libraries Reviewed-by: alexp ! src/share/classes/com/sun/java/swing/plaf/motif/MotifFileChooserUI.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsFileChooserUI.java ! src/share/classes/javax/swing/plaf/basic/BasicComboPopup.java ! src/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java ! src/share/classes/javax/swing/text/html/FormView.java ! src/share/classes/javax/swing/text/html/HTMLDocument.java ! src/share/classes/javax/swing/text/html/HTMLWriter.java ! src/share/classes/javax/swing/text/html/OptionComboBoxModel.java ! src/share/classes/javax/swing/text/html/OptionListModel.java ! src/share/classes/sun/swing/FilePane.java ! src/share/classes/sun/swing/plaf/synth/SynthFileChooserUIImpl.java Changeset: 190b11164876 Author: lana Date: 2011-07-27 22:42 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/190b11164876 Merge Changeset: 996547848b00 Author: lana Date: 2011-08-01 17:40 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/996547848b00 Merge From Ulf.Zibis at gmx.de Tue Aug 9 21:34:25 2011 From: Ulf.Zibis at gmx.de (Ulf Zibis) Date: Tue, 09 Aug 2011 23:34:25 +0200 Subject: [OpenJDK 2D-Dev] Fwd: Re: Small patch for multi-catch :) In-Reply-To: References: <4E2AF3C2.5060609@oracle.com> <4E2B2CEB.30609@gmx.de> <4E2B46DD.70504@gmx.de> Message-ID: <4E41A7E1.4060807@gmx.de> Am 25.07.2011 12:27, schrieb Mario Torre: > 2011/7/24 Ulf Zibis: > >> In build b104 it's part of OpenJDK distribution. >> Just try it in your build. ;-) >> >> -Ulf >> > Well, not really, Ductus is not part of the Free Software verision > AFAIK, and this is what happens when I try to include it: > > ../../../src/share/classes/sun/dc/DuctusRenderingEngine.java:39: > error: package sun.dc.pr does not exist > import sun.dc.pr.Rasterizer; > ^ > ../../../src/share/classes/sun/dc/DuctusRenderingEngine.java:40: > error: package sun.dc.pr does not exist > import sun.dc.pr.PathStroker; > ^ > ../../../src/share/classes/sun/dc/DuctusRenderingEngine.java:41: > error: package sun.dc.pr does not exist > import sun.dc.pr.PathDasher; > ^ > ../../../src/share/classes/sun/dc/DuctusRenderingEngine.java:42: > error: package sun.dc.pr does not exist > import sun.dc.pr.PRException; > > What is available is the entry point, DuctusRenderingEngine itself, so > the RenderingEngine class would compile, but a full build would fail, > unless I'm really missing something obvious of course. OK, I understand. ... but I'm wondering, why the entry point, DuctusRenderingEngine itself, is part of the Free Software version? Sorry for the delay ... I was in holidays. -Ulf From philip.race at oracle.com Wed Aug 10 19:03:38 2011 From: philip.race at oracle.com (Phil Race) Date: Wed, 10 Aug 2011 12:03:38 -0700 Subject: [OpenJDK 2D-Dev] Turn on Xrender by default in JDK 8 Message-ID: <4E42D60A.2030909@oracle.com> Clemens, I think we should turn on Xrender by default in these early days in JDK 8 http://cr.openjdk.java.net/~prr/7077423/ The change itself is simple .. any concerns ? -phil. From neugens.limasoftware at gmail.com Wed Aug 10 20:36:42 2011 From: neugens.limasoftware at gmail.com (Mario Torre) Date: Wed, 10 Aug 2011 22:36:42 +0200 Subject: [OpenJDK 2D-Dev] Turn on Xrender by default in JDK 8 In-Reply-To: <4E42D60A.2030909@oracle.com> References: <4E42D60A.2030909@oracle.com> Message-ID: <1313008604.2762.12.camel@galactica> Il giorno mer, 10/08/2011 alle 12.03 -0700, Phil Race ha scritto: > Clemens, > > I think we should turn on Xrender by default in these early days in JDK 8 > http://cr.openjdk.java.net/~prr/7077423/ > > The change itself is simple .. any concerns ? > > -phil. Cool patch! I think the only problems may be in buggy drivers, but turning it on will give us a chance to test and resolve remaining issues, if any :) Cheers, Mario From linuxhippy at gmail.com Wed Aug 10 21:53:26 2011 From: linuxhippy at gmail.com (Clemens Eisserer) Date: Wed, 10 Aug 2011 23:53:26 +0200 Subject: [OpenJDK 2D-Dev] Turn on Xrender by default in JDK 8 In-Reply-To: <1313008604.2762.12.camel@galactica> References: <4E42D60A.2030909@oracle.com> <1313008604.2762.12.camel@galactica> Message-ID: Hi Phil, > I think we should turn on Xrender by default in these early days in JDK 8 > > http://cr.openjdk.java.net/~prr/7077423/ > I feared that day would come ... great :) I know of two more-than-minor bugs, however I haven't had the time to file reports: - Problems with SRC + alpha values when rendering to surfaces without alpha, this causes IntelliJ's editor to look garbled. - Somewhere coordinate overflows happen with very large JTables. I don't know if its ok to enable it anyway. I think the only problems may be in buggy drivers, but turning it on > will give us a chance to test and resolve remaining issues, if any :) > Currently shipping drivers are really all working very well, what could cause problems are probably archaic installations still running early versions of EXA or even XAA. Thanks, Clemens -------------- next part -------------- An HTML attachment was scrubbed... URL: From philip.race at oracle.com Thu Aug 11 00:35:11 2011 From: philip.race at oracle.com (Phil Race) Date: Wed, 10 Aug 2011 17:35:11 -0700 Subject: [OpenJDK 2D-Dev] Turn on Xrender by default in JDK 8 In-Reply-To: References: <4E42D60A.2030909@oracle.com> <1313008604.2762.12.camel@galactica> Message-ID: <4E4323BF.4070408@oracle.com> I think we will learn more by turning it on now, rather than after waiting to fix these problems at some future date. The users who hit those issues can turn off xrender, but at least we'll know who is hitting what. Then we can re-assess. I would appreciate it if you could file bugs on those issues. -phil. On 8/10/11 2:53 PM, Clemens Eisserer wrote: > Hi Phil, > > > I think we should turn on Xrender by default in these early days > in JDK 8 > > http://cr.openjdk.java.net/~prr/7077423/ > > > > I feared that day would come ... great :) > > I know of two more-than-minor bugs, however I haven't had the time to > file reports: > - Problems with SRC + alpha values when rendering to surfaces without > alpha, this causes IntelliJ's editor to look garbled. > - Somewhere coordinate overflows happen with very large JTables. > > I don't know if its ok to enable it anyway. > > I think the only problems may be in buggy drivers, but turning it on > will give us a chance to test and resolve remaining issues, if any :) > > > Currently shipping drivers are really all working very well, what > could cause problems are probably archaic installations still running > early versions of EXA or even XAA. > > Thanks, Clemens > > From philip.race at oracle.com Fri Aug 12 16:51:24 2011 From: philip.race at oracle.com (philip.race at oracle.com) Date: Fri, 12 Aug 2011 16:51:24 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 7077423: Enable Xrender by default Message-ID: <20110812165150.88DEE47B21@hg.openjdk.java.net> Changeset: 6664b47ddfd9 Author: prr Date: 2011-08-12 09:48 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/6664b47ddfd9 7077423: Enable Xrender by default Reviewed-by: bae, jgodinez, ceisserer ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java From james.graham at oracle.com Fri Aug 12 21:25:32 2011 From: james.graham at oracle.com (Jim Graham) Date: Fri, 12 Aug 2011 14:25:32 -0700 Subject: [OpenJDK 2D-Dev] Turn on Xrender by default in JDK 8 In-Reply-To: <4E42D60A.2030909@oracle.com> References: <4E42D60A.2030909@oracle.com> Message-ID: <4E459A4C.30607@oracle.com> You probably should have updated the verbose half of the tests while you were inverting the logic. It's only a debugging tool, but right now there is no way to verbosely turn it off like there used to be a way to verbosely turn it on. Now if someone uses "False" or "F" thinking that this will verbosely turn it off, they will have no effect... ...jim On 8/10/11 12:03 PM, Phil Race wrote: > Clemens, > > I think we should turn on Xrender by default in these early days in JDK 8 > http://cr.openjdk.java.net/~prr/7077423/ > > The change itself is simple .. any concerns ? > > -phil. > > From philip.race at oracle.com Fri Aug 12 22:08:11 2011 From: philip.race at oracle.com (Phil Race) Date: Fri, 12 Aug 2011 15:08:11 -0700 Subject: [OpenJDK 2D-Dev] Turn on Xrender by default in JDK 8 In-Reply-To: <4E459A4C.30607@oracle.com> References: <4E42D60A.2030909@oracle.com> <4E459A4C.30607@oracle.com> Message-ID: <4E45A44B.8000708@oracle.com> Yes, "False" is a no-op. You need "false" .. I did almost add "False" support, but I was thinking of it for printing a message that the pipeline is disabled, however so far as I could see, no pipeline prints anything for "False", even if it understands it, which may only have been the case on Windows, and all mis-spellings are silently ignored. Of course there's only so much we can do here. If the user mis-spells the system property for example, but I agree it would be nice to have some way to know that your request got through. I have a separate bug to clean up the pipeline verbose reporting, and update user docs. I'll revisit this then. -phil. On 8/12/11 2:25 PM, Jim Graham wrote: > You probably should have updated the verbose half of the tests while > you were inverting the logic. It's only a debugging tool, but right > now there is no way to verbosely turn it off like there used to be a > way to verbosely turn it on. Now if someone uses "False" or "F" > thinking that this will verbosely turn it off, they will have no > effect... > > ...jim > > On 8/10/11 12:03 PM, Phil Race wrote: >> Clemens, >> >> I think we should turn on Xrender by default in these early days in >> JDK 8 >> http://cr.openjdk.java.net/~prr/7077423/ >> >> The change itself is simple .. any concerns ? >> >> -phil. >> >> From james.graham at oracle.com Tue Aug 16 19:24:21 2011 From: james.graham at oracle.com (Jim Graham) Date: Tue, 16 Aug 2011 12:24:21 -0700 Subject: [OpenJDK 2D-Dev] Turn on Xrender by default in JDK 8 In-Reply-To: <4E45A44B.8000708@oracle.com> References: <4E42D60A.2030909@oracle.com> <4E459A4C.30607@oracle.com> <4E45A44B.8000708@oracle.com> Message-ID: <4E4AC3E5.6090400@oracle.com> We should normalize all of these via a helper function. All combinations of false, f, False, F, true, t, True, T should work for all boolean properties and the upper case versions should all be verbose. Arguably we could easily allow any number of letters (so that "fal" works) by just using the "startsWith()" method instead of a direct equals() comparison. Also, if they spell the property name correctly, but we don't recognize the value - shouldn't we print out a complaint? ...jim On 8/12/2011 3:08 PM, Phil Race wrote: > Yes, "False" is a no-op. You need "false" .. I did almost add "False" > support, > but I was thinking of it for printing a message that the pipeline is > disabled, > however so far as I could see, no pipeline prints anything for "False", > even > if it understands it, which may only have been the case on Windows, and > all mis-spellings are silently ignored. Of course there's only so much we > can do here. If the user mis-spells the system property for example, but > I agree it would be nice to have some way to know that your request got > through. > > I have a separate bug to clean up the pipeline verbose reporting, and > update user docs. I'll revisit this then. > > -phil. > > On 8/12/11 2:25 PM, Jim Graham wrote: >> You probably should have updated the verbose half of the tests while >> you were inverting the logic. It's only a debugging tool, but right >> now there is no way to verbosely turn it off like there used to be a >> way to verbosely turn it on. Now if someone uses "False" or "F" >> thinking that this will verbosely turn it off, they will have no >> effect... >> >> ...jim >> >> On 8/10/11 12:03 PM, Phil Race wrote: >>> Clemens, >>> >>> I think we should turn on Xrender by default in these early days in >>> JDK 8 >>> http://cr.openjdk.java.net/~prr/7077423/ >>> >>> The change itself is simple .. any concerns ? >>> >>> -phil. >>> >>> > From neugens.limasoftware at gmail.com Tue Aug 16 20:19:42 2011 From: neugens.limasoftware at gmail.com (Mario Torre) Date: Tue, 16 Aug 2011 22:19:42 +0200 Subject: [OpenJDK 2D-Dev] Turn on Xrender by default in JDK 8 In-Reply-To: <4E4AC3E5.6090400@oracle.com> References: <4E42D60A.2030909@oracle.com> <4E459A4C.30607@oracle.com> <4E45A44B.8000708@oracle.com> <4E4AC3E5.6090400@oracle.com> Message-ID: This sounds like a good idea. And if my memory is correct, some of them find their way though native code, so we should probably normalize those values as well for native code after they first got detected, so a common functions would be a nice thing to have. Cheers, Mario 2011/8/16 Jim Graham : > We should normalize all of these via a helper function. ?All combinations of > > ? ?false, f, False, F, true, t, True, T > > should work for all boolean properties and the upper case versions should > all be verbose. ?Arguably we could easily allow any number of letters (so > that "fal" works) by just using the "startsWith()" method instead of a > direct equals() comparison. > > Also, if they spell the property name correctly, but we don't recognize the > value - shouldn't we print out a complaint? > > ? ? ? ? ? ? ? ? ? ? ? ?...jim > > On 8/12/2011 3:08 PM, Phil Race wrote: >> >> Yes, "False" is a no-op. You need "false" .. I did almost add "False" >> support, >> but I was thinking of it for printing a message that the pipeline is >> disabled, >> however so far as I could see, no pipeline prints anything for "False", >> even >> if it understands it, which may only have been the case on Windows, and >> all mis-spellings are silently ignored. Of course there's only so much we >> can do here. If the user mis-spells the system property for example, but >> I agree it would be nice to have some way to know that your request got >> through. >> >> I have a separate bug to clean up the pipeline verbose reporting, and >> update user docs. I'll revisit this then. >> >> -phil. >> >> On 8/12/11 2:25 PM, Jim Graham wrote: >>> >>> You probably should have updated the verbose half of the tests while >>> you were inverting the logic. It's only a debugging tool, but right >>> now there is no way to verbosely turn it off like there used to be a >>> way to verbosely turn it on. Now if someone uses "False" or "F" >>> thinking that this will verbosely turn it off, they will have no >>> effect... >>> >>> ...jim >>> >>> On 8/10/11 12:03 PM, Phil Race wrote: >>>> >>>> Clemens, >>>> >>>> I think we should turn on Xrender by default in these early days in >>>> JDK 8 >>>> http://cr.openjdk.java.net/~prr/7077423/ >>>> >>>> The change itself is simple .. any concerns ? >>>> >>>> -phil. >>>> >>>> >> > -- pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF Fingerprint: BA39 9666 94EC 8B73 27FA? FC7C 4086 63E3 80F2 40CF IcedRobot: www.icedrobot.org Proud GNU Classpath developer: http://www.classpath.org/ Read About us at: http://planet.classpath.org OpenJDK: http://openjdk.java.net/projects/caciocavallo/ Please, support open standards: http://endsoftpatents.org/ From lana.steuck at oracle.com Thu Aug 18 07:56:18 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 18 Aug 2011 07:56:18 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d: 4 new changesets Message-ID: <20110818075619.2065747CD1@hg.openjdk.java.net> Changeset: 0b615980879e Author: jjg Date: 2011-06-30 16:51 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/rev/0b615980879e 7061195: Clean up makefiles for JDK 8 Reviewed-by: ohair, jjg Contributed-by: alexandre.boulgakov at oracle.com ! make/sanity-rules.gmk Changeset: 05e24d6ed56d Author: lana Date: 2011-07-14 18:56 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/rev/05e24d6ed56d Merge Changeset: fd8615098a54 Author: ohair Date: 2011-07-22 17:35 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/rev/fd8615098a54 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties Changeset: f42e3d9394b4 Author: ohair Date: 2011-07-22 21:31 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/rev/f42e3d9394b4 Merge From lana.steuck at oracle.com Thu Aug 18 07:56:20 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 18 Aug 2011 07:56:20 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/corba: 7069993: Adjust make/jprt.properties file for jdk8 Message-ID: <20110818075623.87CD047CD2@hg.openjdk.java.net> Changeset: 949fb60ca830 Author: ohair Date: 2011-07-22 17:34 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/corba/rev/949fb60ca830 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties From lana.steuck at oracle.com Thu Aug 18 07:56:27 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 18 Aug 2011 07:56:27 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jaxws: 7069993: Adjust make/jprt.properties file for jdk8 Message-ID: <20110818075627.19E8647CD3@hg.openjdk.java.net> Changeset: 64df57a1edec Author: ohair Date: 2011-07-22 17:35 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jaxws/rev/64df57a1edec 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties From lana.steuck at oracle.com Thu Aug 18 07:56:32 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 18 Aug 2011 07:56:32 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jaxp: 7069993: Adjust make/jprt.properties file for jdk8 Message-ID: <20110818075632.B0AAB47CD4@hg.openjdk.java.net> Changeset: 4f0fcb812767 Author: ohair Date: 2011-07-22 17:34 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jaxp/rev/4f0fcb812767 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties From lana.steuck at oracle.com Thu Aug 18 07:56:40 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 18 Aug 2011 07:56:40 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/langtools: 15 new changesets Message-ID: <20110818075714.DAF2847CD6@hg.openjdk.java.net> Changeset: b0909f992710 Author: ksrini Date: 2011-06-30 14:33 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/b0909f992710 7059905: (javadoc) promote method visibility for netbeans usage Reviewed-by: jjg, bpatel ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeDocImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationTypeElementDocImpl.java ! src/share/classes/com/sun/tools/javadoc/DocEnv.java ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/JavadocClassReader.java ! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java ! src/share/classes/com/sun/tools/javadoc/PackageDocImpl.java Changeset: 409b104f8b86 Author: ksrini Date: 2011-07-01 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/409b104f8b86 6735320: StringIndexOutOfBoundsException for empty @serialField tag Reviewed-by: jjg, bpatel ! src/share/classes/com/sun/tools/javadoc/SerialFieldTagImpl.java + test/com/sun/javadoc/T6735320/SerialFieldTest.java + test/com/sun/javadoc/T6735320/T6735320.java ! test/com/sun/javadoc/lib/JavadocTester.java Changeset: 0d8edba73d70 Author: ksrini Date: 2011-07-01 14:28 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/0d8edba73d70 7060642: (javadoc) improve performance on accessing inlinedTags Reviewed-by: jjg, bpatel ! src/share/classes/com/sun/tools/javadoc/ParamTagImpl.java ! src/share/classes/com/sun/tools/javadoc/ThrowsTagImpl.java Changeset: 111bbf1ad913 Author: darcy Date: 2011-07-05 16:37 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/111bbf1ad913 7025809: Provided new utility visitors supporting SourceVersion.RELEASE_8 Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java ! src/share/classes/com/sun/tools/javac/processing/PrintingProcessor.java ! src/share/classes/com/sun/tools/javah/JavahTask.java ! src/share/classes/com/sun/tools/javah/LLNI.java ! src/share/classes/com/sun/tools/javah/TypeSignature.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor7.java + src/share/classes/javax/lang/model/util/AbstractAnnotationValueVisitor8.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractElementVisitor7.java + src/share/classes/javax/lang/model/util/AbstractElementVisitor8.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor7.java + src/share/classes/javax/lang/model/util/AbstractTypeVisitor8.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor6.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor7.java + src/share/classes/javax/lang/model/util/ElementKindVisitor8.java ! src/share/classes/javax/lang/model/util/ElementScanner6.java ! src/share/classes/javax/lang/model/util/ElementScanner7.java + src/share/classes/javax/lang/model/util/ElementScanner8.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor7.java + src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor8.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor7.java + src/share/classes/javax/lang/model/util/SimpleElementVisitor8.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor7.java + src/share/classes/javax/lang/model/util/SimpleTypeVisitor8.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor6.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor7.java + src/share/classes/javax/lang/model/util/TypeKindVisitor8.java ! src/share/sample/javac/processing/src/CheckNamesProcessor.java ! test/tools/javac/6402516/CheckLocalElements.java ! test/tools/javac/api/TestOperators.java ! test/tools/javac/enum/6350057/T6350057.java ! test/tools/javac/enum/6424358/T6424358.java ! test/tools/javac/failover/FailOver15.out ! test/tools/javac/lib/JavacTestingAbstractProcessor.java ! test/tools/javac/multicatch/model/ModelChecker.java ! test/tools/javac/processing/model/6194785/T6194785.java ! test/tools/javac/processing/model/TestSymtabItems.java ! test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java ! test/tools/javac/processing/model/element/TestResourceVariable.java ! test/tools/javac/processing/model/type/NoTypes.java ! test/tools/javac/processing/model/type/TestUnionType.java ! test/tools/javac/processing/model/util/deprecation/TestDeprecation.java Changeset: 7337295434b6 Author: jjg Date: 2011-07-07 13:29 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/7337295434b6 7061125: Proposed javac argument processing performance improvement Reviewed-by: jjg, dlsmith, mcimadamore, forax Contributed-by: schlosna at gmail.com ! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! test/tools/javac/T6358166.java ! test/tools/javac/T6358168.java Changeset: 025a370b9fc3 Author: lana Date: 2011-07-14 18:58 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/025a370b9fc3 Merge Changeset: 2d3096441387 Author: ohair Date: 2011-07-22 17:35 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/2d3096441387 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties Changeset: 36f31b87b0ab Author: ohair Date: 2011-07-22 21:31 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/36f31b87b0ab Merge Changeset: 0b5beb9562c6 Author: mcimadamore Date: 2011-07-27 19:00 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/0b5beb9562c6 7062745: Regression: difference in overload resolution when two methods are maximally specific Summary: Fix most specific when two methods are maximally specific and only one has non-raw return type Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/generics/rawOverride/7062745/GenericOverrideTest.java + test/tools/javac/generics/rawOverride/7062745/T7062745neg.java + test/tools/javac/generics/rawOverride/7062745/T7062745neg.out + test/tools/javac/generics/rawOverride/7062745/T7062745pos.java Changeset: d5f33267a06d Author: mcimadamore Date: 2011-07-27 19:01 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/d5f33267a06d 7046778: Project Coin: problem with diamond and member inner classes Summary: Diamond inference generates spurious error messages when target type is a member inner class Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java + test/tools/javac/generics/diamond/7046778/DiamondAndInnerClassTest.java ! test/tools/javac/generics/diamond/neg/Neg09.out Changeset: e427c42e1a7e Author: mcimadamore Date: 2011-07-27 19:01 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/e427c42e1a7e 7057297: Project Coin: diamond erroneously accepts in array initializer expressions Summary: Diamond in array initializer expressions should be rejected Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/CannotCreateArrayWithDiamond.java + test/tools/javac/generics/diamond/7057297/T7057297.java + test/tools/javac/generics/diamond/7057297/T7057297.out Changeset: 0d6d41563040 Author: ksrini Date: 2011-07-27 11:53 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/0d6d41563040 7068902: (javac) allow enabling or disabling of String folding Summary: Contributed by netbeans team, modified to suit by the langtools team. Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/parser/StringFoldingTest.java Changeset: 64b9b7ae3366 Author: darcy Date: 2011-08-04 11:15 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/64b9b7ae3366 7071246: Enclosing string literal in parenthesis in switch-case crashes javac Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! test/tools/javac/StringsInSwitch/StringSwitches.java Changeset: c0d5f93af048 Author: jjg Date: 2011-08-05 15:57 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/c0d5f93af048 7074189: some javac tests fail with latest jtreg 4.1 b03 Reviewed-by: darcy + test/tools/javac/lib/CompileFail.java ! test/tools/javac/processing/errors/TestOptionSyntaxErrors.java ! test/tools/javac/processing/errors/TestReturnCode.java ! test/tools/javac/warnings/Serial.java Changeset: e9f118c2bd3c Author: ksrini Date: 2011-08-05 19:41 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/langtools/rev/e9f118c2bd3c 7064544: (javadoc) miscellaneous fixes requested by netbeans Summary: Contributed by netbeans team, modified to suit by the langtools team. Reviewed-by: jjg, bpatel ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/Comment.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! test/com/sun/javadoc/testLinkTaglet/TestLinkTaglet.java ! test/com/sun/javadoc/testLinkTaglet/pkg/C.java From lana.steuck at oracle.com Thu Aug 18 07:57:29 2011 From: lana.steuck at oracle.com (lana.steuck at oracle.com) Date: Thu, 18 Aug 2011 07:57:29 +0000 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 51 new changesets Message-ID: <20110818080616.B696747CDA@hg.openjdk.java.net> Changeset: 34fdcdb70d20 Author: rupashka Date: 2011-07-28 18:13 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/34fdcdb70d20 6995769: occasion NPE thrown from SwingUtilities.computeIntersection() Reviewed-by: alexp ! src/share/classes/javax/swing/RepaintManager.java Changeset: 86098b3f7789 Author: rupashka Date: 2011-07-28 18:24 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/86098b3f7789 7071166: LayoutStyle.getPreferredGap() - IAE is expected but not thrown Reviewed-by: peterz ! src/share/classes/sun/swing/DefaultLayoutStyle.java + test/javax/swing/GroupLayout/7071166/bug7071166.java Changeset: 0ce1f0b21446 Author: serb Date: 2011-08-01 17:05 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0ce1f0b21446 7068060: closed/java/awt/MenuBar/MenuBarSetFont/MenuBarSetFont.java failed on windows Reviewed-by: art, dcherepanov + test/java/awt/MenuBar/MenuBarSetFont/MenuBarSetFont.java Changeset: 854e74d8d956 Author: rupashka Date: 2011-08-03 16:59 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/854e74d8d956 7072328: Sun URL in the MetalLookAndFeel.getLayoutStyle() specification should be replaced with Oracle one Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java Changeset: 634c2a492cf5 Author: lana Date: 2011-08-05 15:35 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/634c2a492cf5 Merge - src/share/classes/java/lang/invoke/FilterGeneric.java - src/share/classes/java/lang/invoke/FilterOneArgument.java - src/share/classes/java/lang/invoke/FromGeneric.java - src/share/classes/java/lang/invoke/SpreadGeneric.java - src/share/classes/java/lang/invoke/ToGeneric.java Changeset: e4c936c28960 Author: jjg Date: 2011-06-30 16:48 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e4c936c28960 7061190: Update boot JDK version for JDK 8 Reviewed-by: ohair, jjg Contributed-by: alexandre.boulgakov at oracle.com ! make/common/shared/Defs-versions.gmk Changeset: cf4edfcd7119 Author: jjg Date: 2011-06-30 16:50 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/cf4edfcd7119 7061195: Clean up makefiles for JDK 8 Reviewed-by: ohair, jjg Contributed-by: alexandre.boulgakov at oracle.com ! make/common/shared/Defs-java.gmk Changeset: 74328e59a4bf Author: jjg Date: 2011-06-30 17:59 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/74328e59a4bf 7058708: Eliminate JDK build tools build warnings Reviewed-by: ohair, jjg Contributed-by: alexandre.boulgakov at oracle.com ! make/tools/Makefile ! make/tools/src/build/tools/buildmetaindex/BuildMetaIndex.java ! make/tools/src/build/tools/compileproperties/CompileProperties.java ! make/tools/src/build/tools/dirdiff/DirDiff.java ! make/tools/src/build/tools/dtdbuilder/DTDBuilder.java ! make/tools/src/build/tools/dtdbuilder/DTDInputStream.java ! make/tools/src/build/tools/dtdbuilder/DTDParser.java ! make/tools/src/build/tools/dtdbuilder/PublicMapping.java ! make/tools/src/build/tools/generatebreakiteratordata/CharSet.java ! make/tools/src/build/tools/generatebreakiteratordata/DictionaryBasedBreakIteratorBuilder.java ! make/tools/src/build/tools/generatebreakiteratordata/GenerateBreakIteratorData.java ! make/tools/src/build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java ! make/tools/src/build/tools/generatebreakiteratordata/SupplementaryCharacterData.java ! make/tools/src/build/tools/generatecharacter/GenerateCharacter.java ! make/tools/src/build/tools/generatecharacter/SpecialCaseMap.java ! make/tools/src/build/tools/generatecharacter/UnicodeSpec.java ! make/tools/src/build/tools/generatecurrencydata/GenerateCurrencyData.java ! make/tools/src/build/tools/hasher/Hasher.java ! make/tools/src/build/tools/jarsplit/JarSplit.java ! make/tools/src/build/tools/javazic/Gen.java ! make/tools/src/build/tools/javazic/GenDoc.java ! make/tools/src/build/tools/javazic/Main.java ! make/tools/src/build/tools/javazic/Mappings.java ! make/tools/src/build/tools/javazic/Simple.java ! make/tools/src/build/tools/javazic/Time.java ! make/tools/src/build/tools/javazic/Zoneinfo.java ! make/tools/src/build/tools/jdwpgen/AbstractCommandNode.java ! make/tools/src/build/tools/jdwpgen/AbstractGroupNode.java ! make/tools/src/build/tools/jdwpgen/AbstractNamedNode.java ! make/tools/src/build/tools/jdwpgen/AbstractTypeListNode.java ! make/tools/src/build/tools/jdwpgen/AltNode.java ! make/tools/src/build/tools/jdwpgen/CommandSetNode.java ! make/tools/src/build/tools/jdwpgen/ConstantSetNode.java ! make/tools/src/build/tools/jdwpgen/ErrorSetNode.java ! make/tools/src/build/tools/jdwpgen/Node.java ! make/tools/src/build/tools/jdwpgen/OutNode.java ! make/tools/src/build/tools/jdwpgen/RootNode.java ! make/tools/src/build/tools/jdwpgen/SelectNode.java ! make/tools/src/build/tools/makeclasslist/MakeClasslist.java ! make/tools/src/build/tools/stripproperties/StripProperties.java Changeset: e93679cf1e1a Author: valeriep Date: 2011-06-30 18:42 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e93679cf1e1a 7058133: Javah should use the freshly built classes instead of those from the BOOTDIR jdk Summary: Changed javah to use the newly built classes specified by $(CLASSDESTDIR) Reviewed-by: vinnie ! make/sun/security/ec/Makefile ! make/sun/security/mscapi/Makefile Changeset: f0ec49c21d09 Author: valeriep Date: 2011-07-01 17:12 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f0ec49c21d09 Merge Changeset: e88093d75e36 Author: coffeys Date: 2011-07-05 15:25 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e88093d75e36 7041125: LDAP API does not catch malformed filters that contain two operands for the ! operator Reviewed-by: weijun, xuelei ! src/share/classes/com/sun/jndi/ldap/Filter.java ! test/com/sun/jndi/ldap/InvalidLdapFilters.java Changeset: f68d30c0a2e3 Author: mullan Date: 2011-07-06 11:08 -0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f68d30c0a2e3 7054969: Null-check-in-finally pattern in java/security documentation Reviewed-by: vinnie ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/cert/X509CRL.java ! src/share/classes/java/security/cert/X509Certificate.java ! src/share/classes/java/security/cert/X509Extension.java Changeset: 63be90976177 Author: ksrini Date: 2011-07-08 10:25 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/63be90976177 7060849: Eliminate pack200 build warnings Reviewed-by: ksrini, jjg Contributed-by: alexandre.boulgakov at oracle.com ! make/com/sun/java/pack/Makefile ! make/common/shared/Defs-java.gmk ! src/share/classes/com/sun/java/util/jar/pack/Attribute.java ! src/share/classes/com/sun/java/util/jar/pack/BandStructure.java ! src/share/classes/com/sun/java/util/jar/pack/ClassReader.java ! src/share/classes/com/sun/java/util/jar/pack/ClassWriter.java ! src/share/classes/com/sun/java/util/jar/pack/Code.java ! src/share/classes/com/sun/java/util/jar/pack/Coding.java ! src/share/classes/com/sun/java/util/jar/pack/ConstantPool.java ! src/share/classes/com/sun/java/util/jar/pack/Constants.java ! src/share/classes/com/sun/java/util/jar/pack/Fixups.java ! src/share/classes/com/sun/java/util/jar/pack/Instruction.java ! src/share/classes/com/sun/java/util/jar/pack/NativeUnpack.java ! src/share/classes/com/sun/java/util/jar/pack/Package.java ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/classes/com/sun/java/util/jar/pack/PackerImpl.java ! src/share/classes/com/sun/java/util/jar/pack/PropMap.java ! src/share/classes/com/sun/java/util/jar/pack/TLGlobals.java ! src/share/classes/com/sun/java/util/jar/pack/UnpackerImpl.java ! src/share/classes/com/sun/java/util/jar/pack/Utils.java Changeset: 5adf431673ac Author: peytoia Date: 2011-07-12 07:32 +0900 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/5adf431673ac 7012364: test/java/util/Locale/LocaleCategory.sh fails on Cygwin Reviewed-by: okutsu ! test/java/util/Locale/LocaleCategory.sh Changeset: 549b7c3f0bdc Author: dl Date: 2011-07-12 15:23 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/549b7c3f0bdc 7058828: test/java/util/concurrent/Phaser/Arrive.java fails intermittently Reviewed-by: chegar ! test/java/util/concurrent/Phaser/Arrive.java Changeset: 42fe05e54e69 Author: naoto Date: 2011-07-12 10:28 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/42fe05e54e69 7022407: Spinning CPU in LocaleObjectCache.get() Reviewed-by: okutsu ! src/share/classes/sun/util/locale/LocaleObjectCache.java Changeset: db419c454f92 Author: dl Date: 2011-07-13 12:24 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/db419c454f92 7057320: test/java/util/concurrent/Executors/AutoShutdown.java failing intermittently Summary: Add retry/timeout for checking activeCount Reviewed-by: chegar ! test/java/util/concurrent/Executors/AutoShutdown.java Changeset: 7ac6a297f9a0 Author: lana Date: 2011-07-14 18:57 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/7ac6a297f9a0 Merge Changeset: c0c983ca797b Author: ksrini Date: 2011-07-15 16:38 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c0c983ca797b 7062969: java -help still shows http://java.sun.com/javase/reference Reviewed-by: ohair, darcy ! src/share/classes/sun/launcher/resources/launcher.properties Changeset: d987f8738096 Author: darcy Date: 2011-07-17 18:53 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/d987f8738096 7062430: Minor inconsistency in ulp descriptions Reviewed-by: smarks, alanb ! src/share/classes/java/lang/Math.java ! src/share/classes/java/lang/StrictMath.java Changeset: cbfc7f910af3 Author: alanb Date: 2011-07-18 13:10 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/cbfc7f910af3 7068059: Update jdk/test/ProblemList.txt Reviewed-by: mchung, chegar ! test/ProblemList.txt Changeset: 8bbea505b060 Author: chegar Date: 2011-07-18 22:25 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/8bbea505b060 7021280: SocketPermission should accept wildcards Reviewed-by: michaelm ! src/share/classes/java/net/SocketPermission.java + test/java/net/SocketPermission/Wildcard.java Changeset: 5355b9ccd19d Author: xuelei Date: 2011-07-19 08:21 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/5355b9ccd19d 7059709: close the IO in a final block Reviewed-by: smarks, mullan, wetmore ! src/share/classes/sun/security/ssl/SSLContextImpl.java ! src/share/classes/sun/security/ssl/TrustManagerFactoryImpl.java Changeset: d17eb3380a49 Author: ksrini Date: 2011-07-19 10:58 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/d17eb3380a49 7067922: (launcher) java -jar throws NPE if JAR file does not contain Main-Class attribute Reviewed-by: darcy, ohair, alanb, mduigou ! src/share/classes/sun/launcher/LauncherHelper.java ! test/tools/launcher/Arrrghs.java ! test/tools/launcher/TestHelper.java Changeset: d083644bc615 Author: darcy Date: 2011-07-19 17:45 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/d083644bc615 7007535: (reflect) Please generalize Constructor and Method Reviewed-by: mduigou, peterjones, dholmes, andrew ! src/share/classes/java/lang/reflect/Constructor.java + src/share/classes/java/lang/reflect/Executable.java ! src/share/classes/java/lang/reflect/Method.java Changeset: 99dc852080e1 Author: xuelei Date: 2011-07-19 21:47 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/99dc852080e1 7065972: Some race condition may happen in SSLSocketImpl class Reviewed-by: wetmore, weijun, dgu ! src/share/classes/sun/security/ssl/SSLSocketImpl.java Changeset: 9505edecc8b5 Author: jjg Date: 2011-07-20 12:19 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/9505edecc8b5 7068617: Core libraries don't build with javac -Xlint:all -Werror Reviewed-by: darcy Contributed-by: alexandre.boulgakov at oracle.com ! make/java/java/Makefile ! src/share/classes/sun/reflect/generics/reflectiveObjects/NotImplementedException.java ! src/share/classes/sun/reflect/misc/ConstructorUtil.java ! src/share/classes/sun/reflect/misc/FieldUtil.java ! src/share/classes/sun/reflect/misc/MethodUtil.java ! src/share/classes/sun/reflect/misc/ReflectUtil.java Changeset: 70ec3aa8e99a Author: chegar Date: 2011-07-21 17:28 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/70ec3aa8e99a 7068416: Lightweight HTTP Server should support TCP_NODELAY Reviewed-by: alanb, michaelm ! src/share/classes/sun/net/httpserver/ServerConfig.java ! src/share/classes/sun/net/httpserver/ServerImpl.java ! test/com/sun/net/httpserver/Test1.java Changeset: c8dbb9e19355 Author: weijun Date: 2011-07-22 10:25 +0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c8dbb9e19355 6330275: Rework the PaddingTest regression test. Reviewed-by: wetmore, smarks ! test/ProblemList.txt ! test/com/sun/crypto/provider/Cipher/DES/PaddingTest.java Changeset: 0ec4b6498a69 Author: ohair Date: 2011-07-22 17:35 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0ec4b6498a69 7069993: Adjust make/jprt.properties file for jdk8 Reviewed-by: katleman ! make/jprt.properties Changeset: a499fdfbe723 Author: ohair Date: 2011-07-22 21:31 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a499fdfbe723 Merge Changeset: 07a12583d4ea Author: chegar Date: 2011-07-25 14:35 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/07a12583d4ea 7035556: DatagramSocket.java:183: warning: unreachable catch clause Summary: Remove redundant catches in bind Reviewed-by: alanb, michaelm, wetmore, chegar Contributed-by: kurchi.subhra.hazra at oracle.com ! src/share/classes/java/net/DatagramSocket.java Changeset: c563e8060adf Author: jjg Date: 2011-07-25 16:20 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/c563e8060adf 7069870: Parts of the JDK erroneously rely on generic array initializers with diamond Reviewed-by: ksrini, mcimadamore Contributed-by: alexandre.boulgakov at oracle.com ! make/tools/src/build/tools/jarsplit/JarSplit.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java Changeset: a80562f7ea50 Author: chegar Date: 2011-07-27 18:10 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a80562f7ea50 6670868: StackOverFlow with bad authenticated Proxy tunnels Reviewed-by: michaelm ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/HttpsProxyStackOverflow.java Changeset: 7525866a4046 Author: jjg Date: 2011-07-28 13:34 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/7525866a4046 7068616: NIO libraries do not build with javac -Xlint:all,-deprecation -Werror Reviewed-by: alanb, chegar Contributed-by: alexandre.boulgakov at oracle.com ! make/com/sun/nio/Makefile ! make/com/sun/nio/sctp/Makefile ! make/java/nio/Makefile ! make/java/sun_nio/Makefile ! make/sun/nio/Makefile ! make/sun/nio/cs/Makefile ! src/share/classes/java/nio/X-Buffer.java.template ! src/share/classes/java/nio/channels/AsynchronousFileChannel.java ! src/share/classes/java/nio/channels/FileChannel.java ! src/share/classes/java/nio/charset/Charset.java ! src/share/classes/sun/nio/ch/DatagramSocketAdaptor.java ! src/share/classes/sun/nio/ch/Reflect.java ! src/share/classes/sun/nio/ch/SelectorImpl.java ! src/share/classes/sun/nio/ch/Util.java ! src/share/classes/sun/nio/cs/FastCharsetProvider.java ! src/share/classes/sun/nio/cs/StreamDecoder.java ! src/share/classes/sun/nio/cs/ThreadLocalCoders.java ! src/share/classes/sun/nio/fs/Util.java ! src/solaris/classes/sun/nio/ch/SctpChannelImpl.java ! src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java ! src/solaris/classes/sun/nio/ch/SctpNet.java ! src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java ! src/windows/classes/sun/nio/ch/PendingIoCache.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.java Changeset: cea7c749f805 Author: xuelei Date: 2011-07-29 02:50 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/cea7c749f805 7068662: Reserve and restore the default locale Reviewed-by: alanb, weijun ! test/com/sun/org/apache/xml/internal/security/exceptions/LocaleTest.java ! test/java/beans/XMLDecoder/Test6341798.java ! test/java/io/pathNames/win32/bug6344646.java ! test/java/net/CookieHandler/B6791927.java ! test/java/net/URLConnection/SetIfModifiedSince.java ! test/java/util/Locale/LocaleCategory.java ! test/java/util/PluggableLocale/CurrencyNameProviderTest.java ! test/java/util/PluggableLocale/TimeZoneNameProviderTest.java ! test/java/util/ResourceBundle/Bug6190861.java ! test/java/util/ResourceBundle/Control/Bug6530694.java ! test/java/util/ResourceBundle/Control/StressTest.java ! test/java/util/ResourceBundle/Test4314141.java ! test/java/util/ResourceBundle/Test4318520.java ! test/java/util/jar/JarFile/TurkCert.java ! test/javax/crypto/Cipher/Turkish.java ! test/javax/swing/JColorChooser/Test6524757.java ! test/sun/security/tools/keytool/KeyToolTest.java ! test/sun/text/resources/Collator/Bug4248694.java ! test/sun/text/resources/Collator/Bug4804273.java ! test/sun/text/resources/Collator/Bug4848897.java ! test/sun/text/resources/Format/Bug4651568.java ! test/sun/util/resources/Locale/Bug4965260.java ! test/sun/util/resources/TimeZone/Bug4640234.java Changeset: 4030297803eb Author: jjg Date: 2011-07-29 16:45 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/4030297803eb 7072523: java.math should be built with javac -Xlint:all -Werror Reviewed-by: darcy Contributed-by: alexandre.boulgakov at oracle.com ! make/java/math/Makefile Changeset: 809e8db0c142 Author: chegar Date: 2011-07-29 10:55 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/809e8db0c142 6978200: ServerSocket.toString include "port=0" in the returned String Summary: Removal of "port=0" from ServerSocket.toString method Reviewed-by: alanb, chegar Contributed-by: kurchi.subhra.hazra at oracle.com ! src/share/classes/java/net/ServerSocket.java Changeset: e68db408d08c Author: weijun Date: 2011-08-04 18:18 +0800 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e68db408d08c 7061379: [Kerberos] Cross-realm authentication fails, due to nameType problem Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/PrincipalName.java ! test/sun/security/krb5/auto/KDC.java + test/sun/security/krb5/auto/PrincipalNameEquals.java Changeset: 565555e89034 Author: mduigou Date: 2011-08-04 08:53 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/565555e89034 7073296: Executable.equalParamTypes() incorrectly returns true when the number of params differs. Reviewed-by: alanb, darcy ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/reflect/Executable.java + test/java/lang/reflect/Constructor/Equals.java Changeset: b9fffbe98230 Author: darcy Date: 2011-08-06 14:35 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/b9fffbe98230 7075098: Remove unused fdlibm files Reviewed-by: alanb, mduigou ! make/java/fdlibm/FILES_c.gmk ! src/share/native/java/lang/fdlibm/include/fdlibm.h ! src/share/native/java/lang/fdlibm/include/jfdlibm.h - src/share/native/java/lang/fdlibm/src/e_acosh.c - src/share/native/java/lang/fdlibm/src/e_gamma.c - src/share/native/java/lang/fdlibm/src/e_gamma_r.c - src/share/native/java/lang/fdlibm/src/e_j0.c - src/share/native/java/lang/fdlibm/src/e_j1.c - src/share/native/java/lang/fdlibm/src/e_jn.c - src/share/native/java/lang/fdlibm/src/e_lgamma.c - src/share/native/java/lang/fdlibm/src/e_lgamma_r.c - src/share/native/java/lang/fdlibm/src/s_asinh.c - src/share/native/java/lang/fdlibm/src/s_erf.c - src/share/native/java/lang/fdlibm/src/w_acosh.c - src/share/native/java/lang/fdlibm/src/w_gamma.c - src/share/native/java/lang/fdlibm/src/w_gamma_r.c - src/share/native/java/lang/fdlibm/src/w_j0.c - src/share/native/java/lang/fdlibm/src/w_j1.c - src/share/native/java/lang/fdlibm/src/w_jn.c - src/share/native/java/lang/fdlibm/src/w_lgamma.c - src/share/native/java/lang/fdlibm/src/w_lgamma_r.c Changeset: 3f3a59423a7e Author: lana Date: 2011-08-05 16:03 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/3f3a59423a7e Merge - src/share/classes/java/lang/invoke/FilterGeneric.java - src/share/classes/java/lang/invoke/FilterOneArgument.java - src/share/classes/java/lang/invoke/FromGeneric.java - src/share/classes/java/lang/invoke/SpreadGeneric.java - src/share/classes/java/lang/invoke/ToGeneric.java Changeset: a5f825ef8587 Author: lana Date: 2011-08-07 17:03 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/a5f825ef8587 Merge - src/share/native/java/lang/fdlibm/src/e_acosh.c - src/share/native/java/lang/fdlibm/src/e_gamma.c - src/share/native/java/lang/fdlibm/src/e_gamma_r.c - src/share/native/java/lang/fdlibm/src/e_j0.c - src/share/native/java/lang/fdlibm/src/e_j1.c - src/share/native/java/lang/fdlibm/src/e_jn.c - src/share/native/java/lang/fdlibm/src/e_lgamma.c - src/share/native/java/lang/fdlibm/src/e_lgamma_r.c - src/share/native/java/lang/fdlibm/src/s_asinh.c - src/share/native/java/lang/fdlibm/src/s_erf.c - src/share/native/java/lang/fdlibm/src/w_acosh.c - src/share/native/java/lang/fdlibm/src/w_gamma.c - src/share/native/java/lang/fdlibm/src/w_gamma_r.c - src/share/native/java/lang/fdlibm/src/w_j0.c - src/share/native/java/lang/fdlibm/src/w_j1.c - src/share/native/java/lang/fdlibm/src/w_jn.c - src/share/native/java/lang/fdlibm/src/w_lgamma.c - src/share/native/java/lang/fdlibm/src/w_lgamma_r.c Changeset: 94934ebbb654 Author: alanb Date: 2011-08-08 13:20 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/94934ebbb654 7076215: (jli) jdk/src/share/bin/jli_util.h should include function prototypes for str functions Reviewed-by: alanb Contributed-by: neil.richards at ngmr.net ! src/share/bin/jli_util.h Changeset: d4ab25d65adb Author: darcy Date: 2011-08-08 09:07 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/d4ab25d65adb 6380161: (reflect) Exception from newInstance() not chained to cause. Reviewed-by: dholmes, lancea, forax ! src/share/classes/java/lang/Class.java Changeset: 0f1b4b3bc833 Author: mchung Date: 2011-08-08 16:26 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0f1b4b3bc833 7036518: TEST_BUG: add cygwin support to test/java/nio/charset/coders/CheckSJISMappingProp.sh 7036519: TEST_BUG: add cygwin support to test/demo/zipfs/basic.sh Reviewed-by: sherman ! test/demo/zipfs/basic.sh ! test/java/nio/charset/coders/CheckSJISMappingProp.sh Changeset: 39498fc31d63 Author: mchung Date: 2011-08-08 16:27 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/39498fc31d63 7012365: TEST_BUG: test/java/nio/charset/spi/basic.sh can be run with Cygwin Reviewed-by: darcy ! test/java/nio/charset/spi/basic.sh Changeset: 26fe74aa48ef Author: chegar Date: 2011-08-09 16:39 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/26fe74aa48ef 7073295: TEST_BUG: test/java/lang/instrument/ManifestTest.sh causing havoc (win) Reviewed-by: mchung ! test/java/lang/instrument/ManifestTest.sh Changeset: cf203f293b4e Author: chegar Date: 2011-08-09 16:59 +0100 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/cf203f293b4e 7076756: TEST_BUG: com/sun/jdi/BreakpointWithFullGC.sh fails to cleanup in Cygwin Reviewed-by: alanb, dcubed ! test/com/sun/jdi/ShellScaffold.sh Changeset: 2cdbbc4a6359 Author: lana Date: 2011-08-09 17:38 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/2cdbbc4a6359 Merge - src/share/native/java/lang/fdlibm/src/e_acosh.c - src/share/native/java/lang/fdlibm/src/e_gamma.c - src/share/native/java/lang/fdlibm/src/e_gamma_r.c - src/share/native/java/lang/fdlibm/src/e_j0.c - src/share/native/java/lang/fdlibm/src/e_j1.c - src/share/native/java/lang/fdlibm/src/e_jn.c - src/share/native/java/lang/fdlibm/src/e_lgamma.c - src/share/native/java/lang/fdlibm/src/e_lgamma_r.c - src/share/native/java/lang/fdlibm/src/s_asinh.c - src/share/native/java/lang/fdlibm/src/s_erf.c - src/share/native/java/lang/fdlibm/src/w_acosh.c - src/share/native/java/lang/fdlibm/src/w_gamma.c - src/share/native/java/lang/fdlibm/src/w_gamma_r.c - src/share/native/java/lang/fdlibm/src/w_j0.c - src/share/native/java/lang/fdlibm/src/w_j1.c - src/share/native/java/lang/fdlibm/src/w_jn.c - src/share/native/java/lang/fdlibm/src/w_lgamma.c - src/share/native/java/lang/fdlibm/src/w_lgamma_r.c Changeset: f372807e122b Author: lana Date: 2011-08-17 22:47 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/f372807e122b Merge - src/share/native/java/lang/fdlibm/src/e_acosh.c - src/share/native/java/lang/fdlibm/src/e_gamma.c - src/share/native/java/lang/fdlibm/src/e_gamma_r.c - src/share/native/java/lang/fdlibm/src/e_j0.c - src/share/native/java/lang/fdlibm/src/e_j1.c - src/share/native/java/lang/fdlibm/src/e_jn.c - src/share/native/java/lang/fdlibm/src/e_lgamma.c - src/share/native/java/lang/fdlibm/src/e_lgamma_r.c - src/share/native/java/lang/fdlibm/src/s_asinh.c - src/share/native/java/lang/fdlibm/src/s_erf.c - src/share/native/java/lang/fdlibm/src/w_acosh.c - src/share/native/java/lang/fdlibm/src/w_gamma.c - src/share/native/java/lang/fdlibm/src/w_gamma_r.c - src/share/native/java/lang/fdlibm/src/w_j0.c - src/share/native/java/lang/fdlibm/src/w_j1.c - src/share/native/java/lang/fdlibm/src/w_jn.c - src/share/native/java/lang/fdlibm/src/w_lgamma.c - src/share/native/java/lang/fdlibm/src/w_lgamma_r.c From neugens.limasoftware at gmail.com Thu Aug 18 11:35:17 2011 From: neugens.limasoftware at gmail.com (=?utf-8?B?bmV1Z2Vucy5saW1hc29mdHdhcmVAZ21haWwuY29t?=) Date: Thu, 18 Aug 2011 13:35:17 +0200 Subject: [OpenJDK 2D-Dev] =?utf-8?q?hg=3A_jdk8/2d/jdk=3A_51_new_changesets?= Message-ID: <4e4cf902.15c7e30a.6549.663d@mx.google.com> 6995769: occasion NPE thrown from SwingUtilities.computeIntersection() Reviewed-by: alexp ! src/share/classes/javax/swing/RepaintManager.java I thought we decided for this fix to not be correct, or am I missing something? Mario -- Sent from HTC Desire... pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF http://www.icedrobot.org Proud GNU Classpath developer: http://www.classpath.org/ Read About us at: http://planet.classpath.org OpenJDK: http://openjdk.java.net/projects/caciocavallo/ Please, support open standards: http://endsoftpatents.org/ ----- Reply message ----- Da: lana.steuck at oracle.com Data: gio, ago 18, 2011 09:57 Oggetto: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 51 new changesets A: , <2d-dev at openjdk.java.net> Changeset: 34fdcdb70d20 Author: rupashka Date: 2011-07-28 18:13 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/34fdcdb70d20 6995769: occasion NPE thrown from SwingUtilities.computeIntersection() Reviewed-by: alexp ! src/share/classes/javax/swing/RepaintManager.java Changeset: 86098b3f7789 Author: rupashka Date: 2011-07-28 18:24 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/86098b3f7789 7071166: LayoutStyle.getPreferredGap() - IAE is expected but not thrown Reviewed-by: peterz ! src/share/classes/sun/swing/DefaultLayoutStyle.java + test/javax/swing/GroupLayout/7071166/bug7071166.java Changeset: 0ce1f0b21446 Author: serb Date: 2011-08-01 17:05 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/0ce1f0b21446 7068060: closed/java/awt/MenuBar/MenuBarSetFont/MenuBarSetFont.java failed on windows Reviewed-by: art, dcherepanov + test/java/awt/MenuBar/MenuBarSetFont/MenuBarSetFont.java Changeset: 854e74d8d956 Author: rupashka Date: 2011-08-03 16:59 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/854e74d8d956 7072328: Sun URL in the MetalLookAndFeel.getLayoutStyle() specification should be replaced with Oracle one Reviewed-by: peterz ! src/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java Changeset: 634c2a492cf5 Author: lana Date: 2011-08-05 15:35 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/634c2a492cf5 Merge - src/share/classes/java/lang/invoke/FilterGeneric.java - src/share/classes/java/lang/invoke/FilterOneArgument.java - src/share/classes/java/lang/invoke/FromGeneric.java - src/share/classes/java/lang/invoke/SpreadGeneric.java - src/share/classes/java/lang/invoke/ToGeneric.java Changeset: e4c936c28960 Author: jjg Date: 2011-06-30 16:48 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/e4c936c28960 7061190: Update boot JDK version for JDK 8 Reviewed-by: ohair, jjg Contributed-by: alexandre.boulgakov at oracle.com ! make/common/shared/Defs-versions.gmk Changeset: cf4edfcd7119 Author: jjg Date: 2011-06-30 16:50 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/cf4edfcd7119 7061195: Clean up makefiles for JDK 8 Reviewed-by: ohair, jjg Contributed-by: alexandre.boulgakov at oracle.com ! make/common/shared/Defs-java.gmk Changeset: 74328e59a4bf Author: jjg Date: 2011-06-30 17:59 -0700 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/74328e59a4bf 7058708: Eliminate JDK build tools build warnings Reviewed-by: ohair, jjg Contributed-by: alexandre.boulgakov at oracle.com ! make/tools/Makefile ! make/tools/src/build/tools/buildmetaindex/BuildMetaIndex.java ! make/tools/src/build/tools/compileproperties/CompileProperties.java ! make/tools/src/build/tools/dirdiff/DirDiff.java ! make/tools/src/build/tools/dtdbuilder/DTDBuilder.java ! make/tools/src/build/tools/dtdbuilder/DTDInputStream.java ! make/tools/src/build/tools/dtdbuilder/DTDParser.java ! make/tools/src/build/tools/dtdbuilder/PublicMapping.java ! make/tools/src/build/tools/generatebreakiteratordata/CharSet.java ! make/tools/src/build/tools/generatebreakiteratordata/DictionaryBasedBreakIteratorBuilder.java ! make/tools/src/build/tools/generatebreakiteratordata/GenerateBreakIteratorData.java ! make/tools/src/build/tools/generatebreakiteratordata/RuleBasedBreakIteratorBuilder.java ! make/tools/src/build/tools/generatebreakiteratordata/SupplementaryCharacterData.java ! make/tools/src/build/tools/generatecharacter/GenerateCharacter.java ! make/tools/src/build/tools/generatecharacter/SpecialCaseMap.java ! make/tools/src/build/tools/generatecharacter/UnicodeSpec.java ! make/tools/src/build/tools/generatecurrencydata/GenerateCurrencyData.java ! make/tools/src/build/tools/hasher/Hasher.java ! make/tools/src/build/tools/jarsplit/JarSplit.java ! make/tools/src/build/tools/javazic/Gen.java ! make/tools/src/build/tools/javazic/GenDoc.java ! make/tools/src/build/tools/javazic/Main.java ! make/tools/src/build/tools/javazic/Mappings.java ! make/tools/src/build/tools/javazic/Simple.java ! make/tools/src/build/tools/javazic/Time.java ! make/tools/src/build/tools/javazic/Zoneinfo.java ! make/tools/src/build/tools/jdwpgen/AbstractCommandNode.java ! make/tools/src/build/tools/jdwpgen/AbstractGroupNode.java ! make/tools/src/build/tools/jdwpgen/AbstractNamedNode.java ! make/tools/src/build/tools/jdwpgen/AbstractTypeListNode.java ! make/tools/src/build/tools/jdwpgen/AltNode.java ! make/tools/src/build/tools/jdwpgen/CommandSetNode.java ! make/tools/src/build/tools/jdwpgen/ConstantSetNode.java ! make/tools/src/build/tools/jdwpgen/ErrorSetNode.java ! make/tools/src/build/tools/jdwpgen/Node.java ! make/tools/src/build/tools/jdwpgen/OutNode.java ! make/tools/src/build/tools/jdwpgen/RootNode.java ! make/tools/src/build/tools/jdwpgen/SelectNode.java ! make/tools/src/build/tools/makeclasslist/MakeClasslist.java ! make/tools/src/build/tools/stripproperties/StripProperties.java Changeset: e93679cf1e1a Author: valeriep -------------- next part -------------- An HTML attachment was scrubbed... URL: From neugens.limasoftware at gmail.com Thu Aug 18 18:45:49 2011 From: neugens.limasoftware at gmail.com (Mario Torre) Date: Thu, 18 Aug 2011 20:45:49 +0200 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 51 new changesets In-Reply-To: <20110818080616.B696747CDA@hg.openjdk.java.net> References: <20110818080616.B696747CDA@hg.openjdk.java.net> Message-ID: 2011/8/18 : > Changeset: 34fdcdb70d20 > Author: ? ?rupashka > Date: ? ? ?2011-07-28 18:13 +0400 > URL: ? ? ? http://hg.openjdk.java.net/jdk8/2d/jdk/rev/34fdcdb70d20 > > 6995769: occasion NPE thrown from SwingUtilities.computeIntersection() > Reviewed-by: alexp > > ! src/share/classes/javax/swing/RepaintManager.java > I resend, as my phone messed up the message: I though we discussed on the list this changeset and agreed it was not a correct fix, or do I miss something? Cheers, Mario -- pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF Fingerprint: BA39 9666 94EC 8B73 27FA? FC7C 4086 63E3 80F2 40CF IcedRobot: www.icedrobot.org Proud GNU Classpath developer: http://www.classpath.org/ Read About us at: http://planet.classpath.org OpenJDK: http://openjdk.java.net/projects/caciocavallo/ Please, support open standards: http://endsoftpatents.org/ From anthony.petrov at oracle.com Thu Aug 18 20:24:59 2011 From: anthony.petrov at oracle.com (Anthony Petrov) Date: Thu, 18 Aug 2011 13:24:59 -0700 (PDT) Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 51 new changesets In-Reply-To: References: <20110818080616.B696747CDA@hg.openjdk.java.net> Message-ID: <4E4D751B.40102@oracle.com> [ adding Pavel and swing-dev@ to the CC list ] -- best regards, Anthony On 8/18/2011 10:45 PM, Mario Torre wrote: > 2011/8/18 : >> Changeset: 34fdcdb70d20 >> Author: rupashka >> Date: 2011-07-28 18:13 +0400 >> URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/34fdcdb70d20 >> >> 6995769: occasion NPE thrown from SwingUtilities.computeIntersection() >> Reviewed-by: alexp >> >> ! src/share/classes/javax/swing/RepaintManager.java >> > > I resend, as my phone messed up the message: > > I though we discussed on the list this changeset and agreed it was not > a correct fix, or do I miss something? > > Cheers, > Mario From artem.ananiev at oracle.com Fri Aug 19 09:46:44 2011 From: artem.ananiev at oracle.com (Artem Ananiev) Date: Fri, 19 Aug 2011 13:46:44 +0400 Subject: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 51 new changesets In-Reply-To: References: <20110818080616.B696747CDA@hg.openjdk.java.net> Message-ID: <4E4E3104.6040902@oracle.com> On 8/18/2011 10:45 PM, Mario Torre wrote: > 2011/8/18: >> Changeset: 34fdcdb70d20 >> Author: rupashka >> Date: 2011-07-28 18:13 +0400 >> URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/34fdcdb70d20 >> >> 6995769: occasion NPE thrown from SwingUtilities.computeIntersection() >> Reviewed-by: alexp >> >> ! src/share/classes/javax/swing/RepaintManager.java > > I resend, as my phone messed up the message: > > I though we discussed on the list this changeset and agreed it was not > a correct fix, or do I miss something? The fix is already integrated and cannot be reverted. This notification on the 2d-dev alias is caused by a synchronization between AWT/Swing, JDK8 master and Java2D workspaces. The only way to revisit the fix is to file a new bug and commit another changeset using this new bug ID, that's the process - as Pavel said, it's in his TODO list for JDK8. Thanks, Artem > Cheers, > Mario From neugens.limasoftware at gmail.com Fri Aug 19 12:04:24 2011 From: neugens.limasoftware at gmail.com (=?utf-8?B?bmV1Z2Vucy5saW1hc29mdHdhcmVAZ21haWwuY29t?=) Date: Fri, 19 Aug 2011 14:04:24 +0200 Subject: [OpenJDK 2D-Dev] =?utf-8?q?=3CSwing_Dev=3E_=3CAWT_Dev=3E__hg=3A_j?= =?utf-8?q?dk8/2d/jdk=3A_51_new_changesets?= Message-ID: <4e4e5156.89cce30a.454f.ffff9905@mx.google.com> Very good, thanks! Mario -- Sent from HTC Desire... pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF Fingerprint: BA39 9666 94EC 8B73 27FA FC7C 4086 63E3 80F2 40CF http://www.icedrobot.org Proud GNU Classpath developer: http://www.classpath.org/ Read About us at: http://planet.classpath.org OpenJDK: http://openjdk.java.net/projects/caciocavallo/ Please, support open standards: http://endsoftpatents.org/ ----- Reply message ----- Da: "Pavel Porvatov" Data: ven, ago 19, 2011 13:04 Oggetto: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 51 new changesets A: "Artem Ananiev" Cc: "Mario Torre" , , "2d-dev" <2d-dev at openjdk.java.net>, , Hi all, > > On 8/18/2011 10:45 PM, Mario Torre wrote: >> 2011/8/18: >>> Changeset: 34fdcdb70d20 >>> Author: rupashka >>> Date: 2011-07-28 18:13 +0400 >>> URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/34fdcdb70d20 >>> >>> 6995769: occasion NPE thrown from SwingUtilities.computeIntersection() >>> Reviewed-by: alexp >>> >>> ! src/share/classes/javax/swing/RepaintManager.java >> >> I resend, as my phone messed up the message: >> >> I though we discussed on the list this changeset and agreed it was not >> a correct fix, or do I miss something? > > The fix is already integrated and cannot be reverted. This > notification on the 2d-dev alias is caused by a synchronization > between AWT/Swing, JDK8 master and Java2D workspaces. > > The only way to revisit the fix is to file a new bug and commit > another changeset using this new bug ID, that's the process - as Pavel > said, it's in his TODO list for JDK8. I've filed CR 7081010 (The fix of CR 6995769 should be revisited). After some time it will be visible at bugs.sun.com and anybody will be able to trace it... Regards, Pavel -------------- next part -------------- An HTML attachment was scrubbed... URL: From helbrass at gmail.com Tue Aug 23 11:49:49 2011 From: helbrass at gmail.com (Aekold Helbrass) Date: Tue, 23 Aug 2011 14:49:49 +0300 Subject: [OpenJDK 2D-Dev] what is CompileFontConfig? Message-ID: Good day All! Tell me please what is CompileFontConfig and how is it used in OpenJDK? As far as I understand - it creates those *.bfc files from text ones, but why OpenJDK needs it if it is possible to use fontconfig API to get default desktop fonts? Thanx! From philip.race at oracle.com Tue Aug 23 17:02:08 2011 From: philip.race at oracle.com (Phil Race) Date: Tue, 23 Aug 2011 10:02:08 -0700 Subject: [OpenJDK 2D-Dev] what is CompileFontConfig? In-Reply-To: References: Message-ID: <4E53DD10.8020004@oracle.com> Yes it creates bfc files which are faster to load than the source version. OpenJDK *can* use those files created as a custom fontconfig.properties and if you are on Windows you don't have fontconfig API. So in short it is still needed and useful. -phil. On 8/23/11 4:49 AM, Aekold Helbrass wrote: > Good day All! > > Tell me please what is CompileFontConfig and how is it used in > OpenJDK? As far as I understand - it creates those *.bfc files from > text ones, but why OpenJDK needs it if it is possible to use > fontconfig API to get default desktop fonts? > > Thanx! From denilila at gmail.com Wed Aug 24 03:36:38 2011 From: denilila at gmail.com (Denis Lila) Date: Tue, 23 Aug 2011 23:36:38 -0400 Subject: [OpenJDK 2D-Dev] Pisces AA renderer performance improvement. In-Reply-To: References: Message-ID: Resending: (the previous e-mail had a large webrev.zip attachmet. I am now hosting the webrev on Dropbox: http://dl.dropbox.com/u/29228818/webrev/index.html) On Tue, Aug 23, 2011 at 4:55 PM, Denis Lila wrote: > Hi Jim. > >> - I'd like to see the Renderer cache implemented in the RenderingEngine >> code since it is outside the scope of the work that Renderer does. >> Also, your table could fill up with partially used renderers if there >> are ever any bugs that cause it to throw an exception before it calls >> giveBack(). ?I'd like to see some code that tries to make sure they are >> always given back even if errors happen (or, at least, they are removed >> from the data structures if we feel that they aren't appropriate to >> reuse after the error). > > I put it in PiscesRenderingEngine.java. I also implemented a cache eviction > scheme so that it does consume all the memory. I tried to handle exceptions > like the case you mentioned. > > Question: do you think it would be a good idea to create only > renderers with heights > that are powers of two? For example, right now if we get rendering > requests for surfaces > with heights 600, 700, 800 (in that order) we would create 3 renderers > and put them > in the cache. It might be better if we "rounded up" 600 -> 1024. Then we would > only create one renderer for all 3 operations. This would save memory > in this case. > >> - Renderer, line 158 - "while (--toadd >= 0)" allows the compiler to use >> the condition codes from the decrement to satisfy the test. > > Fixed. > >> - Why not just have 1 tracker that manages TILE_SIZE<> instead of TILE_SIZE trackers each of which manages SUB_POS values? >> Unfortunately that means that EvenOdd would have to keep an array >> (because 32*8 is more bits than any single primitive type we have), but >> since we already need to have an array of the EvenOdd trackers, we >> aren't any worse off and in fact we are ahead on storage because >> currently you have 32*32 bits per set of trackers (plus overhead for 32 >> tracker objects). > > Done. > >> - or and line don't really need a full 32-bits. ?They could share >> storage, or they could be stored in byte[] arrays, or they could even >> share a byte[] array. > > Done. > >> - if you store last_subpixy instead of numys then you wouldn't have to >> keep storing the new number back in the arrays - it would become a >> read-only value. > > Done. > >> - I think it would be worth it to amortize the removal of dead pointers. >> ? All it would take would be to store a NULL in the spot and set a >> boolean, then they could all be collapsed out in one pass at the end. >> To get even more creative, if you sort them the other way around and >> then scan from count=>0 then you could just copy the value "ptrs[i] = >> ptrs[--count]" and let the insertion sort at the start of the next pixel >> row deal with it. > > Done (except sorting the other way around. I'm not sure what would > be gained by this). > >> - Another way to manage the merge sort would be to have a temp array of >> SUB_PIX_Y values, quickly store all of the crossings into it either >> forwards or backwards in a pair of tight loops (one for slope >0 and one >> for slope <0) and then do a regular merge sort in a second tight loop. > > I already tried the "temp array" approach. It's slightly worse than the current > implementation. > >> If you use the values at [ci,ci+toadd) as the temp array then one test >> could skip the merge sort step entirely because the values would already >> be sorted (and this is likely to happen). ?My thoughts were that 2 >> tighter loops might be faster than one more complicated loop. > > If we do this, we could indeed skip the merge step in some cases, but in cases > where sorting is actually needed, we wouldn't be able to use merge sort > anymore, unless we still introduced a merge buffer. > > I can't find anywhere to host the webrev, so I attached it. I hope that's ok. > > > Regards, > Denis. > From nils.loodin at oracle.com Wed Aug 24 13:11:19 2011 From: nils.loodin at oracle.com (Nils Loodin) Date: Wed, 24 Aug 2011 15:11:19 +0200 Subject: [OpenJDK 2D-Dev] code review for 7067811: Update demo/sample code to state it should not be used for production In-Reply-To: <0810FDCE-255B-4962-953F-1F49DA909BF3@oracle.com> References: <4E43EFCB.70406@oracle.com> <4E43FC42.1080902@oracle.com> <4E45858C.7060400@oracle.com> <0810FDCE-255B-4962-953F-1F49DA909BF3@oracle.com> Message-ID: <4E54F877.80802@oracle.com> Finally the public changes in the bug is visible. From the description: ----- The documentation should include the following disclaimer: The source code provided with samples and demos for the JDK is meant to illustrate the usage of a given feature or technique and has been deliberately simplified. Additional steps required for a production-quality application, such as security checks, input validation, and proper error handling, might not be present in the sample code. Usage of sample code in production environments is strongly discouraged. On the actual source code a variation of the message should be included as a comment in the header: This source code is provided to illustrate the usage of a given feature or technique and has been deliberately simplified. Additional steps required for a production-quality application, such as security checks, input validation, and proper error handling, might not be present in this sample code. Finally on the documentation of applications, such as the lightweight HTTP server, that are shipped for testing/debugging, the following disclaimer should be added: Applications such as the lightweight HTTP server are shipped with the JDK to help developers deploy and test their code easily. They have not been developed in accordance to software development standards for production-quality applications. Usage of such test and/or support applications in production environments is strongly discouraged. ------- Comment block after copyright in demo / sample sources, i've excluded hprof_b_spec.h from these comments as it contains a public api that's actually supposed to be used. also makefiles are updated to copy a toplevel readme in the sample and demo dirs. Webrev: http://cr.openjdk.java.net/~nloodin/7067811/webrev.03/ CC:ing i18n and 2d since they have demos in these dirs. Regards, Nisse On 08/15/2011 10:15 AM, Nils Loodin wrote: >>> Nils - is it just demo code or do you plan to do this to sample code too (sample code is in src/share/sample/**)? One thing that isn't clear to me is why this needs to be added to every file. Seems like a warning in each demo's README should be sufficient. >>> > Also samples. > >> I agree with Alan that README in each demo would be a proper and adequate place to add this warning. In addition, there is a typo "suich" in the third line of the warning: >> >>> * required for a production-quality application, suich as security checks, > That was not intentional. > >> Is this intentional? Or a typo should be fixed? >> >> Mandy > I'm holding off sending to the other mailing lists until I can get the requirements that the text be included in each source file officially by the one who set the demand. > > As background, yes this is a legal thing. Oracle has strict requirements on in which form Demos and samples can be included in packaging.. > > /Nisse > From Alan.Bateman at oracle.com Wed Aug 24 19:03:49 2011 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Wed, 24 Aug 2011 20:03:49 +0100 Subject: [OpenJDK 2D-Dev] code review for 7067811: Update demo/sample code to state it should not be used for production In-Reply-To: <4E54F877.80802@oracle.com> References: <4E43EFCB.70406@oracle.com> <4E43FC42.1080902@oracle.com> <4E45858C.7060400@oracle.com> <0810FDCE-255B-4962-953F-1F49DA909BF3@oracle.com> <4E54F877.80802@oracle.com> Message-ID: <4E554B15.1010509@oracle.com> Nils Loodin wrote: > : > > Finally on the documentation of applications, such as the lightweight > HTTP server, that are shipped for testing/debugging, the following > disclaimer should be added: > > Applications such as the lightweight HTTP server are shipped with the > JDK to help developers deploy and test their code easily. They have > not been developed in accordance to software development standards for > production-quality applications. Usage of such test and/or support > applications in production environments is strongly discouraged. > "Applications such as the lightweight HTTP server" - I'm not sure that I understand what the requester means here. I wonder if they are talking about the HTTP server API (src/share/classes/com/sun/net/httpserver) or do they really mean the NIO sample code in src/share/sample/nio/server? -Alan. From sean.coffey at oracle.com Fri Aug 26 14:17:47 2011 From: sean.coffey at oracle.com (=?ISO-8859-1?Q?Se=E1n_Coffey?=) Date: Fri, 26 Aug 2011 15:17:47 +0100 Subject: [OpenJDK 2D-Dev] code review request for : 6964917 (JDK 8) Message-ID: <4E57AB0B.4050401@oracle.com> Trivial change for a HKSCS windows font display issue. http://cr.openjdk.java.net/~coffeys/webrev.6964917/ forward port of a fix from jdk 5. (making 6, 7, & 8) http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6964917 regards, Sean From sebastian.sickelmann at gmx.de Sun Aug 28 19:35:58 2011 From: sebastian.sickelmann at gmx.de (Sebastian Sickelmann) Date: Sun, 28 Aug 2011 21:35:58 +0200 Subject: [OpenJDK 2D-Dev] Request for review: 7084245: Update usages of InternalError to use exception chaining Message-ID: <4E5A989E.8070103@gmx.de> Hi, here is a webrev[1] for some cleanup that i want to integrated in tl-repositories. Alan Bateman had scanned the changes and gave me some good input[3] for further discussion here: The changes to java.util.concurrent should go through Doug Lea's upstream CVS. Alan told me that Chris Hegarty is on this topic already. The suggested changes for this is here[2]. I have changed some classes in awt / sun.java2d maybe someone of the 2d-dev maillinglist can look at these changes. I also changed some classes in java/securtiy maybe someone of security-dev maillinglist can look at these changes. Let me know if there is a need to split/rebase the main-webrev[1] to review and/or push it individually. Mostly the patch changes exception-chains. But there are some places where the patch changes behavoir: - I removed some printstackTraces in sun.java2d.pipe.LoopPipe.getStrokesSpans and sun.misc.Launcher (Alan told me that kumar maybe want to have a look at it?). - I changed java.text.Format.clone not to return null. I think it will never happen. But if so throwing an InternalError seems to be better than returning null and let all the extended classes crash in there clone Method with a NullPointerException. And so catching an Exception in java.text.DecimalFormat.clone is unnecessary. -- Sebastian [1] http://oss-patches.24.eu/openjdk8/InternalError/part2/7084245_main_0/ [2] http://oss-patches.24.eu/openjdk8/InternalError/part2/7084245_concurrent_0/ [3] http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-August/007563.html From neugens.limasoftware at gmail.com Sun Aug 28 20:54:49 2011 From: neugens.limasoftware at gmail.com (Mario Torre) Date: Sun, 28 Aug 2011 22:54:49 +0200 Subject: [OpenJDK 2D-Dev] Request for review: 7084245: Update usages of InternalError to use exception chaining In-Reply-To: <4E5A989E.8070103@gmx.de> References: <4E5A989E.8070103@gmx.de> Message-ID: <1314564891.2813.8.camel@galactica> Il giorno dom, 28/08/2011 alle 21.35 +0200, Sebastian Sickelmann ha scritto: > Hi, here is a webrev[1] for some cleanup that i want to integrated in > tl-repositories. Hi, The patch seems good for me (speaking in particular about the AWT/2D part), and I don't think it will introduce any side effects. Just a note: src/share/classes/java/lang/invoke/CallSite.java: } catch (ReflectiveOperationException ignore) { - throw new InternalError(); + throw new InternalError(ignore); } Being a refactoring patch, I would not change the name from "ignore" to the more classical "e", since we are not ignoring the exception anymore. Also in src/share/classes/com/sun/servicetag/BrowserSupport.java, it seems to me that you can also aggregate the InvocationTargetException in the multi catch. In fact, the block could be probably rewritten to take advantage of ReflectiveOperationException. Same for src/share/classes/sun/misc/Launcher.java, src/share/classes/sun/security/util/SecurityConstants.java and src/share/classes/sun/tracing/dtrace/DTraceProvider.java Cheers, Mario From kumar.x.srinivasan at oracle.COM Mon Aug 29 18:04:43 2011 From: kumar.x.srinivasan at oracle.COM (Kumar Srinivasan) Date: Mon, 29 Aug 2011 11:04:43 -0700 Subject: [OpenJDK 2D-Dev] Request for review: 7084245: Update usages of InternalError to use exception chaining In-Reply-To: <4E5A989E.8070103@gmx.de> References: <4E5A989E.8070103@gmx.de> Message-ID: <4E5BD4BB.7070107@oracle.COM> Hi, Sorry for the delay, was on vacation...comment inlined. > Hi, here is a webrev[1] for some cleanup that i want to integrated in > tl-repositories. > > Alan Bateman had scanned the changes and gave me some good input[3] > for further discussion here: > > The changes to java.util.concurrent should go through Doug Lea's > upstream CVS. Alan told me that Chris Hegarty is on this topic > already. The suggested changes for this is here[2]. > > I have changed some classes in awt / sun.java2d maybe someone of the > 2d-dev maillinglist can look at these changes. > I also changed some classes in java/securtiy maybe someone of > security-dev maillinglist can look at these changes. > > Let me know if there is a need to split/rebase the main-webrev[1] to > review and/or push it individually. > > Mostly the patch changes exception-chains. But there are some places > where the patch changes behavoir: > > - I removed some printstackTraces in > sun.java2d.pipe.LoopPipe.getStrokesSpans and sun.misc.Launcher (Alan > told me that kumar maybe want to have a look at it?). The methods in question in sun.misc.Launcher are not called by the java launcher, I think these were added to facilitate the JavaWebstart Launcher javaws. Nevertheless, the changes look good to me. Thanks Kumar > - I changed java.text.Format.clone not to return null. I think it will > never happen. But if so throwing an InternalError seems to be better > than returning null and let all the extended classes crash in there > clone Method with a NullPointerException. And so catching an Exception > in java.text.DecimalFormat.clone is unnecessary. > > -- Sebastian > > [1] http://oss-patches.24.eu/openjdk8/InternalError/part2/7084245_main_0/ > [2] > http://oss-patches.24.eu/openjdk8/InternalError/part2/7084245_concurrent_0/ > [3] > http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-August/007563.html From xuelei.fan at oracle.com Mon Aug 29 12:11:03 2011 From: xuelei.fan at oracle.com (Xuelei Fan) Date: Mon, 29 Aug 2011 05:11:03 -0700 (PDT) Subject: [OpenJDK 2D-Dev] Request for review: 7084245: Update usages of InternalError to use exception chaining In-Reply-To: <4E5A989E.8070103@gmx.de> References: <4E5A989E.8070103@gmx.de> Message-ID: <4E5B81D7.1060002@oracle.com> I reviewed the security part. In general, it looks fine. But sometimes, from my very personal view, the exception-chain might be over used. For example, the following code: try { md = MessageDigest.getInstance("SHA"); } catch (NoSuchAlgorithmException nsae) { throw new InternalError("internal error: SHA-1 not available."); } The exception message and stack is simple and easy to understand. If using exception-chain, the message chain looks like: "internal error: SHA-1 not available." -> "SHA ... not available"" I think the information is redundant, and expose unnecessary call stack. Exceptions thrown by a method should be defined at an abstraction level consistent with what the method does, not necessarily with the low-level details of how it is implemented. Please also refer to item 61, "Throw exceptions appropriate to the abstraction", in "Effective Java 2nd Editor". It seems that the webrev offline now, I cannot access it. Thanks, Xuelei On 8/29/2011 3:35 AM, Sebastian Sickelmann wrote: > Hi, here is a webrev[1] for some cleanup that i want to integrated in > tl-repositories. > > Alan Bateman had scanned the changes and gave me some good input[3] for > further discussion here: > > The changes to java.util.concurrent should go through Doug Lea's > upstream CVS. Alan told me that Chris Hegarty is on this topic already. > The suggested changes for this is here[2]. > > I have changed some classes in awt / sun.java2d maybe someone of the > 2d-dev maillinglist can look at these changes. > I also changed some classes in java/securtiy maybe someone of > security-dev maillinglist can look at these changes. > > Let me know if there is a need to split/rebase the main-webrev[1] to > review and/or push it individually. > > Mostly the patch changes exception-chains. But there are some places > where the patch changes behavoir: > > - I removed some printstackTraces in > sun.java2d.pipe.LoopPipe.getStrokesSpans and sun.misc.Launcher (Alan > told me that kumar maybe want to have a look at it?). > - I changed java.text.Format.clone not to return null. I think it will > never happen. But if so throwing an InternalError seems to be better > than returning null and let all the extended classes crash in there > clone Method with a NullPointerException. And so catching an Exception > in java.text.DecimalFormat.clone is unnecessary. > > -- Sebastian > > [1] http://oss-patches.24.eu/openjdk8/InternalError/part2/7084245_main_0/ > [2] > http://oss-patches.24.eu/openjdk8/InternalError/part2/7084245_concurrent_0/ > [3] > http://mail.openjdk.java.net/pipermail/core-libs-dev/2011-August/007563.html > From yuka.kamiya at oracle.com Mon Aug 29 10:45:49 2011 From: yuka.kamiya at oracle.com (Yuka Kamiya) Date: Mon, 29 Aug 2011 19:45:49 +0900 Subject: [OpenJDK 2D-Dev] code review request for : 6964917 (JDK 8) In-Reply-To: <4E57AB0B.4050401@oracle.com> References: <4E57AB0B.4050401@oracle.com> Message-ID: <4E5B6DDD.9000300@oracle.com> The fix looks good to me. Thanks, -- Yuka (11/08/26 23:17), Se?n Coffey wrote: > Trivial change for a HKSCS windows font display issue. > > http://cr.openjdk.java.net/~coffeys/webrev.6964917/ > > forward port of a fix from jdk 5. (making 6, 7, & 8) > > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6964917 > > regards, > Sean From sebastian.sickelmann at gmx.de Tue Aug 30 05:59:54 2011 From: sebastian.sickelmann at gmx.de (Sebastian Sickelmann) Date: Tue, 30 Aug 2011 07:59:54 +0200 Subject: [OpenJDK 2D-Dev] Request for review: 7084245: Update usages of InternalError to use exception chaining In-Reply-To: <1314564891.2813.8.camel@galactica> References: <4E5A989E.8070103@gmx.de> <1314564891.2813.8.camel@galactica> Message-ID: <4E5C7C5A.9020601@gmx.de> Am 28.08.2011 22:54, schrieb Mario Torre: > Il giorno dom, 28/08/2011 alle 21.35 +0200, Sebastian Sickelmann ha > scritto: >> Hi, here is a webrev[1] for some cleanup that i want to integrated in >> tl-repositories. > Hi, Hi created a new webrev with your suggested changes at: http://oss-patches.24.eu/openjdk8/InternalError/part2/7084245_main_1/ I have created some comments inline in this mail. > The patch seems good for me (speaking in particular about the AWT/2D > part), and I don't think it will introduce any side effects. > > Just a note: > > src/share/classes/java/lang/invoke/CallSite.java: > > } catch (ReflectiveOperationException ignore) { > - throw new InternalError(); > + throw new InternalError(ignore); > } > > Being a refactoring patch, I would not change the name from "ignore" to > the more classical "e", since we are not ignoring the exception anymore. > > Also in src/share/classes/com/sun/servicetag/BrowserSupport.java, it > seems to me that you can also aggregate the InvocationTargetException in > the multi catch. I think we should not make further aggregating on InvocationTargetException in this patch. It changes behavoir. Which of the two places to you mean we can aggregate into multi catch? > In fact, the block could be probably rewritten to take advantage of > ReflectiveOperationException. > > Same for src/share/classes/sun/misc/Launcher.java, > src/share/classes/sun/security/util/SecurityConstants.java and > src/share/classes/sun/tracing/dtrace/DTraceProvider.java Changed that to ReflectiveOperationException. > Cheers, > Mario > -- Sebastian