[OpenJDK 2D-Dev] OpenJDK Warning hackathon :) - patch 1

Mario Torre neugens.limasoftware at gmail.com
Fri Dec 2 14:58:49 UTC 2011

2011/12/2 Jim Graham <james.graham at oracle.com>:
> For GraphicsPrimitive, can't we determine a decent specific type for the
> traceMap to avoid having to suppress the warnings?
> And looking through the rest of the changes, I think I'd support an SG2D.*
> static import in any of the pipelines and loops as well...
>                        ...jim

Ok, I reverted the includes, and I fixed the Path2D with the small duplication
rather than the suppress warning, actually I think is indeed better that way.

I don't fully agree with the static import, since they tend to hyde the scope of
the class rather than make the code more readable (well, that's my opinion at
least), I rather prefer to keep things explicit, but if you want I can prepare
another webrev with the static imports of course.

The map key seems to always be either a GraphicsPrimitive of some kind or a
String, while the value should always be an integer array.

This map is package private, although I didn't find it used elsewhere
(even a grep in native code) so probably the wildcard will do just fine,
I would leave it like this to be honest for now.

Anyway, this is the latest webrev:


pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

IcedRobot: www.icedrobot.org
Proud GNU Classpath developer: http://www.classpath.org/
Read About us at: http://planet.classpath.org
OpenJDK: http://openjdk.java.net/projects/caciocavallo/

Please, support open standards:

More information about the 2d-dev mailing list