[OpenJDK 2D-Dev] [RFC]: 7027667 fix

Denis Lila dlila at redhat.com
Tue Mar 15 16:22:36 UTC 2011


> I pushed the identical fix about 11 days ago under bug id after
> Clemens
> and I spotted
> problems first in the Xrender pipeline. I think that maybe why your
> webrev against
> the 2D repo shows nothing :-) See attached.

Oops :/

I pulled all the changes into my local repo but forgot to update.
That's why I was still seeing the problem after building.

Well, the regression test is written. Do we want to push that
(once I change the names to the original bug id, of course)?

Regards,
Denis.

----- Original Message -----
> Denis,
> 

> 
> -phil.
> 
> 
> On 3/15/2011 7:55 AM, Denis Lila wrote:
> > Hi.
> >
> > This webrev has a fix for 7027667:
> > http://icedtea.classpath.org/~dlila/webrevs/7027667/webrev/
> >
> > Although, for some reason, the diff in the webref for
> > AAShapePipe.java shows nothing. It should be (this is what hg diff
> > gives me):
> >
> > diff -r 155d91257957
> > src/share/classes/sun/java2d/pipe/AAShapePipe.java
> > --- a/src/share/classes/sun/java2d/pipe/AAShapePipe.java Thu Dec 23
> > 08:47:30 2010 -0800
> > +++ b/src/share/classes/sun/java2d/pipe/AAShapePipe.java Tue Mar 15
> > 10:57:28 2011 -0400
> > @@ -109,7 +109,7 @@
> >           Region clip = sg.getCompClip();
> >           int abox[] = new int[4];
> >           AATileGenerator aatg =
> > - renderengine.getAATileGenerator(x, y, dx1, dy1, dx2, dy2, 0, 0,
> > + renderengine.getAATileGenerator(x, y, dx1, dy1, dx2, dy2, lw1,
> > lw2,
> >                                               clip, abox);
> >           if (aatg == null) {
> >               // Nothing to render
> >
> > Is this ok?
> >
> > Thank you,
> > Denis.



More information about the 2d-dev mailing list