[OpenJDK 2D-Dev] <AWT Dev>  Review request for 8005492: Reduce number of warnings in sun/awt/* classes
mikhail.cherkasov at oracle.com
Sat Dec 29 12:00:56 UTC 2012
Hello 2d Team,
Could you please review changes in FontMetrics and Graphics classes?
29.12.2012 15:38, Artem Ananiev пишет:
> Hi, Mikhail,
> On 12/29/2012 3:08 PM, mikhail cherkasov wrote:
>> I'm not sure about replacing getPeer() with peer, but I didn't find
>> any overriding inside JDK and I've no idea for what reason users
>> would do this.
> getPeer() is deprecated, so it shouldn't be used by applications. I
> don't have any preferences whether to use peer or getPeer(), probably
> the best way is to leave everything as is.
> In general, the webrev look fine, except Charset changes in
> FontMetrics and Graphics. Please, contact Java2D team about this part
> of the webrev.
>> Anyway if you thinks that change breaks compatibility, please notify
>> me ASAP, I'll prepare new patch and will stop breaking other classes.
>> 29.12.2012 14:41, mikhail cherkasov пишет:
>>> Hello All,
>>> Please review the following patch:
>>> webrev: http://cr.openjdk.java.net/~mcherkas/8005492/webrev.00/
>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005492
>>> the following classes was cleaned from warnings:
More information about the 2d-dev