[OpenJDK 2D-Dev] Please review 7u6 fix for 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService() return null
Phil Race
philip.race at oracle.com
Tue Jun 19 16:49:12 UTC 2012
startsWith("Mac") is what we use in FX and I don't see a problem with it
and its surely more reliable to type and efficient than contains("OS X");
If its meant to be targeted to a specific version that could break if
there's an OS XI ..
And startsWith("Win") is a common pattern. So I don't agree with the advice
anyway.
-phil.
On 6/19/2012 9:36 AM, Sergey Bylokhov wrote:
> Hi,Phil.
>
> According to these CR macosx check should be: .contains("OS X").
> http://monaco.sfbay.sun.com/detail.jsf?cr=7147461
> http://monaco.sfbay.sun.com/detail.jsf?cr=7130404
>
> On 19.06.2012 20:13, Phil Race wrote:
>> 7124536: [macosx] PrintServiceLookup.lookupDefaultPrintService()
>> return null
>> http://cr.openjdk.java.net/~prr/7124536.7u6/
>>
>> -phil.
>
>
More information about the 2d-dev
mailing list