[OpenJDK 2D-Dev] [8] request for review: 4892259 GIF ImageReader does not call passComplete in IIOReadUpdateListener

Phil Race philip.race at oracle.com
Mon Nov 19 23:47:10 UTC 2012


So I take it that you confirmed interlaced images do *not* exhibit this 
problem ?
Its not obvious from the bug report that its only non-interlaced images 
that are the issue.

I suppose a non-interlaced image could be considered a single pass but
I can't find anywhere that we mandated such a behaviour and it would seem
odd for many formats to require it.

Can we include a regression test for this fix ?


On 11/19/2012 11:15 AM, Vadim Pakhnushev wrote:
> Hi,
> Please review a fix for bug 4892259:
> http://bugs.sun.com/view_bug.do?bug_id=4892259
> http://cr.openjdk.java.net/~bae/4892259/webrev.00/
> Actually GIFImageReader should not call neither passComplete, nor 
> passStarted for non-interlaced images in the first place.
> So the fix is to check whether the image is interlaced or not and skip 
> startPass method entirely in case of interlaced image.
> passComplete is called only for interlaced images.
> Thanks,
> Vadim

More information about the 2d-dev mailing list