[OpenJDK 2D-Dev] [8] request for review 4649812: GIFImageReader handles transparency incorrectly

Vadim Pakhnushev vadim.pakhnushev at oracle.com
Wed Oct 3 12:05:24 UTC 2012


Please review the fix for http://bugs.sun.com/view_bug.do?bug_id=4649812
webrev: http://cr.openjdk.java.net/~bae/4649812/webrev.00/

This will result in lower footprint actually (not that it will be 
noticeable in real application though).
First, we will omit allocating temporary alpha LUT.
Second, although IndexColorModel will allocate full rgba array in any 
case, we will skip creating ImageTypeSpecifier.Indexed class (created 
with ImageTypeSpecifier.createIndexed call) which store a copy of passed 
LUT arrays.
It seems that this Indexed class was intended to have equals and 
hashCode methods like ImageTypeSpecifier.Banded and 
But ImageTypeSpecifier.Grayscale, ImageTypeSpecifier.Indexed and 
ImageTypeSpecifier.Packed specifiers, although retains a copy of passed 
parameters, don't use them.


More information about the 2d-dev mailing list