[OpenJDK 2D-Dev] [PATCH FOR REVIEW] Minor clean-up of jdk/src/share/classes/sun/font/SunFontManager.java

Jiri Vanek jvanek at redhat.com
Mon Oct 29 08:36:44 UTC 2012

On 10/26/2012 06:38 PM, Phil Race wrote:
> It might look cleaner but its probably slower in practice as toLowerCase()
> on the full font names will generate a lot of garbage and it does a fair amount of work,

Although I have checked toLower/UpperCase I must admit I have underestimated the complexity. However 
my initial thought was that this code is not somehow performance critical so it can be more nice 
then fast:)

> and endsWidth(..) is implemented by calling startsWith() and calculating the
> appropriate offset, so you added the method call overhead there too.

So this sounds to me like duplicated code O:)

>  Regardless, this doesn't seem to be sufficiently important to backport.

Sure. I was to enthusiastic about the patch. Sorry.


Best Regards,
> On 10/26/12 7:34 AM, Jiri Vanek wrote:
>> Hi!
>> I would like to offer this minor clean-up of jdk/src/share/classes/sun/font/SunFontManager.java.
>> WebRev can be found here:
>> http://jvanek.fedorapeople.org/oracle/jdk8/webrevs/sunFontManagerMinorCleanUp/
>> If this changeset will be found worthy to be accepted to OpenJDK, will it be possible to backport
>> it also to OpenJDK7?
>> With kind regards
>> Jiri Vanek

More information about the 2d-dev mailing list