[OpenJDK 2D-Dev] <AWT Dev> [8] Please review fix for 7175183: [macosx] Objective-C exception thrown when switching monitor configuration

Phil Race philip.race at oracle.com
Tue Sep 4 17:05:15 UTC 2012


Alexander,

This is a shared code change. Did you test it on Windows ?
In fact, can you explain why this has not been seen on Windows
in the many years now that we've had this code ? eg, did we
recently introduce a regression, is this MacOS specific ?

-phil.

On 9/4/2012 9:18 AM, Alexander Zuev wrote:
> Hello,
>
>   please review my fix for CR 7175183: [macosx] Objective-C exception 
> thrown when switching monitor configuration
>
>   The NPE happens because of the getBackupSurface method call may 
> result in the resetting of the current accelerated surface to null. 
> The idea of the fix is to move the invalidation of the accelerated 
> surface before the getBackupSurface() call.
>
> Bug description is: 
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7175183
> Webrev can be found here: 
> http://cr.openjdk.java.net/~kizune/7175183/webrev.01
>
> With best regards,
> Alex




More information about the 2d-dev mailing list