[OpenJDK 2D-Dev] <AWT Dev> [8] Review request for JDK-8025684 - Fix Raw and unchecked warnings java.awt.image classes

Artem Ananiev artem.ananiev at oracle.com
Thu Oct 10 09:15:33 UTC 2013


On 10/9/2013 10:37 PM, srikalyan chandrashekar wrote:
> Hi Artem, i have done some changes (more redundant casts identified and
> removed), please get the webrev from the same location again . Thanks
> for your review.

The webrev is updated:

http://cr.openjdk.java.net/~art/srikalyc/8025684.01/

I haven't see your replies to Jim's questions, have you seen his email?

Thanks,

Artem

> ---
> Thanks
> kalyan
>
> On 10/2/2013 3:02 AM, Artem Ananiev wrote:
>>
>> java.awt.image is one of the Java2D packages, so I'm adding 2d-dev to
>> CC. Please, wait for at least one approval from Java2D team.
>>
>> For easier review, I put the webrev here:
>>
>> http://cr.openjdk.java.net/~art/srikalyc/8025684.00/
>>
>> It looks fine to me. There is one "unchecked" warning still left, at
>> BufferedImage.java:645, it can be fixed by introducing a local
>> variable and @SuppressWarnings("unchecked"), but I'm not sure it's
>> worth doing.
>>
>> Thanks,
>>
>> Artem
>>
>> On 10/2/2013 1:51 AM, srikalyan chandrashekar wrote:
>>> Hi team ,  could someone review the fix
>>>       Bug      : https://bugs.openjdk.java.net/browse/JDK-8025684
>>>       Webrev   :
>>> https://github.com/srikalyc/JDKfixes/blob/master/java.awt.image.raw_unchecked_webrev.zip
>>>
>>>
>>>       Fix      : Raw and unchecked warnings in AWT image classes fixed
>>>
>



More information about the 2d-dev mailing list