[OpenJDK 2D-Dev] Review request for JDK-8032527: fix the errors reported by doclint report in jdk repo

[Phil Race]

You should be able to test this fix against jdk9/client now.
If it works then you can push

-phil.

On 3/27/14 3:54 PM, Sonali Goel wrote:
> Hi Phil,
>
> Since the fix for JDK-8031625 has been pushed, we have no more 
> blockers for the doclint fix.
> Could you please review this webrev: 
> http://cr.openjdk.java.net/~cl/8032527/webrev.01/
>
> Thanks,
> Sonali
> On 3/18/2014 1:48 PM, Phil Race wrote:
>> A late update ..
>>
>> The javadoc change is
>>
>> 8031625: javadoc problems referencing inner class constructors.
>>
>> And since that's not pushed yet, you can't actually test your change
>> until it has been ! So this really should wait until its been pushed
>> and  tested else you may have happy doclint but unhappy generated 
>> javadoc.
>>
>> -phil.
>>
>> On 3/18/2014 1:45 PM, Phil Race wrote:
>>> Hi,
>>>
>>> A little context might help here  as I couldn't  see why doclint is 
>>> reporting a problem
>>> since the links seem to work.
>>>
>>> http://docs.oracle.com/javase/8/docs/api/java/awt/geom/Path2D.html
>>>
>>> I searched and found https://bugs.openjdk.java.net/browse/JDK-8025244
>>> where it was suggested doclint was wrong on exactly this javadoc.
>>> For reasons I don't understand (since the link works fine) Jon said 
>>> it was wrong.
>>> In an off-line conversation I am told that javadoc tool 
>>> implementation didn't do what
>>> the spec. said it should, so the form you are proposing is what is 
>>> supposed to work.
>>> But since JDK 8 public javadoc is just fine that's confusing.
>>>
>>> The javadoc people they aren't sure where the javadoc
>>> behaviour change was pushed and its an incompatible change.
>>>
>>> So question #1 : does the jdk9 generated javadoc actually link 
>>> properly with this change ?
>>> And question #2: does doclint on JDK 9 now pass this cleanly with 
>>> this change
>>> - ie no new warnings and this warning is gone
>>>
>>> -phil.
>>>
>>> On 3/14/2014 1:04 AM, christine.lu at oracle.com wrote:
>>>> Hi,
>>>>
>>>> Please review a fix for
>>>>
>>>> JDK-8032527
>>>> fix the errors reported by doclint report in jdk repo.
>>>>
>>>> webrev: http://cr.openjdk.java.net/~cl/8032527/webrev.01/
>>>>
>>>> Thanks
>>>> Christine
>>>>
>>>>
>>>>
>>>>
>>>
>>
>