[OpenJDK 2D-Dev] [9] Review Request: 8039418 [macosx] Calling JNI functions in the scope of Get/ReleasePrimitiveArrayCritical

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Tue Apr 8 21:21:06 UTC 2014


Hello.
Please review the fix for jdk 9.
The method [1] is called between Get/ReleasePrimitiveArrayCritical. In 
the fix it was moved above GetPrimitiveArrayCritical call.

[1]:
JNIEXPORT void JNICALL
Transform_GetInfo(JNIEnv *env, jobject txform, TransformInfo *pTxInfo) {
     pTxInfo->dxdx = (*env)->GetDoubleField(env, txform, m00ID);
     pTxInfo->dxdy = (*env)->GetDoubleField(env, txform, m01ID);
     pTxInfo->tx   = (*env)->GetDoubleField(env, txform, m02ID);
     pTxInfo->dydx = (*env)->GetDoubleField(env, txform, m10ID);
     pTxInfo->dydy = (*env)->GetDoubleField(env, txform, m11ID);
     pTxInfo->ty   = (*env)->GetDoubleField(env, txform, m12ID);
}

Bug: https://bugs.openjdk.java.net/browse/JDK-8039418
Webrev can be found at: http://cr.openjdk.java.net/~serb/8039418/webrev.00

-- 
Best regards, Sergey.




More information about the 2d-dev mailing list