[OpenJDK 2D-Dev] JDK9: RFR: 8034998: Fix raw and unchecked lint warnings in javax.imageio

Henry Jen henry.jen at oracle.com
Thu Feb 20 23:33:34 UTC 2014


Updated webrev at

http://cr.openjdk.java.net/~henryjen/jdk9/8034998/1/webrev/

- change those two Iterator from public to private
- rebase to jdk9/client

Who will be pushing those changes once approved?

Cheers,
Henry


On 02/19/2014 01:12 PM, Phil Race wrote:
> ImageIO.java
>
> 515         public Iterator<ImageReaderSpi> iter;
>
>
> 829         public Iterator<ImageWriterSpi> iter;
>
> I can't see why these are public. I think they should be private
> Since you are touching these lines anyway public->private
>
> I was on the look out for changes to public interfaces but I
> didn't see any so that's Ok
>
> So if you can
> 1)  make the two changes
> 2) re-generate against the client forest
>
> then it should be ready for approval.
>
> -phil.
>
> On 2/14/2014 6:43 PM, Henry Jen wrote:
>> Hi,
>>
>> Please review the webrev to clean up raw and unchecked warnings in
>> javax.imageio packag at,
>>
>> http://cr.openjdk.java.net/~henryjen/jdk9/8034998/0/webrev/
>>
>> The webrev does not cover javax.imageio.spi, that will come in anoter
>> webrev.
>>
>> Cheers,
>> Henry
>



More information about the 2d-dev mailing list