[OpenJDK 2D-Dev] RFR: Allow using a system-installed lcms2

Omair Majid omajid at redhat.com
Wed Mar 19 23:25:44 UTC 2014


* Phil Race <philip.race at oracle.com> [2014-03-19 12:39]:
> On 3/17/2014 4:27 AM, Magnus Ihse Bursie wrote:
> >While we generally support moving files to a proper location, if
> >this move is causing trouble for Phil and the 2d team, we think it
> >can be an acceptable exception this time to just single out the
> >LCMS.c file. (This can be achieved by setting
> >INCLUDE_FILES:=LCMS.c -- that will automatically exclude other
> >files in the SRC dirs.)

Magnus, thanks for the pointer!

> This sounds like a reasonable plan.
> The final on disk bits in the JRE/lib/arch directory should however always
> show "liblcms.so" and in the case of a build which didn't select the system
> installed option this will contain everything.

The following webrevs implement this:
Root: http://cr.openjdk.java.net/~omajid/webrevs/system-lcms/01/
JDK: http://cr.openjdk.java.net/~omajid/webrevs/system-lcms/01-jdk/

> I don't think JPRT runs any relevant tests. As someone else just found
> out yesterday relying on it to test client code will bite you.

I tested that this builds but nothing else so far. Any pointers to what
is a good way to test this client code?


PGP Key: 66484681 (http://pgp.mit.edu/)
Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681

More information about the 2d-dev mailing list