[OpenJDK 2D-Dev] <AWT Dev> JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

Phil Race philip.race at oracle.com
Tue May 13 21:15:47 UTC 2014


I don't see why you changed the variable names in some cases.
See here where one change is only one line since you left it alone and 
the other is 6 lines since you changed it
As it is, its just inconsistent and makes it less obvious to the eye 
that nothing unexpected changed.
And here what could have been a 2 line change is 25 ..
So I would say leave the variable names alone unless there's a 
compelling reason - and I don't see one.
Also pushing the 2D, AWT and Swing changes to client is requested as 
although your changes are
small its what is appropriate. I would not push hotspot changes to 
client either. Also lots of files
are being updated in client and doing it this way will minimise merges ...


On 5/13/2014 6:51 AM, Paul Sandoz wrote:
> On May 13, 2014, at 1:10 PM, Sergey Bylokhov 
> <Sergey.Bylokhov at oracle.com <mailto:Sergey.Bylokhov at oracle.com>> wrote:
>> Hi, Paul.
>> adding 2d-dev@
>> media: sound/awt/swing part looks fine.
> Thanks.
>> Note that this part of the fix should be pushed to client forest.
> Which classes exactly from here:
> http://cr.openjdk.java.net/~psandoz/jdk9/sb/JDK-8041679-buffer-to-builder-media/webrev/ 
> <http://cr.openjdk.java.net/%7Epsandoz/jdk9/sb/JDK-8041679-buffer-to-builder-media/webrev/>
> ?
> I am not familiar with the client integration process but from my 
> perspective it does seem a little odd to have to do that.
> Paul.

More information about the 2d-dev mailing list