[OpenJDK 2D-Dev] [9] Review Request: 8041644 [OGL] clip is ignored during surface->sw blit

Phil Race philip.race at oracle.com
Tue May 20 16:52:34 UTC 2014

So my first question here was. So what does D3D do ? We should just copy 
that code.
Then I read the bug report and it says D3D has the same bug
I don't get why you'd fix it for OGL but not for D3D which seems like the
way more important case.
So when you check this in we'll just get one more failing regression test.


On 5/20/2014 9:42 AM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk 9, which is also targeted for jdk 8u20.
> Description:
>     Our implementation of opengl surface-> sw blit does not take into 
> account the clipped area.
> Suggested fix:
>    I intersect a clip and a coordinates of destination, and if the 
> resulted region is rectangle I use the usual blit, but if the region 
> is complex I use intermediate buffer(like OGLAnyCompositeBlit.Blit() 
> or OGLGeneralBlit.Blit()).
> Bug: https://bugs.openjdk.java.net/browse/JDK-8041644
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/8041644/webrev.00

More information about the 2d-dev mailing list