[OpenJDK 2D-Dev] [9] Review Request: 8041644 [OGL] clip is ignored during surface->sw blit

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Tue May 20 17:03:37 UTC 2014

On 5/20/14 8:52 PM, Phil Race wrote:
> So my first question here was. So what does D3D do ? We should just 
> copy that code.
D3D doesn't work as well.
> Then I read the bug report and it says D3D has the same bug
> I don't get why you'd fix it for OGL but not for D3D which seems like the
> way more important case.
OGL is important too, because it is default pipeline on osx. I plan to 
fix D3D case later.
Actually I am not familiar with d3d code and right now I focused on 
hidpi support in SwingNode on OSX.
> So when you check this in we'll just get one more failing regression 
> test.
Yes. It will be bound to the separate CR.
> -phil.
> On 5/20/2014 9:42 AM, Sergey Bylokhov wrote:
>> Hello.
>> Please review the fix for jdk 9, which is also targeted for jdk 8u20.
>> Description:
>>     Our implementation of opengl surface-> sw blit does not take into 
>> account the clipped area.
>> Suggested fix:
>>    I intersect a clip and a coordinates of destination, and if the 
>> resulted region is rectangle I use the usual blit, but if the region 
>> is complex I use intermediate buffer(like OGLAnyCompositeBlit.Blit() 
>> or OGLGeneralBlit.Blit()).
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8041644
>> Webrev can be found at: 
>> http://cr.openjdk.java.net/~serb/8041644/webrev.00

Best regards, Sergey.

More information about the 2d-dev mailing list