[OpenJDK 2D-Dev] [9] Review Request: 8059942 Default implementation of DrawImage.renderImageXform() should be improved for d3d/ogl

Sergey Bylokhov sergey.bylokhov at oracle.com
Mon Nov 10 22:52:36 UTC 2014

Hi, Jim.
To simply fill a span in the Region, I'll need to open Region.appendSpan() method, but I do not want to do it. So I need to create my own EdgesSpanIterator, or totally eliminate this loop and return Region object from the TransformHelper directly. Probably some logic can be moved from TransformHelper to the java level(atleast generation of edges array). Additionally it will be simpler to check a performance improvement, because now it is not so obvious comparing to the current percents improvement.

----- james.graham at oracle.com wrote:

> On 11/10/14 12:03 PM, Sergey Bylokhov wrote:
> > Note that I plan to improve generation of the clip region of this
> method
> > later.
> Ah, I missed this.  It should be fairly easy to write a tight loop in
> Region to fill in a spans buffer.  I'm not sure it needs to be pushed
> off.  It would either be filed and forgotten thereby leaving a bad
> code 
> template in our code for someone else to come along and copy from - or
> it would be fixed immediately and so I'm not sure why we don't just
> fix 
> it with the initial bug...?
> 			...jim

More information about the 2d-dev mailing list