[OpenJDK 2D-Dev] RFR(XXS): 8057934: Upgrade to LittleCMS 2.6 breaks AIX build

Volker Simonis volker.simonis at gmail.com
Tue Sep 9 13:51:00 UTC 2014


could you please review the following tiny fix for an AIX build
problem intruduced by "8056122: Upgrade JDK to LittleCMS 2.6":


The problem is that the new version of LittleCMS now includes
"pthread.h" in "lcms2_internal.h". Unfortunalty on AIX, "pthread.h" in
turn includes "sys/proc.h" which uncoditionally defines a preprocessor
constant "SNONE".

In "cmscgats.c" this preprocessor constant "SNONE" collides with the
enum value "SNONE" from the SYMBOL enumaration.

The only solution I see is to rename "SNONE" in "cmscgats.c". I
renamed it to "SVOID" but would be happy with any other name.
Fortunately "SNONE" is only used locally in the file "cmscgats.c", so
renaming it won't have any impact on other files.

Once this bug is fixed I'll report the problem upstream to LittleCMS
and try to get the fix in there.

Finally, there's on last point I wan to bring up. I realized that
"8056122: Upgrade JDK to LittleCMS 2.6" went from jdk9-client right
into 8u-dev. That's why we caught this error only in 8u-dev and not
already in jdk9-dev which we build on a daily basis on all our porting
platforms. Is my assumption that changes have to through jdk9-dev
before they get back ported wrong or has this been an exeption?

Thank you and best regards,

More information about the 2d-dev mailing list