[OpenJDK 2D-Dev] RFR 6488522: PNG writer should permit setting compression level and iDAT chunk maximum size

[Sergey Bylokhov]

Hi, Laurent.
Should the test check the resulted image in the file? At least it can 
check that the CompressionMode is not ignored and the saved files have 
different size/content for different modes? Also I think in the test we 
can cover all plugins which canWriteCompressed=true?

On 09/12/15 15:36, Laurent Bourgès wrote:
> Hi,
>
> Please review this webrev fixing the long-standing bug in imageio
> PNGImageWriter to support compression levels:
> bug: https://bugs.openjdk.java.net/browse/JDK-6488522
> webrev: http://cr.openjdk.java.net/~lbourges/png/PNGWriter-6488522.0/
> <http://cr.openjdk.java.net/%7Elbourges/png/PNGWriter-6488522.0/>
>
> Changes:
> - default Deflater level changed from 9 (best) to 4 (medium)
> - added compression parameter support (mode, quality)
> - added missing @Override and fixed several warnings (public modifiers)
>
> Best regards,
> Laurent


-- 
Best regards, Sergey.