[OpenJDK 2D-Dev] RFR 6488522: PNG writer should permit setting compression level and iDAT chunk maximum size
Laurent Bourgès
bourges.laurent at gmail.com
Tue Dec 15 15:25:58 UTC 2015
Sergey,
thanks for your review.
Could you or Phil push it for me once another reviewer is OK ?
Laurent
2015-12-15 16:22 GMT+01:00 Sergey Bylokhov <Sergey.Bylokhov at oracle.com>:
> Looks fine to me. Thanks.
>
>
> On 12/12/15 19:17, Laurent Bourgès wrote:
>
>> Sergey,
>>
>> Here is my latest webrev:
>> http://cr.openjdk.java.net/~lbourges/png/PNGWriter-6488522.3/
>>
>> One more reviewer, please ?
>>
>>
>> Probably it can be made local to the write method, but this version looks
>>> fine too.
>>>
>>
>> You're right. I will improve that, I did it too quickly.
>>
>> Fixed: it is clearer and simpler.
>>
>> Regards,
>> Laurent
>>
>
>
> --
> Best regards, Sergey.
>
--
--
Laurent Bourgès
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20151215/97abe8d3/attachment.html>
More information about the 2d-dev
mailing list