[OpenJDK 2D-Dev]  request for review: 8074954: ImageInputStreamImpl.readShort/readInt do not behave correctly at EOF
philip.race at oracle.com
Fri Mar 20 17:45:10 UTC 2015
Andrew, The fix looks good to me.
Sergey, are you asking for that text to be added ? Looks to me like its
so probably I am not following what you mean.
On 03/20/2015 10:32 AM, Sergey Bylokhov wrote:
> Hi, Andrew?
> Hi, Andrew.
> Should we update a readFully() also?
> * @exception java.io.EOFException if the stream reaches the end
> * reading all the bytes.
> * @exception IOException if an I/O error occurs.
> void readFully(byte b, int off, int len) throws IOException;
> 20.03.15 14:30, Andrew Brygin wrote:
>> could you please review a fix for CR 8074954?
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8074954
>> Webrev: http://cr.openjdk.java.net/~bae/8074954/9/webrev.00/
>> The problem happens if an input stream does not contain enough data
>> to read a multi-byte type (as 4-bytes integer or 2-bytes short)
>> completely. In this case the actual number of obtained bytes is
>> returned, and if we get at least one byte, the EOF exception in
>> not triggered.
>> As a result, an incorrect value is returned.
>> Suggested fix is to check explicitly whether required number of bytes
>> has been read.
>> Supplied regression test demonstrates the problem.
>> Please take a look.
> Best regards, Sergey.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the 2d-dev