[OpenJDK 2D-Dev] Review Request: Small tweak in the DrawImage.java

Jim Graham james.graham at oracle.com
Fri Nov 13 20:43:48 UTC 2015


Looks good!

			...jim

On 11/13/2015 12:12 PM, Sergey Bylokhov wrote:
> On 13.11.15 1:50, Jim Graham wrote:
>>> I can add a comment that this code is for performance, what do you
>>> think?
>>
>> I'd like to see that, was there an updated diff?  In either case, I
>> don't think we should disturb the comment and test at the top, we should
>> just add additional checks down below where you have them now...
>
> The code for w/h was reverted. Probably I will try change it later in
> another fix, after verification of our java blits and the fix for
> JDK-4783274.
>
> http://cr.openjdk.java.net/~serb/perf/DrawImageItself.02/src/java.desktop/share/classes/sun/java2d/pipe/DrawImage.java.sdiff.html
>
>



More information about the 2d-dev mailing list