[OpenJDK 2D-Dev] [9] RFR: JDK-8074826, , Resolve disabled warnings for liblcms

[Phil Race]

Sorry, no we don't want this patch.
We are not fixing warnings in upstream libraries.

-phil.

On 04/01/2016 03:57 AM, prasanta sadhukhan wrote:
> Hi All,
>
> Please review a fix to remove the disabled warnings from lcms library
> Bug: https://bugs.openjdk.java.net/browse/JDK-8074826
> webrev: http://cr.openjdk.java.net/~psadhukhan/8074826/webrev.00/
>
> One issue was snprintf/sprintf was using arguments
>
> it8 ->DoubleFormatter
>
> instead of string format literal like %f or %d
> which was causing the warning. I have used
>
> DEFAULT_DBL_FORMAT which was anyway copied to it8 ->DoubleFormatter.
>
> Another issue was
>
> cmsUNUSED_PARAMETER macro was used to suppress unused parameter 
> warning but this macro was called after the return statement, thereby 
> E_STATEMENT_NOT_REACHED warning was getting issued. Now, I am Calling 
> this before the return statements. I have run JPRT build on these 
> targets *** Build targets: solaris_sparcv9_5.11-product 
> solaris_sparcv9_5.11-fastdebug solaris_x64_5.11-product 
> solaris_x64_5.11-fastdebug linux_i586_3.8-product with attributes 
> distribution=OEL linux_i586_3.8-fastdebug with attributes 
> distribution=OEL linux_x64_3.8-product with attributes 
> distribution=OEL linux_x64_3.8-fastdebug with attributes 
> distribution=OEL macosx_x64_10.9-product macosx_x64_10.9-fastdebug 
> windows_i586_6.3-product windows_i586_6.3-fastdebug 
> windows_x64_6.3-product windows_x64_6.3-fastdebug Build Stats:        
> 14 pass, 0 fail, 0 killed, 0 working, 0 initializing, 0 not started
>
> Regards
> Prasanta
>