[OpenJDK 2D-Dev] RFR 8152183: [TEST] add test for TIFFField

Alexander Stepanov alexander.v.stepanov at oracle.com
Wed Apr 6 10:14:15 UTC 2016


P.S.: and even if scratch is accidentally non-writable (which is 
definitely an exceptional situation), then the 'writeImage()' method 
will throw a proper Exception, so it seems there is no need in 
additional checks here.

Thanks,
Alexander

On 4/6/2016 12:21 PM, Alexander Stepanov wrote:
> Hello Phil,
>
> > I did not think you could assume $CWD is writeable in jtreg tests.
>
> according to the jtreg docs, "when jtreg is executed, it cd's into a 
> scratch". Could the scratch dir be non-writable? At a 1st glance it 
> seems to be unlikely, but maybe I'm wrong.
>
> Thanks,
> Alexander
>
> On 4/6/2016 1:56 AM, Phil Race wrote:
>> 45     private final static String FILENAME = "test.tiff";
>>
>>  136         OutputStream s = new BufferedOutputStream(new 
>> FileOutputStream(FILENAME));
>>
>>
>> I did not think you could assume $CWD is writeable in jtreg tests.
>> If I can be assured this is actually OK then I have no other issues.
>>
>> -phil.
>>
>> On 04/01/2016 10:31 AM, Alexander Stepanov wrote:
>>> Please see the updated webrev:
>>> http://cr.openjdk.java.net/~avstepan/8152183/webrev.01/
>>>
>>> One more test (for multi-page tiffs) was added; for now to be 
>>> ignored because of JDK-8148454
>>>
>>> Thanks,
>>> Alexander
>>>
>>> On 3/28/2016 1:07 PM, Alexander Stepanov wrote:
>>>> Sorry, just a reminder.
>>>>
>>>> Thanks,
>>>> Alexander
>>>>
>>>> On 3/23/2016 5:09 PM, Alexander Stepanov wrote:
>>>>> Hello,
>>>>>
>>>>> Could you please review the following fix
>>>>> http://cr.openjdk.java.net/~avstepan/8152183/webrev.00/
>>>>> for
>>>>> https://bugs.openjdk.java.net/browse/JDK-8152183
>>>>>
>>>>> Just a single test added.
>>>>>
>>>>> Thanks,
>>>>> Alexander
>>>>
>>>
>>
>




More information about the 2d-dev mailing list