[OpenJDK 2D-Dev] [9] RFR JDK-8169728: Missing sign checks in TIFFField(TIFFTag tag, int type, int count, Object data) for TIFFTag.TIFF_LONG

[Philip Race]

One "PS"
why say 4294967295 in the spec where 0xFFFFFFFF is probably
more immediately to most programmers that it is not a random
choice of number ?

-phil


On 12/7/16, 4:56 PM, Philip Race wrote:
> +1
>
> Yes, it needs a CCC update. A quick "bug fix" one.
>
> -phil.
>
> On 12/6/16, 2:03 PM, Brian Burkhalter wrote:
>> Please review at your convenience:
>>
>> Issue:    https://bugs.openjdk.java.net/browse/JDK-8169728
>> Patch:    http://cr.openjdk.java.net/~bpb/8169728/webrev.00/
>>
>> To the primary constructor TIFFField(TIFFTag,int,int,Object), add 
>> some range checks for TIFF_LONG, TIFF_RATIONAL, and TIFF_IFD_POINTER, 
>> and some array size checks for TIFF_RATIONAL and TIFF_SRATIONAL.
>>
>> Does the new IllegalArgumentException case warrant a CCC review?
>>
>> Thanks,
>>
>> Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20161207/87f6356f/attachment.html>