[OpenJDK 2D-Dev] [9] RFR 8170579: The "Banner page" checkbox is disabled

Prasanta Sadhukhan prasanta.sadhukhan at oracle.com
Tue Dec 13 16:08:26 UTC 2016


Gentle reminder for review....

Regards
Prasanta
On 12/7/2016 9:00 PM, Prasanta Sadhukhan wrote:
> Hi All,
>
> Please review a fix for jdk9 where it is seen that "Banner" checkbox 
> in printer dialog is disabled in ubuntu16.10.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8170579
> webrev: http://cr.openjdk.java.net/~psadhukhan/8170579/webrev.00/
>
> Issue was, in ubuntu16.10 the attribute map does not have 
> "job-sheet-supported" attribute returned by CUPS
> so this category is not added to supported categories
> [http://hg.openjdk.java.net/jdk9/client/jdk/file/7f09d558b044/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l1030] 
>
> so isAttributeCategorySupported() called by ServiceDialog returns 
> false 
> [http://hg.openjdk.java.net/jdk9/client/jdk/file/7f09d558b044/src/java.desktop/share/classes/sun/print/ServiceDialog.java#l2763]
> resulting in Banner checkbox getting disabled.
>
> Fix is to check if JobSheet category is supported in underlying 
> platform, only then proceed with the test.
>
> Regards
> Prasanta




More information about the 2d-dev mailing list