[OpenJDK 2D-Dev] RFR(M): 8170798: Fix minor issues in java2d and sound coding.

Sergey Bylokhov sergey.bylokhov at oracle.com
Wed Dec 14 18:28:55 UTC 2016


>> So it seems like the elements at indices from controlCount to 10 may not
>> be initialised but I don't see how this would be a problem since
>> PORT_NewCompoundControl
>> has no hardwired "10" .. it just uses controlCount.
>> In any case this would seem better addressed by the same kind of memset
>> after stack allocation that you proposed for the jpeg case.
> Fixed.  (I thought it's cheaper to initialize only the rest, and more simple
> for the C-compiler to remove where useless.)

It seems that some other implementations of PORT_NewCompoundControl can have the same issue, like in :
PLATFORM_API_BsdOS_ALSA_Ports.c and PLATFORM_API_SolarisOS_Ports.c. Should we apply the same memset there to make them in sync?

More information about the 2d-dev mailing list