[OpenJDK 2D-Dev] RFR: 8149593: Change <code>foo</code> to {@code foo} in TIFF plugin classes

[Philip Race]

+1

My eyes were glazing over but since it seems to have correctly
handled tricky changes like this one below it seems probable to all be good.

-     *<p>  The default implementation calls<code>decodeRaw(byte[] b,
-     * ...)</code>  and copies the resulting data into<code>s</code>.
+     *<p>  The default implementation calls {@code decodeRaw(byte[] b,
+     * ...)} and copies the resulting data into {@code s}.

-phil.



On 2/10/16, 2:57 PM, Brian Burkhalter wrote:
> I re-ran the script on the .00 version of the patch and it seems to 
> have fixed the problem:
>
> http://cr.openjdk.java.net/~bpb/8149593/webrev.01/ 
> <http://cr.openjdk.java.net/%7Ebpb/8149593/webrev.01/>
>
> Please let me know should I have botched anything else. ;-)
>
> Thanks,
>
> Brian
>
> On Feb 10, 2016, at 2:47 PM, Brian Burkhalter 
> <brian.burkhalter at oracle.com <mailto:brian.burkhalter at oracle.com>> wrote:
>
>> Apparently not. It’s a decade old script. I’ll check it out. Thanks 
>> for the catch. Perhaps I could just run it N times instead?
>>
>> Brian
>>
>> On Feb 10, 2016, at 2:33 PM, Phil Race <philip.race at oracle.com 
>> <mailto:philip.race at oracle.com>> wrote:
>>
>>> Does your transmogrifier work where there is more than one per line ?
>>>
>>> I expected both to be changed here :
>>> -     * the<code>JPEGTables</code>. Default value is<code>null</code>.
>>> +     * the {@code JPEGTables}. Default value is<code>null</code>.
>>>
>>> -phil.
>>>
>>> On 02/10/2016 01:41 PM, Brian Burkhalter wrote:
>>>> Please review at your convenience.
>>>>
>>>> Issue:https://bugs.openjdk.java.net/browse/JDK-8149593
>>>> Patch:http://cr.openjdk.java.net/~bpb/8149593/webrev.00/ 
>>>> <http://cr.openjdk.java.net/%7Ebpb/8149593/webrev.00/>
>>>>
>>>> Summary: Transmogrify “<code>foo</code>” to “{@code foo}”. The 
>>>> patch is long but the changes are all the same (quotation marks 
>>>> omitted):
>>>>
>>>>  1. “<code>" changed to “{@code “.
>>>>  2. “</code>” change to “}”
>>>>  3. “2015,” changed to “2016,"
>>>>
>>>>
>>>> Both the source and the docs builds succeed, the latter with no 
>>>> errors or warning in these affected classes.
>>>>
>>>> Thanks,
>>>>
>>>> Brian
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20160210/57edacec/attachment.html>