[OpenJDK 2D-Dev] <AWT Dev> RFR(L): 8160974: [TESTBUG] Mark more headful tests with @key headful.
volker.simonis at gmail.com
Wed Jul 20 13:29:41 UTC 2016
your change looks good. Thanks a lot for cleaning up all these tests!
I only found one problem which you should fix:
@@ -1,6 +1,6 @@
Seems like there's an extra backslash at the beginning of the first line.
You may also want to '@test' on a line by itself like you've done it
for all the other tests in
- @bug 7068740
- @summary JTable wrapped in JLayer can't use PGUP/PGDOWN keys
- @author Vladislav Karnaukhov
- @run main bug7068740
+ * @key headful
+ * @bug 7068740
+ * @summary JTable wrapped in JLayer can't use PGUP/PGDOWN keys
+ * @author Vladislav Karnaukhov
+ * @run main bug7068740
And correctly indent in the following two cases:
diff --git a/test/javax/swing/LookAndFeel/6897701/JMenuItemsTest.java
@@ -23,6 +23,7 @@
+ * @key headful
* @bug 6897701
diff --git a/test/javax/swing/plaf/synth/7158712/bug7158712.java
@@ -21,7 +21,9 @@
+ @key headful
There's no need to prepare a new webrev. I won't go through it one
more time anyway :)
On Tue, Jul 19, 2016 at 9:16 PM, Sergey Bylokhov
<Sergey.Bylokhov at oracle.com> wrote:
> Look fine to me.
> On 07.07.16 18:01, Lindenmaier, Goetz wrote:
>> This change is ‘L’ because there are changes to a lot of files, but the
>> are all similar, so it’s rather easy to review.
>> Similar to 8159690 I added @key headful to another around 600 tests.
>> I used different patterns to grep for the headful exceptions.
>> These are now all I could find with grepping and the like. I have around
>> 80 failing tests remaining, where a row will probably also depend on
>> a display, but I want to look at them more closely, so I don’t want
>> to include them here.
>> Please review this change:
>> Best regards,
> Best regards, Sergey.
More information about the 2d-dev