[OpenJDK 2D-Dev] [9] RFR JDK-4882305: StreamPrintServ.getSupportedAttributeValues returns null for Orientation attr

Ajit Ghaisas ajit.ghaisas at oracle.com
Fri Jul 22 11:09:23 UTC 2016


Hi Prasanta,

 

1.       The test contains commented code – that needs to be removed

2.       The test only tests for image/jpeg docFlavor – what about image/gif and image/png docflavors testing?

3.       The year in banner at the top of PSStreamPrintService.java can be updated

 

Regards,

Ajit

 

From: Philip Race 
Sent: Wednesday, July 20, 2016 8:44 PM
To: Prasanta Sadhukhan
Cc: 2d-dev
Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-4882305: StreamPrintServ.getSupportedAttributeValues returns null for Orientation attr

 

+1

-phil.

On 7/14/16, 2:09 AM, Prasanta Sadhukhan wrote: 

Hi All,

Please review a fix for an issue where it is seen that 
even though StreamPrintService returns OrientationRequested category as supported, when actually querying the supported attribute value with respect to the supported DocFlavors, 
null values are returned for the Orientation attributes when the DocFlavor is not either Pageable or Printable (SERVICE_FORMATTED)
BUT we can print a jpeg iamge using StreamPrintService in LANDSCAPE mode and it worked fine so StreamPrintService should not return the supported values as null for supported DocFlavor.

Bug: https://bugs.openjdk.java.net/browse/JDK-4882305
webrev: HYPERLINK "http://cr.openjdk.java.net/%7Epsadhukhan/4882305/webrev.00/"http://cr.openjdk.java.net/~psadhukhan/4882305/webrev.00/

Proposed fix is to add the image/jpeg, image/gif, image/png docflavor in addition to Pageable/Printable for Orientation attribute.

Regards
Prasanta
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20160722/2a9b1605/attachment.html>


More information about the 2d-dev mailing list