[OpenJDK 2D-Dev] Review Request for JDK-8044289 : In ImageIO.read() and write() NPE is not handled properly for stream

[Philip Race]

The test writes out into "test.src".
I believe that you should treat that as a "read-only" location.
Write to a tempfile (File.createTempFile()) or TESTCLASSES.

-phil.

On 3/15/16, 10:50 PM, Jayathirth D V wrote:
>
> Hi Phil,All
>
> _Please review the following fix in JDK9:_
>
> __
>
> Bug : https://bugs.openjdk.java.net/browse/JDK-8044289
>
> Webrev : http://cr.openjdk.java.net/~jdv/8044289/webrev.00/ 
> <http://cr.openjdk.java.net/%7Ejdv/8044289/webrev.00/>
>
> Issue : When createImageInputStream() or createImageOutputStream 
> returns null in ImageIO.read() or ImageIO.write() we are seeing NPE as 
> it stream is used further without null check.
>
> Root cause : "stream" is used without checking whether it is null or not.
>
> Solution : Handle null pointer of stream and throw IIOException.
>
> Test case contains all possible scenarios where 
> createImageInputStream() or createImageOutputStream can return null.
>
> Thanks,
>
> Jay
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20160316/f54a5528/attachment.html>