[OpenJDK 2D-Dev] RFR 8144938: Handle properly coordinate overflow in Marlin Renderer
bourges.laurent at gmail.com
Fri Mar 18 16:52:36 UTC 2016
Here is a final webrev (for archive):
- remove loops in CrashNaNTest
Hope it is ready to go !
I need another reviewer, please.
2016-03-18 1:44 GMT+01:00 Jim Graham <james.graham at oracle.com>:
> Hi Laurent,
> That looks fine. If the subPathStarted changes are the only changes then
> it's good to go. If there was some other change that I missed, let me know
> so I can review it as well.
No this webrev had only changes in MRE.pathToLoop() you reviewed.
> One curiosity - in the test case, why are there 3 for loops that perform
> exactly one pass? (lines 134, 221, 282) I'm guessing that maybe in a
> former life this code may have been part of a performance suite or
> something? It's not a bug, just an odd bit of code. You can delete them
> if you want, but I don't need to see a review of that...
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the 2d-dev