[OpenJDK 2D-Dev] RFR 8144938: Handle properly coordinate overflow in Marlin Renderer

Laurent Bourgès bourges.laurent at gmail.com
Wed Mar 23 20:41:44 UTC 2016


Phil & Jim,

Thanks for the reviews !

I just pushed this patch after a complete synch (jigsaw): build & tested
with MapBench.

Laurent


2016-03-22 20:51 GMT+01:00 Phil Race <philip.race at oracle.com>:

> +1 .. looks like a nice simplification.
>
> Sorry it took me a couple of days to get back to this.
>
> -phil.
>
>
> On 03/18/2016 03:47 PM, Jim Graham wrote:
>
>> The edit looks fine to me...  Phil?
>>
>>         ...jim
>>
>> On 3/18/16 9:52 AM, Laurent Bourgès wrote:
>>
>>> Jim,
>>>
>>> Here is a final webrev (for archive):
>>> http://cr.openjdk.java.net/~lbourges/marlin/marlin-8144938.5/
>>>
>>> Changes:
>>> - remove loops in CrashNaNTest
>>>
>>> Hope it is ready to go !
>>>
>>> I need another reviewer, please.
>>>
>>>
>>> 2016-03-18 1:44 GMT+01:00 Jim Graham <james.graham at oracle.com
>>> <mailto:james.graham at oracle.com>>:
>>>
>>>     Hi Laurent,
>>>
>>>     That looks fine.  If the subPathStarted changes are the only changes
>>>     then it's good to go.  If there was some other change that I missed,
>>>     let me know so I can review it as well.
>>>
>>>
>>> No this webrev had only changes in MRE.pathToLoop() you reviewed.
>>>
>>>
>>>     One curiosity - in the test case, why are there 3 for loops that
>>>     perform exactly one pass?  (lines 134, 221, 282)  I'm guessing that
>>>     maybe in a former life this code may have been part of a performance
>>>     suite or something?  It's not a bug, just an odd bit of code.  You
>>>     can delete them if you want, but I don't need to see a review of
>>> that...
>>>
>>>
>>> Fixed, now.
>>>
>>> Cheers,
>>> Laurent
>>>
>>
>


-- 
-- 
Laurent Bourgès
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20160323/ccf05636/attachment.html>


More information about the 2d-dev mailing list