[OpenJDK 2D-Dev] Review Request: JDK-6587251 Import declaration not used in sun.java2d.*
Phil Race
philip.race at oracle.com
Tue May 17 17:20:11 UTC 2016
+1
-phil.
On 05/17/2016 03:38 AM, prasanta sadhukhan wrote:
> Looks good.
>
> Regards
> Prasanta
> On 5/17/2016 4:04 PM, Prem Balakrishnan wrote:
>>
>> Hi Prasanta,
>>
>> Thank you for the Review.
>>
>> Updated patch as per review comments.
>>
>> http://cr.openjdk.java.net/~pkbalakr/6587251/webrev.01/
>>
>> Regards,
>> Prem
>>
>> *From:*prasanta sadhukhan
>> *Sent:* Tuesday, May 17, 2016 3:33 PM
>> *To:* Prem Balakrishnan; Philip Race; 2d-dev at openjdk.java.net
>> *Subject:* Re: Review Request: JDK-6587251 Import declaration not
>> used in sun.java2d.*
>>
>> Hi Prem,
>>
>> Looks good to me.
>> Some files you have changed the copyright year, some files you have
>> not like
>> sun/java2d/pipe/OutlineTextRenderer.java, sun/java2d/pipe/LoopPipe.java
>> although I do not think it is necessary to change manually, but
>> please be consistent.
>>
>> Also, please put "noreg-cleanup" in the bug label.
>>
>> Regards
>> Prasanta
>>
>> On 5/17/2016 3:00 PM, Prem Balakrishnan wrote:
>>
>> Hi,
>>
>> Please review fix for JDK9,
>>
>> *Bug:*https://bugs.openjdk.java.net/browse/JDK-6587251
>>
>> *Webrev:*http://cr.openjdk.java.net/~pkbalakr/6587251/webrev.00/
>> <http://cr.openjdk.java.net/%7Epkbalakr/6587251/webrev.00/>
>>
>> Removed unused Import declaration in sun.java2d.*
>>
>> Regards,
>> Prem
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20160517/6e26b079/attachment.html>
More information about the 2d-dev
mailing list