[OpenJDK 2D-Dev] [9] RFR 6212751: DOC: ServiceUI.printDialog() need to enhance the description for X, Y coordinates

[Phil Race]

Before I forget this one looks as if it may need a CCC - if it goes that 
far.
Remember to revisit that before it is done.

Yet I am not sure I accept what is written in the bug report as being 
the basis
for updating these docs.

The existing javadoc on ServiceUI appears consistent with what is 
written here :
https://docs.oracle.com/javase/8/docs/api/java/awt/GraphicsConfiguration.html

The specified "GC" - best written out as "GraphicsConfiguration" in the 
docs -
targets a specific physical monitor/screen regardless of whether the screens
are separate or there is one virtual screen spanning them.
The x/y are then relative to the origin of that monitor/screen.

 >this value depicts the GC ofthe active window.

All references to "active window" fall flat if there is no such window
so I don't think you should (or can) bake such an assumption into the 
javadoc.
Remember this dialog could be the *only* window that is ever displayed 
by the app.

But even more importantly this is simply wrong.
I can specify *any* GC I want. Nothing should be forcing me to display it
only on the same screen as the active window - if there is one.
It might be what you usually want to do but that is a choice ..

If I was to speculate, I might say that the comments written in 6212751
were a result of confusion due to the issues described in 8138749 (and
its original report under 5109347).

-phil.

On 05/27/2016 04:54 AM, prasanta sadhukhan wrote:
>
> Hi All,
>
> Please review a doc fix for jdk9.
> Bug: https://bugs.openjdk.java.net/browse/JDK-6212751
> webrev: http://cr.openjdk.java.net/~psadhukhan/6212751/webrev.00/
>
> After JDK-8138749 <https://bugs.openjdk.java.net/browse/JDK-8138749> 
> multimonitor support fix, the doc needs some change. It was also 
> misleading in the first place as the bugdescription pointed out
> which is API doc for ServiceUI.printDialog() specifies that X,Y are 
> location of the dialog in screen coordinates, but for multmonitor 
> setup, it should be w.r.t to secondary screen
> because
> . If the sec monitor starts at 1025, 0 and If I specify 1025 as the X 
> coordinate, the calculated X value would be 1025 + 1025 = 2050 which 
> actually exceeds the bounds of virtual screen.
>
> Updated the documentation .
>
> Regards
> Prasanta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/2d-dev/attachments/20160531/e5ed33fd/attachment.html>