[OpenJDK 2D-Dev] RFR: 8165981: Consider making some classes in javax.imageio.plugins.tiff final

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Tue Oct 4 23:13:08 UTC 2016


Probably some methods can be made final also (at least setters and getters)?
because it always a problem when we validate something in the 
setter(constructor), but the user returns something unspecified from the 
overriden getter.

On 03.10.16 22:51, Brian Burkhalter wrote:
> Good point. I think TIFFIFD needs to be a subclass therefore lets leave
> TIFFDirectory as is.
>
> Thanks,
>
> Brian
>
> On Oct 3, 2016, at 12:44 PM, Phil Race <philip.race at oracle.com
> <mailto:philip.race at oracle.com>> wrote:
>
>> >  Question is whether TIFFDirectory might be made final as well.
>>
>> com.sun.imageio.plugins.tiff.TIFFIFD extends TIFFDirectory so that
>> is more than a case of marking it final.
>> Therefore it at least depends on whether you think that internal subclass
>> really needs to be a subclass ?
>


-- 
Best regards, Sergey.



More information about the 2d-dev mailing list