[OpenJDK 2D-Dev]  RFR JDK-6294607: GIFWriter returns the same compression type twice
Jayathirth D V
jayathirth.d.v at oracle.com
Thu Oct 6 08:19:22 UTC 2016
As discussed offline, I have updated test case to include check for duplication of compression types for all ImageIO plugins.
Please review the updated webrev at your convenience :
From: Jayathirth D V
Sent: Wednesday, October 05, 2016 12:23 PM
To: Philip Race; 2d-dev
Subject: RE: [OpenJDK 2D-Dev]  RFR JDK-6294607: GIFWriter returns the same compression type twice
I have verified all plugins only GIF has this duplication problem.
From: Phil Race
Sent: Tuesday, October 04, 2016 9:54 PM
To: Jayathirth D V; 2d-dev
Subject: Re: [OpenJDK 2D-Dev]  RFR JDK-6294607: GIFWriter returns the same compression type twice
This seems fine to me. Perhaps the test could be reworked to
look for any plugin that reports a duplicate compression type ?
That may be more useful as a test ..
Is this the only plugin that exhibits such duplication ?
On 10/04/2016 04:39 AM, Jayathirth D V wrote:
Please review the following fix in JDK9 at your convenience:
Bug : https://bugs.openjdk.java.net/browse/JDK-6294607
Webrev : HYPERLINK "http://cr.openjdk.java.net/%7Ejdv/6294607/webrev.00/"http://cr.openjdk.java.net/~jdv/6294607/webrev.00/
Issue : When we call ImageWriteParam.getCompressionTypes() for GIF it returns two compression types "LZW" & "lzw".
Root cause : Basically we support only LZW compression for GIF. In ImageWriteParam, there are many places in specification where we mention about multiple compression types. In case of GIF, since it returns same compression type twice it would be misleading.
Solution : Update GIFImageWriter to return only one compression type string.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the 2d-dev