[OpenJDK 2D-Dev] [9] Review Request: 8167310 The graphics clip is incorrectly rounded for some fractional scales

Jim Graham james.graham at oracle.com
Mon Oct 10 19:34:37 UTC 2016

Yes, we do bias both.  So, the code we just added doesn't match the biasing that is performed by the fill operations, we 
should probably make it be the same.  You can see that it computes a bias boolean when it calls getFillSSI(), but the 
bias is applied natively in the native ShapeSpanIterator code...


On 10/10/16 12:26 PM, Sergey Bylokhov wrote:
> On 10.10.16 22:04, Sergey Bylokhov wrote:
>> On 10.10.16 21:55, Sergey Bylokhov wrote:
>>>> Will give us a pass on the test as long as we made the same mistake for
>>>> both the rect clip and the shape clip.  I think you want "(rgb !=
>>>> goldRGB) || (rgb != GREEN && rgb != RED)"...?
>>> Correct, I will update the test.
>> surprisingly but it is produce the different results.... And I think
>> that the clip which is set via Shape is shifted, because the first and
>> last fillRects cover only the half of expected area. But in case of
>> clip=rectangle all fillRects produce the same areas.
> It was solved by stroke=PURE, but I am not sure why fillRect(when clip is set via Shape) is affected by this hint. Is it
> ok?

More information about the 2d-dev mailing list