[OpenJDK 2D-Dev] Marlin vs OpenPisces
james.graham at oracle.com
Thu Oct 13 20:24:32 UTC 2016
I'm trying to track down the old history after a lot of file moves, but here is what I have so far:
(Note that some of these only apply when we use it in non-AA mode where we set the number of subpixel samples to 1x1)
https://bugs.openjdk.java.net/browse/JDK-8092682 (non-AA: changing BND constants)
https://bugs.openjdk.java.net/browse/JDK-8094493 (needed for non-AA, but applicable to AA)
https://bugs.openjdk.java.net/browse/JDK-8094313 (first attempt to use for both AA/non-AA)
https://bugs.openjdk.java.net/browse/JDK-8088013 (fixed, then backed out, replaced by 8094313)
https://bugs.openjdk.java.net/browse/JDK-8097787 (likely the dash fixes you noted below)
https://bugs.openjdk.java.net/browse/JDK-8119693 (AIOOB in dash array growth)
At that point, the files were moved from another repo during a huge open-sourcing effort so I'll need a little more
digging to find further history.
Also, I don't think there is any history for "changes that were made when we ported it from the JDK". I don't think
there were any "bug fixes" during that work for the initial commit, though, so we can probably assume that the change
logs (when I can find the pre-open-source list) were the sum total of all of the bug fixes...
On 10/13/16 1:05 PM, Phil Race wrote:
> On 10/13/2016 12:22 PM, Laurent Bourgès wrote:
>> I looked at openpisces enhancements in compare to pisces I forked in 2013.6 and noticed at least 2 important changes:
>> - Dasher initialization: handle too small phase
>> - Stroker: new cases for parallel directions between control points in quad / cubic curve subdivision
>> I plan to upgrade Marlin in jdk9 to integrate those improvements.
>> Is there OpenJFX bugs and tests to reproduce those complex situations ?
> Between FX having multiple source code restructuring, open-sourcing losing history and
> a change from not always using bug ids in the commit through a change in
> bug system .. and no strict requirements about regression tests it might be
> challenging to identify the bugs under which such changes were made.
> Maybe Jim can help a bit since he may have made or at least reviewed those changes.
>> Do you know other changes I should look at ?
>> PS: this work is more a backport of bug fixes than enhancements to be accepted in jdk9, isn't it ?
> I think it is still acceptable for 9.
>> Thanks for your feedback,
More information about the 2d-dev